From: Li Huafei <lihuafei1@huawei.com>
To: <acme@kernel.org>, <james.clark@arm.com>, <jolsa@kernel.org>
Cc: <peterz@infradead.org>, <mark.rutland@arm.com>,
<mingo@redhat.com>, <alexander.shishkin@linux.intel.com>,
<namhyung@kernel.org>, <mliska@suse.cz>, <irogers@google.com>,
<dzhu@wavecomp.com>, <rickyman7@gmail.com>,
<yao.jin@linux.intel.com>, <linux-perf-users@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <zhangjinhao2@huawei.com>
Subject: [PATCH 2/2] perf annotate: Add error log in symbol__annotate()
Date: Mon, 26 Jul 2021 20:38:54 +0800 [thread overview]
Message-ID: <20210726123854.13463-2-lihuafei1@huawei.com> (raw)
In-Reply-To: <20210726123854.13463-1-lihuafei1@huawei.com>
When users use the perf annotate feature on unsupported machines, error
logs should be printed for user feedback.
Signed-off-by: Li Huafei <lihuafei1@huawei.com>
---
tools/perf/util/annotate.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
index aa04a3655236..cb280de3369f 100644
--- a/tools/perf/util/annotate.c
+++ b/tools/perf/util/annotate.c
@@ -2192,8 +2192,10 @@ int symbol__annotate(struct map_symbol *ms, struct evsel *evsel,
return errno;
args.arch = arch = arch__find(arch_name);
- if (arch == NULL)
+ if (arch == NULL) {
+ pr_err("%s: unsupported arch %s\n", __func__, arch_name);
return ENOTSUP;
+ }
if (parch)
*parch = arch;
--
2.17.1
next prev parent reply other threads:[~2021-07-26 12:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-26 12:38 [PATCH v2 1/2] perf env: Normalize aarch64.* and arm64.* to arm64 in normalize_arch() Li Huafei
2021-07-26 12:38 ` Li Huafei [this message]
2021-07-26 15:19 ` [PATCH 2/2] perf annotate: Add error log in symbol__annotate() James Clark
2021-07-27 15:55 ` Arnaldo Carvalho de Melo
2021-07-26 15:18 ` [PATCH v2 1/2] perf env: Normalize aarch64.* and arm64.* to arm64 in normalize_arch() James Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210726123854.13463-2-lihuafei1@huawei.com \
--to=lihuafei1@huawei.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=dzhu@wavecomp.com \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=mliska@suse.cz \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=rickyman7@gmail.com \
--cc=yao.jin@linux.intel.com \
--cc=zhangjinhao2@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).