From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B11FCC761A6 for ; Thu, 30 Mar 2023 10:55:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231287AbjC3Kzk (ORCPT ); Thu, 30 Mar 2023 06:55:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52120 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231348AbjC3Kzd (ORCPT ); Thu, 30 Mar 2023 06:55:33 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id F298B9009; Thu, 30 Mar 2023 03:55:21 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DDE4F2F4; Thu, 30 Mar 2023 03:56:05 -0700 (PDT) Received: from [10.57.56.86] (unknown [10.57.56.86]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 19F533F73F; Thu, 30 Mar 2023 03:55:18 -0700 (PDT) Message-ID: <20c28979-53a7-19eb-16fd-4d8535454d4e@arm.com> Date: Thu, 30 Mar 2023 11:55:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v8 1/3] perf: cs-etm: Move mapping of Trace ID and cpu into helper function To: Leo Yan , Arnaldo Carvalho de Melo Cc: Mike Leach , linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org, linux-kernel@vger.kernel.org, peterz@infradead.org, mingo@redhat.com, will@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@redhat.com, namhyung@kernel.org, gankulkarni@os.amperecomputing.com, darren@os.amperecomputing.com, James Clark References: <20230329111422.3693-1-mike.leach@linaro.org> <20230329111422.3693-2-mike.leach@linaro.org> <20230330031307.GD252145@leoy-yangtze.lan> From: Suzuki K Poulose In-Reply-To: <20230330031307.GD252145@leoy-yangtze.lan> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org On 30/03/2023 04:13, Leo Yan wrote: > On Wed, Mar 29, 2023 at 07:14:52PM -0300, Arnaldo Carvalho de Melo wrote: > > [...] > >>> Not here, I'll check after a call: >>> >>> 50 9.90 ubuntu:18.04-x-arm : FAIL gcc version 7.5.0 (Ubuntu/Linaro 7.5.0-3ubuntu1~18.04) >>> arch/arm/util/cs-etm.c: In function 'cs_etm_save_ete_header': >>> arch/arm/util/cs-etm.c:720:29: error: implicit declaration of function 'coresight_get_trace_id' [-Werror=implicit-function-declaration] >>> data[CS_ETE_TRCTRACEIDR] = coresight_get_trace_id(cpu); >>> ^~~~~~~~~~~~~~~~~~~~~~ >> >> This function was removed in: >> >> Author: Mike Leach >> Date: Wed Mar 29 12:14:21 2023 +0100 >> >> perf cs-etm: Update record event to use new Trace ID protocol >> >> Trace IDs are now dynamically allocated. >> >> I'm removing this series from perf-tools-next, please address this issue >> and send a v9. > > I can reproduce this building failure. I am curious for how to verify > building for patch wise, the link [1] gives me some hints and below > command works for me: > > $ git rebase -i --exec "make -C tools/perf clean && \ > make -C tools/perf VF=1 DEBUG=1 CORESIGHT=1 && \ > make -C tools/perf clean && \ > make -C tools/perf VF=1 DEBUG=1" HEAD~3 Looks like perf-tools-next has some changes that has not reflected elsewhere. The ts_source patches are queued there, which is causing the above build failure. Mike, Are you able to rebase your patches on perf-tools-next branch ? Kind regards Suzuki > > Thanks, > Leo > > [1] https://stackoverflow.com/questions/26983700/git-run-shell-command-for-each-commit