From: Zhihao Cheng <chengzhihao1@huawei.com> To: Arnaldo Carvalho de Melo <acme@kernel.org> Cc: <peterz@infradead.org>, <mingo@redhat.com>, <jolsa@redhat.com>, <ast@kernel.org>, <daniel@iogearbox.net>, <andrii@kernel.org>, <nathan@kernel.org>, <ndesaulniers@google.com>, <linux-perf-users@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>, <bpf@vger.kernel.org>, <clang-built-linux@googlegroups.com>, <yukuai3@huawei.com> Subject: Re: [PATCH] perf llvm: Fix error return code in llvm__compile_bpf() Date: Fri, 2 Jul 2021 11:01:27 +0800 [thread overview] Message-ID: <21406430-56f0-c59b-7ece-7fd387bb47e9@huawei.com> (raw) In-Reply-To: <YN35TYxboEdM5iHc@kernel.org> 在 2021/7/2 1:20, Arnaldo Carvalho de Melo 写道: > Em Wed, Jun 09, 2021 at 07:59:45PM +0800, Zhihao Cheng escreveu: >> Fix to return a negative error code from the error handling >> case instead of 0, as done elsewhere in this function. > > I checked and llvm__compile_bpf() returns -errno, so I'll change this to > instead set err to -ENOMEM just before the if (asprintf)(), ok? > > - Arnaldo > Glad to accept this change. >> Fixes: cb76371441d098 ("perf llvm: Allow passing options to llc ...") >> Fixes: 5eab5a7ee032ac ("perf llvm: Display eBPF compiling command ...") >> Reported-by: Hulk Robot <hulkci@huawei.com> >> Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com>
prev parent reply other threads:[~2021-07-02 3:01 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-09 11:59 Zhihao Cheng 2021-07-01 17:20 ` Arnaldo Carvalho de Melo 2021-07-02 3:01 ` Zhihao Cheng [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=21406430-56f0-c59b-7ece-7fd387bb47e9@huawei.com \ --to=chengzhihao1@huawei.com \ --cc=acme@kernel.org \ --cc=andrii@kernel.org \ --cc=ast@kernel.org \ --cc=bpf@vger.kernel.org \ --cc=clang-built-linux@googlegroups.com \ --cc=daniel@iogearbox.net \ --cc=jolsa@redhat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-perf-users@vger.kernel.org \ --cc=mingo@redhat.com \ --cc=nathan@kernel.org \ --cc=ndesaulniers@google.com \ --cc=netdev@vger.kernel.org \ --cc=peterz@infradead.org \ --cc=yukuai3@huawei.com \ --subject='Re: [PATCH] perf llvm: Fix error return code in llvm__compile_bpf()' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).