From: "Arnd Bergmann" <arnd@arndb.de>
To: "Bjorn Andersson" <quic_bjorande@quicinc.com>
Cc: "Bjorn Andersson" <andersson@kernel.org>, arm <arm@kernel.org>,
soc@kernel.org, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
"Andy Gross" <agross@kernel.org>,
"Olof Johansson" <olof@lixom.net>,
"Kevin Hilman" <khilman@baylibre.com>,
"Konrad Dybcio" <konrad.dybcio@linaro.org>,
"Stephan Gerhold" <stephan@gerhold.net>,
"Souradeep Chowdhury" <quic_schowdhu@quicinc.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Bagas Sanjaya" <bagasdotme@gmail.com>,
"Bartosz Golaszewski" <bartosz.golaszewski@linaro.org>,
"Guru Das Srinagesh" <quic_gurus@quicinc.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
"Bryan O'Donoghue" <bryan.odonoghue@linaro.org>,
"Dawei Li" <set_pte_at@outlook.com>,
"Loic Poulain" <loic.poulain@linaro.org>,
"Melody Olvera" <quic_molvera@quicinc.com>,
"Naman Jain" <quic_namajain@quicinc.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Yang Li" <yang.lee@linux.alibaba.com>,
"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
coresight@lists.linaro.org,
"Mathieu Poirier" <mathieu.poirier@linaro.org>,
"Suzuki K Poulose" <suzuki.poulose@arm.com>,
"Mike Leach" <mike.leach@linaro.org>,
"Leo Yan" <leo.yan@linaro.org>,
"Peter Zijlstra" <peterz@infradead.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Arnaldo Carvalho de Melo" <acme@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Jiri Olsa" <jolsa@kernel.org>,
"Namhyung Kim" <namhyung@kernel.org>,
linux-perf-users@vger.kernel.org,
"John Garry" <john.g.garry@oracle.com>,
"Will Deacon" <will@kernel.org>,
"James Clark" <james.clark@arm.com>
Subject: Re: [GIT PULL] Qualcomm driver updates for v6.3
Date: Tue, 04 Apr 2023 20:23:39 +0200 [thread overview]
Message-ID: <2b04a64a-80fe-4ff3-b78b-2f999c8be9f6@app.fastmail.com> (raw)
In-Reply-To: <20230324172657.GE309305@hu-bjorande-lv.qualcomm.com>
On Fri, Mar 24, 2023, at 18:26, Bjorn Andersson wrote:
> On Wed, Feb 15, 2023 at 04:05:36PM +0100, Arnd Bergmann wrote:
>> On Mon, Jan 30, 2023, at 23:24, Bjorn Andersson wrote:
>
> Iiuc pstore provides a place to store system state for analysis after a
> reboot, but DCC provides essentially register dumps on demand - with the
> system reset being a special case trigger.
>
> So I think it would look neat to expose the DCC data alongside other
> pstore data (except for the mentioned issues with ramoops not working on
> most Qualcomm devices), but when the reboot happens DCC captures data in
> the DCC SRAM, not in the pstore (whatever backing might be used). So
> post boot, something would need to get the DCC data into the pstore.
>
> To me this sounds in conflict with the pstore design.
Sorry for the late reply.
The case I was thinking of is making the DCC SRAM a pstore backend
that might be shared with other pstore users, in place of the
other targets like PSTORE_RAM, PSTORE_BLK, EFI_VARS_PSTORE and
the powerpc64 nvram. This might be a bad idea for other reasons of
course, e.g. if it's impossible to have more than one pstore
backend active and the SRAM is too small to contain the data
that would otherwise be store here, or if it's not persistent
enough.
> Further more, with the reboot trigger being the special case, we'd need
> to amend the pstore state in runtime to capture the case where the user
> requested the DCC to capture the state.
>
>
> One idea that I was looking at was to trigger a devcoredump as a way to
> get the data out of the kernel, instead of a new device node. But it
> doesn't seem to fit very well with existing use cases, and I haven't
> used DCC sufficiently - given that it doesn't exist upstream...
You are probably right, but I'm curious about DEV_COREDUMP, as I
haven't actually seen that before, and I can't seem to find any
documentation about what its intention is, though I can see a number
of in-kernel users.
> We made significant changes to the control interface through the review
> process, I think we have something that looks reasonable now, but I
> picked the patches under the premise that it's unstable and in debugfs,
> and exposing the tool to users could lead to more interest in
> polishing it.
Ok
Arnd
prev parent reply other threads:[~2023-04-04 18:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230126163008.3676950-1-andersson@kernel.org>
[not found] ` <cdcff86c-77fe-4c5d-b8e8-58b815b9e969@app.fastmail.com>
[not found] ` <20230130222412.t2tkkhqfep2orxf2@builder.lan>
2023-02-15 15:05 ` [GIT PULL] Qualcomm driver updates for v6.3 Arnd Bergmann
2023-02-22 1:43 ` Leo Yan
2023-02-22 11:16 ` Souradeep Chowdhury
2023-02-22 12:13 ` Leo Yan
2023-02-27 12:43 ` Souradeep Chowdhury
2023-03-13 16:55 ` Trilok Soni
2023-03-23 17:41 ` Trilok Soni
2023-03-24 17:14 ` Bjorn Andersson
2023-03-24 17:26 ` Bjorn Andersson
2023-04-04 18:23 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b04a64a-80fe-4ff3-b78b-2f999c8be9f6@app.fastmail.com \
--to=arnd@arndb.de \
--cc=acme@kernel.org \
--cc=agross@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=andersson@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=arm@kernel.org \
--cc=bagasdotme@gmail.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=bryan.odonoghue@linaro.org \
--cc=coresight@lists.linaro.org \
--cc=james.clark@arm.com \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=khilman@baylibre.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=olof@lixom.net \
--cc=peterz@infradead.org \
--cc=quic_bjorande@quicinc.com \
--cc=quic_gurus@quicinc.com \
--cc=quic_molvera@quicinc.com \
--cc=quic_namajain@quicinc.com \
--cc=quic_schowdhu@quicinc.com \
--cc=set_pte_at@outlook.com \
--cc=soc@kernel.org \
--cc=stephan@gerhold.net \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).