From: Adrian Hunter <adrian.hunter@intel.com>
To: Leo Yan <leo.yan@linaro.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Borislav Petkov <bp@alien8.de>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Mike Leach <mike.leach@linaro.org>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 10/11] perf env: Set flag for kernel is 64-bit mode
Date: Mon, 12 Jul 2021 17:37:21 +0300 [thread overview]
Message-ID: <2df0e179-6302-ac7e-b41c-4f91bfc103de@intel.com> (raw)
In-Reply-To: <20210711104105.505728-11-leo.yan@linaro.org>
On 11/07/21 1:41 pm, Leo Yan wrote:
> It's useful to know that the kernel is running in 32-bit or 64-bit
> mode. E.g. We can decide if perf tool is running in compat mode
> from this info.
>
> This patch adds a global variable "kernel_is_64_bit", it's initialized
> when a session setups environment, its value is decided by checking the
> architecture string.
>
> Signed-off-by: Leo Yan <leo.yan@linaro.org>
> ---
> tools/perf/util/env.c | 17 ++++++++++++++++-
> tools/perf/util/env.h | 1 +
> 2 files changed, 17 insertions(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/env.c b/tools/perf/util/env.c
> index ebc5e9ad35db..345635a2e842 100644
> --- a/tools/perf/util/env.c
> +++ b/tools/perf/util/env.c
> @@ -11,6 +11,7 @@
> #include <stdlib.h>
> #include <string.h>
>
> +int kernel_is_64_bit;
> struct perf_env perf_env;
>
> #ifdef HAVE_LIBBPF_SUPPORT
> @@ -172,6 +173,19 @@ static void perf_env__purge_bpf(struct perf_env *env __maybe_unused)
> }
> #endif // HAVE_LIBBPF_SUPPORT
>
> +static void perf_env__init_kernel_mode(struct perf_env *env)
> +{
> + const char *arch = perf_env__raw_arch(env);
> +
> + if (!strncmp(arch, "x86_64", 6) || !strncmp(arch, "aarch64", 7) ||
> + !strncmp(arch, "arm64", 5) || !strncmp(arch, "mips64", 6) ||
> + !strncmp(arch, "parisc64", 8) || !strncmp(arch, "riscv64", 7) ||
> + !strncmp(arch, "s390x", 5) || !strncmp(arch, "sparc64", 7))
> + kernel_is_64_bit = 1;
> + else
> + kernel_is_64_bit = 0;
> +}
> +
> void perf_env__exit(struct perf_env *env)
> {
> int i;
> @@ -217,13 +231,14 @@ void perf_env__exit(struct perf_env *env)
> zfree(&env->hybrid_cpc_nodes);
> }
>
> -void perf_env__init(struct perf_env *env __maybe_unused)
> +void perf_env__init(struct perf_env *env)
> {
> #ifdef HAVE_LIBBPF_SUPPORT
> env->bpf_progs.infos = RB_ROOT;
> env->bpf_progs.btfs = RB_ROOT;
> init_rwsem(&env->bpf_progs.lock);
> #endif
> + perf_env__init_kernel_mode(env);
perf_env__init() is also used for session->header.env which is not
necessarily the current machine. So this initialization could be
separate from perf_env__init() to avoid confusion.
> }
>
> int perf_env__set_cmdline(struct perf_env *env, int argc, const char *argv[])
> diff --git a/tools/perf/util/env.h b/tools/perf/util/env.h
> index 6824a7423a2d..cc989ff49740 100644
> --- a/tools/perf/util/env.h
> +++ b/tools/perf/util/env.h
> @@ -139,6 +139,7 @@ enum perf_compress_type {
> struct bpf_prog_info_node;
> struct btf_node;
>
> +extern int kernel_is_64_bit;
> extern struct perf_env perf_env;
>
> void perf_env__exit(struct perf_env *env);
>
next prev parent reply other threads:[~2021-07-12 14:37 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-11 10:40 [PATCH v4 00/11] perf: Refine barriers for AUX ring buffer Leo Yan
2021-07-11 10:40 ` [PATCH v4 01/11] perf/ring_buffer: Add comment for barriers on " Leo Yan
2021-07-11 10:40 ` [PATCH v4 02/11] coresight: tmc-etr: Add barrier after updating " Leo Yan
2021-07-12 10:40 ` Suzuki K Poulose
2021-07-12 10:54 ` Leo Yan
2021-07-11 10:40 ` [PATCH v4 03/11] coresight: tmc-etf: Add comment for store ordering Leo Yan
2021-07-13 12:56 ` Peter Zijlstra
2021-07-13 15:49 ` Leo Yan
2021-07-11 10:40 ` [PATCH v4 04/11] perf/x86: Add barrier after updating bts Leo Yan
2021-07-13 13:01 ` Peter Zijlstra
2021-07-11 10:40 ` [PATCH v4 05/11] perf auxtrace: Use WRITE_ONCE() for updating aux_tail Leo Yan
2021-07-11 10:41 ` [PATCH v4 06/11] perf auxtrace: Drop legacy __sync functions Leo Yan
2021-07-11 10:41 ` [PATCH v4 07/11] perf auxtrace: Remove auxtrace_mmap__read_snapshot_head() Leo Yan
2021-07-12 14:32 ` Adrian Hunter
2021-07-13 13:10 ` Leo Yan
2021-07-11 10:41 ` [PATCH v4 08/11] perf: Cleanup for HAVE_SYNC_COMPARE_AND_SWAP_SUPPORT Leo Yan
2021-07-11 10:41 ` [PATCH v4 09/11] tools: Remove feature-sync-compare-and-swap feature detection Leo Yan
2021-07-11 10:41 ` [PATCH v4 10/11] perf env: Set flag for kernel is 64-bit mode Leo Yan
2021-07-12 14:37 ` Adrian Hunter [this message]
2021-07-12 18:14 ` Arnaldo Carvalho de Melo
2021-07-13 15:09 ` Leo Yan
2021-07-13 17:31 ` Hunter, Adrian
2021-07-14 13:59 ` Arnaldo Carvalho de Melo
2021-07-14 14:00 ` Arnaldo Carvalho de Melo
2021-07-23 7:11 ` Leo Yan
2021-07-11 10:41 ` [PATCH v4 11/11] perf auxtrace: Add compat_auxtrace_mmap__{read_head|write_tail} Leo Yan
2021-07-12 14:44 ` Russell King (Oracle)
2021-07-13 15:46 ` Leo Yan
2021-07-13 16:14 ` Russell King (Oracle)
2021-07-13 18:13 ` Catalin Marinas
2021-07-14 8:40 ` Russell King (Oracle)
2021-07-23 7:23 ` Leo Yan
2021-07-13 7:07 ` Adrian Hunter
2021-07-13 15:48 ` Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2df0e179-6302-ac7e-b41c-4f91bfc103de@intel.com \
--to=adrian.hunter@intel.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=bp@alien8.de \
--cc=coresight@lists.linaro.org \
--cc=hpa@zytor.com \
--cc=jolsa@redhat.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=suzuki.poulose@arm.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).