On Wed, Mar 15, 2023 at 10:44:34AM +0530, Anshuman Khandual wrote: > This series enables perf branch stack sampling support on arm64 platform > via a new arch feature called Branch Record Buffer Extension (BRBE). All > relevant register definitions could be accessed here. > > https://developer.arm.com/documentation/ddi0601/2021-12/AArch64-Registers While looking at another feature I noticed that HFGITR_EL2 has two traps for BRBE instructions, nBRBINJ and nBRBIALL which trap BRB INJ and BRB IALL. Even if we don't use those right now does it make sense to document a requirement for those traps to be disabled now in case we need them later, and do so during EL2 setup for KVM guests? That could always be done incrementally. I've got a patch adding the definition of that register to sysreg which I should be sending shortly, no need to duplicate that effort.