From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 237ACC47095 for ; Mon, 7 Jun 2021 19:09:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0C1CD611C0 for ; Mon, 7 Jun 2021 19:09:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230446AbhFGTLK (ORCPT ); Mon, 7 Jun 2021 15:11:10 -0400 Received: from mga04.intel.com ([192.55.52.120]:20063 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231520AbhFGTLK (ORCPT ); Mon, 7 Jun 2021 15:11:10 -0400 IronPort-SDR: aGcBowYOY38qJ/cIaQEyrkL60kAMyuYyVB00wS05Q/+T1XSwpeamTRQ1yhqWFQgvRogEsGagPe xK3e1stACAjA== X-IronPort-AV: E=McAfee;i="6200,9189,10008"; a="202829194" X-IronPort-AV: E=Sophos;i="5.83,255,1616482800"; d="scan'208";a="202829194" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jun 2021 12:09:15 -0700 IronPort-SDR: rPDTs+cItNMrK9xjaJIcnT/NAL0zFQZuU1JPOur3Pk7yI+jwmpDmyqmfAXwkTEXluHMB9dHk73 65wWXyagJP+A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,255,1616482800"; d="scan'208";a="401780624" Received: from linux.intel.com ([10.54.29.200]) by orsmga003.jf.intel.com with ESMTP; 07 Jun 2021 12:09:15 -0700 Received: from [10.212.203.2] (kliang2-MOBL.ccr.corp.intel.com [10.212.203.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by linux.intel.com (Postfix) with ESMTPS id 31A46580223; Mon, 7 Jun 2021 12:09:13 -0700 (PDT) Subject: Re: [PATCH 1/4] perf/x86/intel/uncore: Constify intel_uncore_ops To: Rikard Falkeborn , Peter Zijlstra Cc: Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Thomas Gleixner , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Alexander Antonov References: <20210605155653.21850-1-rikard.falkeborn@gmail.com> <20210605155653.21850-2-rikard.falkeborn@gmail.com> From: "Liang, Kan" Message-ID: <77212f9f-1914-afd2-99c1-a5ced5b7c265@linux.intel.com> Date: Mon, 7 Jun 2021 15:09:11 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210605155653.21850-2-rikard.falkeborn@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org On 6/5/2021 11:56 AM, Rikard Falkeborn wrote: > These are not modified, so make them const to allow the compiler to put > them in read-only memory. For most of the cases, yes, but the ops are modified for the TGL/RKL. We may want to create a read-only ops for the TGL/RKL as below, and make both skl_uncore_msr_ops and rkl_uncore_msr_ops const as well. diff --git a/arch/x86/events/intel/uncore_snb.c b/arch/x86/events/intel/uncore_snb.c index 0f63706..e750514 100644 --- a/arch/x86/events/intel/uncore_snb.c +++ b/arch/x86/events/intel/uncore_snb.c @@ -435,14 +435,22 @@ static void rkl_uncore_msr_init_box(struct intel_uncore_box *box) wrmsrl(SKL_UNC_PERF_GLOBAL_CTL, SNB_UNC_GLOBAL_CTL_EN); } +static struct intel_uncore_ops rkl_uncore_msr_ops = { + .init_box = rkl_uncore_msr_init_box, + .enable_box = skl_uncore_msr_enable_box, + .exit_box = skl_uncore_msr_exit_box, + .disable_event = snb_uncore_msr_disable_event, + .enable_event = snb_uncore_msr_enable_event, + .read_counter = uncore_msr_read_counter, +}; + void tgl_uncore_cpu_init(void) { uncore_msr_uncores = tgl_msr_uncores; icl_uncore_cbox.num_boxes = icl_get_cbox_num(); - icl_uncore_cbox.ops = &skl_uncore_msr_ops; - icl_uncore_clockbox.ops = &skl_uncore_msr_ops; - snb_uncore_arb.ops = &skl_uncore_msr_ops; - skl_uncore_msr_ops.init_box = rkl_uncore_msr_init_box; + icl_uncore_cbox.ops = &rkl_uncore_msr_ops; + icl_uncore_clockbox.ops = &rkl_uncore_msr_ops; + snb_uncore_arb.ops = &rkl_uncore_msr_ops; } static void adl_uncore_msr_init_box(struct intel_uncore_box *box) Thanks, Kan > > Signed-off-by: Rikard Falkeborn > --- > arch/x86/events/intel/uncore.h | 2 +- > arch/x86/events/intel/uncore_discovery.c | 6 +-- > arch/x86/events/intel/uncore_nhmex.c | 10 ++-- > arch/x86/events/intel/uncore_snb.c | 12 ++--- > arch/x86/events/intel/uncore_snbep.c | 66 ++++++++++++------------ > 5 files changed, 48 insertions(+), 48 deletions(-) > > diff --git a/arch/x86/events/intel/uncore.h b/arch/x86/events/intel/uncore.h > index 187d7287039c..83b25a7b8c27 100644 > --- a/arch/x86/events/intel/uncore.h > +++ b/arch/x86/events/intel/uncore.h > @@ -77,7 +77,7 @@ struct intel_uncore_type { > struct event_constraint unconstrainted; > struct event_constraint *constraints; > struct intel_uncore_pmu *pmus; > - struct intel_uncore_ops *ops; > + const struct intel_uncore_ops *ops; > struct uncore_event_desc *event_descs; > struct freerunning_counters *freerunning; > const struct attribute_group *attr_groups[4]; > diff --git a/arch/x86/events/intel/uncore_discovery.c b/arch/x86/events/intel/uncore_discovery.c > index aba9bff95413..2b8e9a1d793e 100644 > --- a/arch/x86/events/intel/uncore_discovery.c > +++ b/arch/x86/events/intel/uncore_discovery.c > @@ -368,7 +368,7 @@ static void intel_generic_uncore_msr_disable_event(struct intel_uncore_box *box, > wrmsrl(hwc->config_base, 0); > } > > -static struct intel_uncore_ops generic_uncore_msr_ops = { > +static const struct intel_uncore_ops generic_uncore_msr_ops = { > .init_box = intel_generic_uncore_msr_init_box, > .disable_box = intel_generic_uncore_msr_disable_box, > .enable_box = intel_generic_uncore_msr_enable_box, > @@ -433,7 +433,7 @@ static u64 intel_generic_uncore_pci_read_counter(struct intel_uncore_box *box, > return count; > } > > -static struct intel_uncore_ops generic_uncore_pci_ops = { > +static const struct intel_uncore_ops generic_uncore_pci_ops = { > .init_box = intel_generic_uncore_pci_init_box, > .disable_box = intel_generic_uncore_pci_disable_box, > .enable_box = intel_generic_uncore_pci_enable_box, > @@ -516,7 +516,7 @@ static void intel_generic_uncore_mmio_disable_event(struct intel_uncore_box *box > writel(0, box->io_addr + hwc->config_base); > } > > -static struct intel_uncore_ops generic_uncore_mmio_ops = { > +static const struct intel_uncore_ops generic_uncore_mmio_ops = { > .init_box = intel_generic_uncore_mmio_init_box, > .exit_box = uncore_mmio_exit_box, > .disable_box = intel_generic_uncore_mmio_disable_box, > diff --git a/arch/x86/events/intel/uncore_nhmex.c b/arch/x86/events/intel/uncore_nhmex.c > index 173e2674be6e..5f7c27d7f428 100644 > --- a/arch/x86/events/intel/uncore_nhmex.c > +++ b/arch/x86/events/intel/uncore_nhmex.c > @@ -262,7 +262,7 @@ static void nhmex_uncore_msr_enable_event(struct intel_uncore_box *box, struct p > .disable_event = nhmex_uncore_msr_disable_event, \ > .read_counter = uncore_msr_read_counter > > -static struct intel_uncore_ops nhmex_uncore_ops = { > +static const struct intel_uncore_ops nhmex_uncore_ops = { > NHMEX_UNCORE_OPS_COMMON_INIT(), > .enable_event = nhmex_uncore_msr_enable_event, > }; > @@ -413,7 +413,7 @@ static const struct attribute_group nhmex_uncore_bbox_format_group = { > .attrs = nhmex_uncore_bbox_formats_attr, > }; > > -static struct intel_uncore_ops nhmex_uncore_bbox_ops = { > +static const struct intel_uncore_ops nhmex_uncore_bbox_ops = { > NHMEX_UNCORE_OPS_COMMON_INIT(), > .enable_event = nhmex_bbox_msr_enable_event, > .hw_config = nhmex_bbox_hw_config, > @@ -490,7 +490,7 @@ static const struct attribute_group nhmex_uncore_sbox_format_group = { > .attrs = nhmex_uncore_sbox_formats_attr, > }; > > -static struct intel_uncore_ops nhmex_uncore_sbox_ops = { > +static const struct intel_uncore_ops nhmex_uncore_sbox_ops = { > NHMEX_UNCORE_OPS_COMMON_INIT(), > .enable_event = nhmex_sbox_msr_enable_event, > .hw_config = nhmex_sbox_hw_config, > @@ -916,7 +916,7 @@ static struct uncore_event_desc wsmex_uncore_mbox_events[] = { > { /* end: all zeroes */ }, > }; > > -static struct intel_uncore_ops nhmex_uncore_mbox_ops = { > +static const struct intel_uncore_ops nhmex_uncore_mbox_ops = { > NHMEX_UNCORE_OPS_COMMON_INIT(), > .enable_event = nhmex_mbox_msr_enable_event, > .hw_config = nhmex_mbox_hw_config, > @@ -1179,7 +1179,7 @@ static struct uncore_event_desc nhmex_uncore_rbox_events[] = { > { /* end: all zeroes */ }, > }; > > -static struct intel_uncore_ops nhmex_uncore_rbox_ops = { > +static const struct intel_uncore_ops nhmex_uncore_rbox_ops = { > NHMEX_UNCORE_OPS_COMMON_INIT(), > .enable_event = nhmex_rbox_msr_enable_event, > .hw_config = nhmex_rbox_hw_config, > diff --git a/arch/x86/events/intel/uncore_snb.c b/arch/x86/events/intel/uncore_snb.c > index 0f63706cdadf..5826cff568f4 100644 > --- a/arch/x86/events/intel/uncore_snb.c > +++ b/arch/x86/events/intel/uncore_snb.c > @@ -216,7 +216,7 @@ static const struct attribute_group snb_uncore_format_group = { > .attrs = snb_uncore_formats_attr, > }; > > -static struct intel_uncore_ops snb_uncore_msr_ops = { > +static const struct intel_uncore_ops snb_uncore_msr_ops = { > .init_box = snb_uncore_msr_init_box, > .enable_box = snb_uncore_msr_enable_box, > .exit_box = snb_uncore_msr_exit_box, > @@ -341,7 +341,7 @@ void skl_uncore_cpu_init(void) > snb_uncore_arb.ops = &skl_uncore_msr_ops; > } > > -static struct intel_uncore_ops icl_uncore_msr_ops = { > +static const struct intel_uncore_ops icl_uncore_msr_ops = { > .disable_event = snb_uncore_msr_disable_event, > .enable_event = snb_uncore_msr_enable_event, > .read_counter = uncore_msr_read_counter, > @@ -468,7 +468,7 @@ static void adl_uncore_msr_exit_box(struct intel_uncore_box *box) > wrmsrl(ADL_UNC_PERF_GLOBAL_CTL, 0); > } > > -static struct intel_uncore_ops adl_uncore_msr_ops = { > +static const struct intel_uncore_ops adl_uncore_msr_ops = { > .init_box = adl_uncore_msr_init_box, > .enable_box = adl_uncore_msr_enable_box, > .disable_box = adl_uncore_msr_disable_box, > @@ -799,7 +799,7 @@ static struct pmu snb_uncore_imc_pmu = { > .capabilities = PERF_PMU_CAP_NO_EXCLUDE, > }; > > -static struct intel_uncore_ops snb_uncore_imc_ops = { > +static const struct intel_uncore_ops snb_uncore_imc_ops = { > .init_box = snb_uncore_imc_init_box, > .exit_box = uncore_mmio_exit_box, > .enable_box = snb_uncore_imc_enable_box, > @@ -1267,7 +1267,7 @@ static struct uncore_event_desc nhm_uncore_events[] = { > { /* end: all zeroes */ }, > }; > > -static struct intel_uncore_ops nhm_uncore_msr_ops = { > +static const struct intel_uncore_ops nhm_uncore_msr_ops = { > .disable_box = nhm_uncore_msr_disable_box, > .enable_box = nhm_uncore_msr_enable_box, > .disable_event = snb_uncore_msr_disable_event, > @@ -1422,7 +1422,7 @@ static void tgl_uncore_imc_freerunning_init_box(struct intel_uncore_box *box) > pr_warn("perf uncore: Failed to ioremap for %s.\n", type->name); > } > > -static struct intel_uncore_ops tgl_uncore_imc_freerunning_ops = { > +static const struct intel_uncore_ops tgl_uncore_imc_freerunning_ops = { > .init_box = tgl_uncore_imc_freerunning_init_box, > .exit_box = uncore_mmio_exit_box, > .read_counter = uncore_mmio_read_counter, > diff --git a/arch/x86/events/intel/uncore_snbep.c b/arch/x86/events/intel/uncore_snbep.c > index bb6eb1e5569c..43eabe8d37dc 100644 > --- a/arch/x86/events/intel/uncore_snbep.c > +++ b/arch/x86/events/intel/uncore_snbep.c > @@ -775,7 +775,7 @@ static const struct attribute_group snbep_uncore_qpi_format_group = { > __SNBEP_UNCORE_MSR_OPS_COMMON_INIT(), \ > .init_box = snbep_uncore_msr_init_box \ > > -static struct intel_uncore_ops snbep_uncore_msr_ops = { > +static const struct intel_uncore_ops snbep_uncore_msr_ops = { > SNBEP_UNCORE_MSR_OPS_COMMON_INIT(), > }; > > @@ -786,7 +786,7 @@ static struct intel_uncore_ops snbep_uncore_msr_ops = { > .disable_event = snbep_uncore_pci_disable_event, \ > .read_counter = snbep_uncore_pci_read_counter > > -static struct intel_uncore_ops snbep_uncore_pci_ops = { > +static const struct intel_uncore_ops snbep_uncore_pci_ops = { > SNBEP_UNCORE_PCI_OPS_COMMON_INIT(), > .enable_event = snbep_uncore_pci_enable_event, \ > }; > @@ -1017,7 +1017,7 @@ static int snbep_cbox_hw_config(struct intel_uncore_box *box, struct perf_event > return 0; > } > > -static struct intel_uncore_ops snbep_uncore_cbox_ops = { > +static const struct intel_uncore_ops snbep_uncore_cbox_ops = { > SNBEP_UNCORE_MSR_OPS_COMMON_INIT(), > .hw_config = snbep_cbox_hw_config, > .get_constraint = snbep_cbox_get_constraint, > @@ -1127,7 +1127,7 @@ static int snbep_pcu_hw_config(struct intel_uncore_box *box, struct perf_event * > return 0; > } > > -static struct intel_uncore_ops snbep_uncore_pcu_ops = { > +static const struct intel_uncore_ops snbep_uncore_pcu_ops = { > SNBEP_UNCORE_MSR_OPS_COMMON_INIT(), > .hw_config = snbep_pcu_hw_config, > .get_constraint = snbep_pcu_get_constraint, > @@ -1211,7 +1211,7 @@ static void snbep_qpi_enable_event(struct intel_uncore_box *box, struct perf_eve > pci_write_config_dword(pdev, hwc->config_base, hwc->config | SNBEP_PMON_CTL_EN); > } > > -static struct intel_uncore_ops snbep_uncore_qpi_ops = { > +static const struct intel_uncore_ops snbep_uncore_qpi_ops = { > SNBEP_UNCORE_PCI_OPS_COMMON_INIT(), > .enable_event = snbep_qpi_enable_event, > .hw_config = snbep_qpi_hw_config, > @@ -1517,11 +1517,11 @@ static void ivbep_uncore_pci_init_box(struct intel_uncore_box *box) > .enable_event = snbep_uncore_msr_enable_event, \ > .read_counter = uncore_msr_read_counter > > -static struct intel_uncore_ops ivbep_uncore_msr_ops = { > +static const struct intel_uncore_ops ivbep_uncore_msr_ops = { > IVBEP_UNCORE_MSR_OPS_COMMON_INIT(), > }; > > -static struct intel_uncore_ops ivbep_uncore_pci_ops = { > +static const struct intel_uncore_ops ivbep_uncore_pci_ops = { > .init_box = ivbep_uncore_pci_init_box, > .disable_box = snbep_uncore_pci_disable_box, > .enable_box = snbep_uncore_pci_enable_box, > @@ -1757,7 +1757,7 @@ static void ivbep_cbox_enable_event(struct intel_uncore_box *box, struct perf_ev > wrmsrl(hwc->config_base, hwc->config | SNBEP_PMON_CTL_EN); > } > > -static struct intel_uncore_ops ivbep_uncore_cbox_ops = { > +static const struct intel_uncore_ops ivbep_uncore_cbox_ops = { > .init_box = ivbep_uncore_msr_init_box, > .disable_box = snbep_uncore_msr_disable_box, > .enable_box = snbep_uncore_msr_enable_box, > @@ -1785,7 +1785,7 @@ static struct intel_uncore_type ivbep_uncore_cbox = { > .format_group = &ivbep_uncore_cbox_format_group, > }; > > -static struct intel_uncore_ops ivbep_uncore_pcu_ops = { > +static const struct intel_uncore_ops ivbep_uncore_pcu_ops = { > IVBEP_UNCORE_MSR_OPS_COMMON_INIT(), > .hw_config = snbep_pcu_hw_config, > .get_constraint = snbep_pcu_get_constraint, > @@ -1873,7 +1873,7 @@ static u64 ivbep_uncore_irp_read_counter(struct intel_uncore_box *box, struct pe > return count; > } > > -static struct intel_uncore_ops ivbep_uncore_irp_ops = { > +static const struct intel_uncore_ops ivbep_uncore_irp_ops = { > .init_box = ivbep_uncore_pci_init_box, > .disable_box = snbep_uncore_pci_disable_box, > .enable_box = snbep_uncore_pci_enable_box, > @@ -1893,7 +1893,7 @@ static struct intel_uncore_type ivbep_uncore_irp = { > .format_group = &ivbep_uncore_format_group, > }; > > -static struct intel_uncore_ops ivbep_uncore_qpi_ops = { > +static const struct intel_uncore_ops ivbep_uncore_qpi_ops = { > .init_box = ivbep_uncore_pci_init_box, > .disable_box = snbep_uncore_pci_disable_box, > .enable_box = snbep_uncore_pci_enable_box, > @@ -2178,7 +2178,7 @@ static int knl_cha_hw_config(struct intel_uncore_box *box, > static void hswep_cbox_enable_event(struct intel_uncore_box *box, > struct perf_event *event); > > -static struct intel_uncore_ops knl_uncore_cha_ops = { > +static const struct intel_uncore_ops knl_uncore_cha_ops = { > .init_box = snbep_uncore_msr_init_box, > .disable_box = snbep_uncore_msr_disable_box, > .enable_box = snbep_uncore_msr_enable_box, > @@ -2272,7 +2272,7 @@ static void knl_uncore_imc_enable_event(struct intel_uncore_box *box, > hwc->config | SNBEP_PMON_CTL_EN); > } > > -static struct intel_uncore_ops knl_uncore_imc_ops = { > +static const struct intel_uncore_ops knl_uncore_imc_ops = { > .init_box = snbep_uncore_pci_init_box, > .disable_box = snbep_uncore_pci_disable_box, > .enable_box = knl_uncore_imc_enable_box, > @@ -2581,7 +2581,7 @@ static int hswep_ubox_hw_config(struct intel_uncore_box *box, struct perf_event > return 0; > } > > -static struct intel_uncore_ops hswep_uncore_ubox_ops = { > +static const struct intel_uncore_ops hswep_uncore_ubox_ops = { > SNBEP_UNCORE_MSR_OPS_COMMON_INIT(), > .hw_config = hswep_ubox_hw_config, > .get_constraint = uncore_get_constraint, > @@ -2741,7 +2741,7 @@ static void hswep_cbox_enable_event(struct intel_uncore_box *box, > wrmsrl(hwc->config_base, hwc->config | SNBEP_PMON_CTL_EN); > } > > -static struct intel_uncore_ops hswep_uncore_cbox_ops = { > +static const struct intel_uncore_ops hswep_uncore_cbox_ops = { > .init_box = snbep_uncore_msr_init_box, > .disable_box = snbep_uncore_msr_disable_box, > .enable_box = snbep_uncore_msr_enable_box, > @@ -2788,7 +2788,7 @@ static void hswep_uncore_sbox_msr_init_box(struct intel_uncore_box *box) > } > } > > -static struct intel_uncore_ops hswep_uncore_sbox_msr_ops = { > +static const struct intel_uncore_ops hswep_uncore_sbox_msr_ops = { > __SNBEP_UNCORE_MSR_OPS_COMMON_INIT(), > .init_box = hswep_uncore_sbox_msr_init_box > }; > @@ -2836,7 +2836,7 @@ static int hswep_pcu_hw_config(struct intel_uncore_box *box, struct perf_event * > return 0; > } > > -static struct intel_uncore_ops hswep_uncore_pcu_ops = { > +static const struct intel_uncore_ops hswep_uncore_pcu_ops = { > SNBEP_UNCORE_MSR_OPS_COMMON_INIT(), > .hw_config = hswep_pcu_hw_config, > .get_constraint = snbep_pcu_get_constraint, > @@ -2941,7 +2941,7 @@ static u64 hswep_uncore_irp_read_counter(struct intel_uncore_box *box, struct pe > return count; > } > > -static struct intel_uncore_ops hswep_uncore_irp_ops = { > +static const struct intel_uncore_ops hswep_uncore_irp_ops = { > .init_box = snbep_uncore_pci_init_box, > .disable_box = snbep_uncore_pci_disable_box, > .enable_box = snbep_uncore_pci_enable_box, > @@ -3611,7 +3611,7 @@ static int skx_cha_hw_config(struct intel_uncore_box *box, struct perf_event *ev > return 0; > } > > -static struct intel_uncore_ops skx_uncore_chabox_ops = { > +static const struct intel_uncore_ops skx_uncore_chabox_ops = { > /* There is no frz_en for chabox ctl */ > .init_box = ivbep_uncore_msr_init_box, > .disable_box = snbep_uncore_msr_disable_box, > @@ -3673,7 +3673,7 @@ static void skx_iio_enable_event(struct intel_uncore_box *box, > wrmsrl(hwc->config_base, hwc->config | SNBEP_PMON_CTL_EN); > } > > -static struct intel_uncore_ops skx_uncore_iio_ops = { > +static const struct intel_uncore_ops skx_uncore_iio_ops = { > .init_box = ivbep_uncore_msr_init_box, > .disable_box = snbep_uncore_msr_disable_box, > .enable_box = snbep_uncore_msr_enable_box, > @@ -3931,7 +3931,7 @@ static struct uncore_event_desc skx_uncore_iio_freerunning_events[] = { > { /* end: all zeroes */ }, > }; > > -static struct intel_uncore_ops skx_uncore_iio_freerunning_ops = { > +static const struct intel_uncore_ops skx_uncore_iio_freerunning_ops = { > .read_counter = uncore_msr_read_counter, > .hw_config = uncore_freerunning_hw_config, > }; > @@ -4006,7 +4006,7 @@ static struct attribute_group skx_uncore_pcu_format_group = { > .attrs = skx_uncore_pcu_formats_attr, > }; > > -static struct intel_uncore_ops skx_uncore_pcu_ops = { > +static const struct intel_uncore_ops skx_uncore_pcu_ops = { > IVBEP_UNCORE_MSR_OPS_COMMON_INIT(), > .hw_config = hswep_pcu_hw_config, > .get_constraint = snbep_pcu_get_constraint, > @@ -4105,7 +4105,7 @@ static void skx_upi_uncore_pci_init_box(struct intel_uncore_box *box) > pci_write_config_dword(pdev, SKX_UPI_PCI_PMON_BOX_CTL, IVBEP_PMON_BOX_CTL_INT); > } > > -static struct intel_uncore_ops skx_upi_uncore_pci_ops = { > +static const struct intel_uncore_ops skx_upi_uncore_pci_ops = { > .init_box = skx_upi_uncore_pci_init_box, > .disable_box = snbep_uncore_pci_disable_box, > .enable_box = snbep_uncore_pci_enable_box, > @@ -4136,7 +4136,7 @@ static void skx_m2m_uncore_pci_init_box(struct intel_uncore_box *box) > pci_write_config_dword(pdev, SKX_M2M_PCI_PMON_BOX_CTL, IVBEP_PMON_BOX_CTL_INT); > } > > -static struct intel_uncore_ops skx_m2m_uncore_pci_ops = { > +static const struct intel_uncore_ops skx_m2m_uncore_pci_ops = { > .init_box = skx_m2m_uncore_pci_init_box, > .disable_box = snbep_uncore_pci_disable_box, > .enable_box = snbep_uncore_pci_enable_box, > @@ -4373,7 +4373,7 @@ static void snr_cha_enable_event(struct intel_uncore_box *box, > wrmsrl(hwc->config_base, hwc->config | SNBEP_PMON_CTL_EN); > } > > -static struct intel_uncore_ops snr_uncore_chabox_ops = { > +static const struct intel_uncore_ops snr_uncore_chabox_ops = { > .init_box = ivbep_uncore_msr_init_box, > .disable_box = snbep_uncore_msr_disable_box, > .enable_box = snbep_uncore_msr_enable_box, > @@ -4560,7 +4560,7 @@ static int snr_pcu_hw_config(struct intel_uncore_box *box, struct perf_event *ev > return 0; > } > > -static struct intel_uncore_ops snr_uncore_pcu_ops = { > +static const struct intel_uncore_ops snr_uncore_pcu_ops = { > IVBEP_UNCORE_MSR_OPS_COMMON_INIT(), > .hw_config = snr_pcu_hw_config, > .get_constraint = snbep_pcu_get_constraint, > @@ -4660,7 +4660,7 @@ static void snr_m2m_uncore_pci_init_box(struct intel_uncore_box *box) > pci_write_config_dword(pdev, box_ctl, IVBEP_PMON_BOX_CTL_INT); > } > > -static struct intel_uncore_ops snr_m2m_uncore_pci_ops = { > +static const struct intel_uncore_ops snr_m2m_uncore_pci_ops = { > .init_box = snr_m2m_uncore_pci_init_box, > .disable_box = snbep_uncore_pci_disable_box, > .enable_box = snbep_uncore_pci_enable_box, > @@ -4706,7 +4706,7 @@ static void snr_uncore_pci_enable_event(struct intel_uncore_box *box, struct per > pci_write_config_dword(pdev, hwc->config_base + 4, (u32)(hwc->config >> 32)); > } > > -static struct intel_uncore_ops snr_pcie3_uncore_pci_ops = { > +static const struct intel_uncore_ops snr_pcie3_uncore_pci_ops = { > .init_box = snr_m2m_uncore_pci_init_box, > .disable_box = snbep_uncore_pci_disable_box, > .enable_box = snbep_uncore_pci_enable_box, > @@ -4884,7 +4884,7 @@ static void snr_uncore_mmio_disable_event(struct intel_uncore_box *box, > writel(hwc->config, box->io_addr + hwc->config_base); > } > > -static struct intel_uncore_ops snr_uncore_mmio_ops = { > +static const struct intel_uncore_ops snr_uncore_mmio_ops = { > .init_box = snr_uncore_mmio_init_box, > .exit_box = uncore_mmio_exit_box, > .disable_box = snr_uncore_mmio_disable_box, > @@ -4948,7 +4948,7 @@ static struct uncore_event_desc snr_uncore_imc_freerunning_events[] = { > { /* end: all zeroes */ }, > }; > > -static struct intel_uncore_ops snr_uncore_imc_freerunning_ops = { > +static const struct intel_uncore_ops snr_uncore_imc_freerunning_ops = { > .init_box = snr_uncore_mmio_init_box, > .exit_box = uncore_mmio_exit_box, > .read_counter = uncore_mmio_read_counter, > @@ -5005,7 +5005,7 @@ static int icx_cha_hw_config(struct intel_uncore_box *box, struct perf_event *ev > return 0; > } > > -static struct intel_uncore_ops icx_uncore_chabox_ops = { > +static const struct intel_uncore_ops icx_uncore_chabox_ops = { > .init_box = ivbep_uncore_msr_init_box, > .disable_box = snbep_uncore_msr_disable_box, > .enable_box = snbep_uncore_msr_enable_box, > @@ -5406,7 +5406,7 @@ static void icx_uncore_imc_init_box(struct intel_uncore_box *box) > __snr_uncore_mmio_init_box(box, box_ctl, mem_offset); > } > > -static struct intel_uncore_ops icx_uncore_mmio_ops = { > +static const struct intel_uncore_ops icx_uncore_mmio_ops = { > .init_box = icx_uncore_imc_init_box, > .exit_box = uncore_mmio_exit_box, > .disable_box = snr_uncore_mmio_disable_box, > @@ -5476,7 +5476,7 @@ static void icx_uncore_imc_freerunning_init_box(struct intel_uncore_box *box) > __snr_uncore_mmio_init_box(box, uncore_mmio_box_ctl(box), mem_offset); > } > > -static struct intel_uncore_ops icx_uncore_imc_freerunning_ops = { > +static const struct intel_uncore_ops icx_uncore_imc_freerunning_ops = { > .init_box = icx_uncore_imc_freerunning_init_box, > .exit_box = uncore_mmio_exit_box, > .read_counter = uncore_mmio_read_counter, >