From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA1C9C433EF for ; Wed, 22 Sep 2021 22:59:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8993B61153 for ; Wed, 22 Sep 2021 22:59:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238366AbhIVXA5 (ORCPT ); Wed, 22 Sep 2021 19:00:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34484 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238293AbhIVXA4 (ORCPT ); Wed, 22 Sep 2021 19:00:56 -0400 Received: from mail-io1-xd35.google.com (mail-io1-xd35.google.com [IPv6:2607:f8b0:4864:20::d35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 911A0C061574 for ; Wed, 22 Sep 2021 15:59:25 -0700 (PDT) Received: by mail-io1-xd35.google.com with SMTP id q205so5629086iod.8 for ; Wed, 22 Sep 2021 15:59:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1pqGlaeTi7J15oAmFBMcDMPPmFmeEf7zfAbebDrPl/s=; b=MRYTHsccewbb3d4zqHwXXdEQ9gJeP/w9TbjygW246JnXhIu3haJmwhHY36GaMlXHun w+OudQ6FNF4FC4anwDSDdDnnIG95TlRU/UafK4AuzzgoAZm0JQwQB70WnFIAP2nxQ5ZZ 4SgllZda6UofFCsikq/3FQ+xgwSoe99QI+VOqKpVNLjCN8nhJSR4qtwZfTaFnm474HAj JGeHy7OsTk3fMPGgskcwDehPbgh7g75M92SHIN92vhxQ3PMyPBehdHbwLHe/bryUEwPG UpCviIpJAWtXt8Q5s77bUvnGP9XoJcDJZOQNeaL6l9jTeePLYvIMdxkf6DSejEwYUeOP 37Zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1pqGlaeTi7J15oAmFBMcDMPPmFmeEf7zfAbebDrPl/s=; b=fBXJN1JEoeD+D7MbY3mIV0a0ic5sedl+uIwcJ5dC/pbZGR/vLHHuZFcZU+CKwkT5Ai NWANYT6uMRIKexEiQpV1+q56OxNrxe2nvVEcVNzijBkj8EpApakyR0Et4qROEfdI/qeq 00E9kKvufq+xZmouKC3kQO9v50sE45zFgv5OZvPe8ZBu5vbwJ0x6loJ5nJ2iXtmMRXQh ikKyq+FLhD1wOeucpmdb8vQIWlxul3K9pw/Fj7d6kIpcEP8uzld56bouJKstmHgGtCys rc9RjboJN768F0S5LRMJsUWfAMOXZiCzdk0M41EqpjlozyqgJ+B8EHEwCZUyQo5+22Q+ xyZQ== X-Gm-Message-State: AOAM530QXG1fpfaMloSNziAZQkEBUr6ypFoDNFWhjftuThT2o+1h9eGF jOIIqnX5d/U2OvNW26fmRJD3/sdD15oRXshO3eFa6A== X-Google-Smtp-Source: ABdhPJzyjNZvscMgFOYtdkguz4v/LcpUwFymfOfQDg9/qcs0gFxDMyCitkVXlLtetOMwLNSMbaDhrNj8WLIkU0uIrjA= X-Received: by 2002:a05:6602:3403:: with SMTP id n3mr1236381ioz.35.1632351564722; Wed, 22 Sep 2021 15:59:24 -0700 (PDT) MIME-Version: 1.0 References: <20210921181349.199780-1-irogers@google.com> In-Reply-To: From: Ian Rogers Date: Wed, 22 Sep 2021 15:59:11 -0700 Message-ID: Subject: Re: [PATCH v2] perf evlist: Remove group option. To: Jiri Olsa Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Namhyung Kim , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, eranian@google.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org On Wed, Sep 22, 2021 at 2:17 PM Jiri Olsa wrote: > > On Tue, Sep 21, 2021 at 11:13:49AM -0700, Ian Rogers wrote: > > SNIP > > > diff --git a/tools/perf/util/python.c b/tools/perf/util/python.c > > index 8feef3a05af7..9cd79513eebb 100644 > > --- a/tools/perf/util/python.c > > +++ b/tools/perf/util/python.c > > @@ -1109,14 +1109,6 @@ static PyObject *pyrf_evlist__open(struct pyrf_evlist *pevlist, > > PyObject *args, PyObject *kwargs) > > { > > struct evlist *evlist = &pevlist->evlist; > > - int group = 0; > > - static char *kwlist[] = { "group", NULL }; > > - > > - if (!PyArg_ParseTupleAndKeywords(args, kwargs, "|OOii", kwlist, &group)) > > - return NULL; > > - > > - if (group) > > - evlist__set_leader(evlist); > > > > if (evlist__open(evlist) < 0) { > > PyErr_SetFromErrno(PyExc_OSError); > > diff --git a/tools/perf/util/record.c b/tools/perf/util/record.c > > index bff669b615ee..9e694db7c7ee 100644 > > --- a/tools/perf/util/record.c > > +++ b/tools/perf/util/record.c > > @@ -99,13 +99,6 @@ void evlist__config(struct evlist *evlist, struct record_opts *opts, struct call > > bool use_comm_exec; > > bool sample_id = opts->sample_id; > > > > - /* > > - * Set the evsel leader links before we configure attributes, > > - * since some might depend on this info. > > - */ > > - if (opts->group) > > - evlist__set_leader(evlist); > > - > > I don't mind erasing that, but just curious if you're going > to add something which would clash with this? it does not > look too complex for the code.. but still, let's remove it > if it's in 'legacy mode' for this long ;-) I've nothing conflicting but I came across old tutorials describing it and I suspect usage of it is likely broken - in particular mixing --group with -e {}. Thanks, Ian > thanks, > jirka > > > > if (evlist->core.cpus->map[0] < 0) > > opts->no_inherit = true; > > > > diff --git a/tools/perf/util/record.h b/tools/perf/util/record.h > > index 68f471d9a88b..d71dee9ce41c 100644 > > --- a/tools/perf/util/record.h > > +++ b/tools/perf/util/record.h > > @@ -13,7 +13,6 @@ struct option; > > > > struct record_opts { > > struct target target; > > - bool group; > > bool inherit_stat; > > bool no_buffering; > > bool no_inherit; > > -- > > 2.33.0.464.g1972c5931b-goog > > >