From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AE36C48BE5 for ; Mon, 21 Jun 2021 21:31:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E5E6161245 for ; Mon, 21 Jun 2021 21:31:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231218AbhFUVdU (ORCPT ); Mon, 21 Jun 2021 17:33:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41196 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230052AbhFUVdU (ORCPT ); Mon, 21 Jun 2021 17:33:20 -0400 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A02D9C06175F for ; Mon, 21 Jun 2021 14:31:05 -0700 (PDT) Received: by mail-wr1-x434.google.com with SMTP id y7so21134656wrh.7 for ; Mon, 21 Jun 2021 14:31:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=THl/cfEqtiF8bpjYHQsI8F0jcqmB+ceOTFq/vSn409U=; b=JIArUMB/41VU5fe54U9ul6f6d/bvkUmB5dvPIC/oBkwF/qJJ7jLjsshY52MmMmV0cP 4hQYxdfx9H5t2clz8/Rpq+p3koezpWk00PirVK7oKeWeOwjVxGwzUZAzme0CxKolMemo Qz9Qo9QRjMy1cCLjYn2z54HkZoHe2BuN+/RbjXCkrIXVoIEpHj/kvcTp1D0OJN/5UZgi NbyR+NPsy13zY/ghu94jxECNDtjP7iFI6z8f6ZY7uGqafux3cXvggShlMh2H/7Fw9eHS TfZynOeOxukgAfItfX6V7Guj2xRsIRRwuO/aJfQqOj0r8zQMwfDFFYHWKuM+TGGFlqOj fxUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=THl/cfEqtiF8bpjYHQsI8F0jcqmB+ceOTFq/vSn409U=; b=knAFGTIPb7okeK263n4ujYibBGr5lTyQ2FOGU9mmamAjPu882q6i9at0wJE/VgEuQT 1kU2EMMX/yqJMo1h9Xo5PNdimxmlm/k0ZmlsrglAqAInvF3H/8BGK/fHQcqysDHbQVtx fIgj8rTw0DU74fjuGAWSuP3s6Nnyj4jWc6UW3B6mTATQrEwxyY+7JSNBANIwoOsMwHHp eAoHBrAwbZiW4vWEudt5IemfH6aNi9XCP4JwulR8nNkL5TNFeR2CzxBKGlVDz5KddbnF KBh5q1ff5j7enSsxlFXgVrLoP3lAufXI5kk1so8NFs4G0Fi3wxP2NTIzdctw/SoAEWsI CVjQ== X-Gm-Message-State: AOAM530TX3kQ277Xoqo9eCs53oSWxk2IIDy2ZcvdjIxqsQXeR0DWGc5C 549HNPGNt/dVBeMAXB+5NHVHBa8SvVL66X1N2BN3Wtzf6AQGdb0Y X-Google-Smtp-Source: ABdhPJzZa6mY8h9+/DaGpxq4qInMWB2iX+FC8oHrztFc+KztQPVgXbt+vWv67DZfCPEWQTneivyVYbeiw9eU7Vi68dw= X-Received: by 2002:adf:f30d:: with SMTP id i13mr536208wro.119.1624311064037; Mon, 21 Jun 2021 14:31:04 -0700 (PDT) MIME-Version: 1.0 References: <20210617184216.2075588-1-irogers@google.com> <20210621075525.128b476f@canb.auug.org.au> In-Reply-To: <20210621075525.128b476f@canb.auug.org.au> From: Ian Rogers Date: Mon, 21 Jun 2021 14:30:52 -0700 Message-ID: Subject: Re: [PATCH 1/4] perf test: Fix non-bash issue with stat bpf counters To: Stephen Rothwell Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Song Liu , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org On Sun, Jun 20, 2021 at 2:55 PM Stephen Rothwell wrote: > > Hi Ian, > > On Thu, 17 Jun 2021 11:42:13 -0700 Ian Rogers wrote: > > > > $(( .. )) is a bash feature but the test's interpreter is !/bin/sh, > > switch the code to use expr. > > The $(( .. )) syntax is specified in POSIX (see > https://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_06_04), > so unless this caused an actual problem, this change is unnecessary. Agreed. The issue I was seeing was: ./tests/shell/stat_bpf_counters.sh: line 14: -- > Cheers, > Stephen Rothwell