From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62407C4332E for ; Thu, 18 Feb 2021 19:01:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 28D6C64EB9 for ; Thu, 18 Feb 2021 19:01:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233441AbhBRTAt (ORCPT ); Thu, 18 Feb 2021 14:00:49 -0500 Received: from mail.kernel.org ([198.145.29.99]:42538 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230090AbhBRRUo (ORCPT ); Thu, 18 Feb 2021 12:20:44 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1BB4B64E3E; Thu, 18 Feb 2021 17:19:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1613668773; bh=XCEFaYrDnXCcZnBEwDbDiJWd84B75RfzkHoor2ScZMA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fZdyrfwV4jTsVp+Qe505TOvi4QLDEBHQK1QZ/RKJtn81Y6iSuoGHid2A35PzGSTt4 2XeTntzkRZ5vpAlb7EF+JJA9nFIMLje5R2Hl302DBQJgV3fTGsQE6k+sqU9tgd4o2O Pa/PZE1yIc+bbQuErCK2IEvw+4CBFlcHShfqnkgvHO0PHHLjDf4zcOOnyUipS2ne1S JcQCVSzJCO6unscT3/HtNFAF6Sim6EhhjBealzw53I+t3tG0oHhqHzNNYjfDuHnchh Mn5iHBzfF63EMPZXcisRnO6N0HwbWDpxdtQc1BohVZ/a6Xw7U3U8K0BLR5aYt0UBoV +Yy1UzxAZ+U/g== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id EA06540CD9; Thu, 18 Feb 2021 14:19:30 -0300 (-03) Date: Thu, 18 Feb 2021 14:19:30 -0300 From: Arnaldo Carvalho de Melo To: Dave Rigby Cc: linux-perf-users@vger.kernel.org, Jan Kratochvil , Jiri Olsa Subject: Re: [PATCH] perf unwind: Set userdata for all __report_module paths Message-ID: References: <20210218165654.36604-1-d.rigby@me.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Em Thu, Feb 18, 2021 at 04:58:44PM +0000, Dave Rigby escreveu: > I missed adding a link to the bugzilla issue: https://bugzilla.kernel.org/show_bug.cgi?id=211801 > > Note sure what the recommended way of tagging that in the patch is… You also forgot to add your: Signed-off-by: Dave Rigby I'm adding it, ok? Please take a look at Documentation/process/submitting-patches.rst, this part: ---------------------------------------------------------------------------- Developer's Certificate of Origin 1.1 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. then you just add a line saying:: Signed-off-by: Random J Developer using your real name (sorry, no pseudonyms or anonymous contributions.) This will be done for you automatically if you use ``git commit -s``. Reverts should also include "Signed-off-by". ``git revert -s`` does that for you. Some people also put extra tags at the end. They'll just be ignored for now, but you can do this to mark internal company procedures or just point out some special detail about the sign-off. Any further SoBs (Signed-off-by:'s) following the author's SoB are from people handling and transporting the patch, but were not involved in its development. SoB chains should reflect the **real** route a patch took as it was propagated to the maintainers and ultimately to Linus, with the first SoB entry signalling primary authorship of a single author. ---------------------------------------------------------------------------- > > DaveR > > > On 18 Feb 2021, at 16:56, d.rigby@me.com wrote: > > > > From: Dave Rigby > > > > When locating the dwarf module for a given address, __find_debuginfo() > > requires a 'struct dso' passed via the userdata argument. > > > > However, this field is only set in __report_module() if the module is > > found in via dwfl_addrmodule(), not if it is found later via dwfl_report_elf(). > > > > Set userdata irrespective of how the dwarf module was found, as long > > as we found a module. > > > > Fixes: bf53fc6b5f41 ("perf unwind: Fix separate debug info files when using elfutils' libdw's unwinder") > > Cc: linux-perf-users@vger.kernel.org > > Cc: Arnaldo Carvalho de Melo > > Cc: Jan Kratochvil > > Cc: Jiri Olsa > > --- > > tools/perf/util/unwind-libdw.c | 11 ++++++++--- > > 1 file changed, 8 insertions(+), 3 deletions(-) > > > > diff --git a/tools/perf/util/unwind-libdw.c b/tools/perf/util/unwind-libdw.c > > index 0ada907..a74b517 100644 > > --- a/tools/perf/util/unwind-libdw.c > > +++ b/tools/perf/util/unwind-libdw.c > > @@ -60,10 +60,8 @@ static int __report_module(struct addr_location *al, u64 ip, > > mod = dwfl_addrmodule(ui->dwfl, ip); > > if (mod) { > > Dwarf_Addr s; > > - void **userdatap; > > > > - dwfl_module_info(mod, &userdatap, &s, NULL, NULL, NULL, NULL, NULL); > > - *userdatap = dso; > > + dwfl_module_info(mod, NULL, &s, NULL, NULL, NULL, NULL, NULL); > > if (s != al->map->start - al->map->pgoff) > > mod = 0; > > } > > @@ -79,6 +77,13 @@ static int __report_module(struct addr_location *al, u64 ip, > > al->map->start - al->map->pgoff, false); > > } > > > > + if (mod) { > > + void **userdatap; > > + > > + dwfl_module_info(mod, &userdatap, NULL, NULL, NULL, NULL, NULL, NULL); > > + *userdatap = dso; > > + } > > + > > return mod && dwfl_addrmodule(ui->dwfl, ip) == mod ? 0 : -1; > > } > > > > -- > > 1.8.3.1 > -- - Arnaldo