From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: "Martin Liška" <mliska@suse.cz>
Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org
Subject: Re: [PATCH] perf annotate: add --demangle and --demangle-kernel
Date: Tue, 30 Mar 2021 12:42:44 -0300 [thread overview]
Message-ID: <YGNG9PLKEniErXwy@kernel.org> (raw)
In-Reply-To: <71d26f15-f0e8-adca-1e7c-46effcba913a@suse.cz>
Em Tue, Mar 30, 2021 at 09:41:33AM +0200, Martin Liška escreveu:
> PING^2
>
> On 3/7/21 8:23 PM, Martin Liška wrote:
> > Hello.
> >
> > May I please remind this patch. Apparently, you applied the perf-config
> > counterpart of the patch as 804fd30c6bd9aec7859a0503581312834fb197f1
> > (in tmp.perf/core branch), but we miss setting the same via options.
> >
> > Thank you,
> > Martin
> >
> > On 2/26/21 11:01 AM, Martin Liška wrote:
> > > On 2/23/21 8:49 PM, Arnaldo Carvalho de Melo wrote:
> > > > Em Mon, Feb 22, 2021 at 09:29:22AM +0100, Martin Liška escreveu:
> > > > > Perf annotate supports --symbol but it's impossible to filter
> > > > > a C++ symbol. With --no-demangle one can filter easily by
> > > > > mangled function name.
> > > > >
> > > > > Signed-off-by: Martin Liška <mliska@suse.cz>
> > > > > ---
> > > > > tools/perf/Documentation/perf-annotate.txt | 7 +++++++
> > > > > tools/perf/builtin-annotate.c | 4 ++++
> > > > > 2 files changed, 11 insertions(+)
> > > > >
> > > > > diff --git a/tools/perf/Documentation/perf-annotate.txt b/tools/perf/Documentation/perf-annotate.txt
> > > > > index 1b5042f134a8..80c1be5d566c 100644
> > > > > --- a/tools/perf/Documentation/perf-annotate.txt
> > > > > +++ b/tools/perf/Documentation/perf-annotate.txt
> > > > > @@ -124,6 +124,13 @@ OPTIONS
> > > > > --group::
> > > > > Show event group information together
> > > > > +--demangle::
> > > > > + Demangle symbol names to human readable form. It's enabled by default,
> > > > > + disable with --no-demangle.
> > > > > +
> > > > > +--demangle-kernel::
> > > > > + Demangle kernel symbol names to human readable form (for C++ kernels).
> > > > > +
> > > > > --percent-type::
> > > > > Set annotation percent type from following choices:
> > > > > global-period, local-period, global-hits, local-hits
> > > > > diff --git a/tools/perf/builtin-annotate.c b/tools/perf/builtin-annotate.c
> > > > > index a23ba6bb99b6..ef70a17b9b5b 100644
> > > > > --- a/tools/perf/builtin-annotate.c
> > > > > +++ b/tools/perf/builtin-annotate.c
> > > > > @@ -538,6 +538,10 @@ int cmd_annotate(int argc, const char **argv)
> > > > > "Strip first N entries of source file path name in programs (with --prefix)"),
> > > > > OPT_STRING(0, "objdump", &annotate.opts.objdump_path, "path",
> > > > > "objdump binary to use for disassembly and annotations"),
> > > > > + OPT_BOOLEAN(0, "demangle", &symbol_conf.demangle,
> > > > > + "Disable symbol demangling"),
> > > >
> > > > Nope, this _enables_ demangling, i.e.:
> > > >
> > > > perf annotate --demangle
> > >
> > > Oh, yeah, you are right.
> > >
> > > >
> > > > Asks for symbol demangling, while:
> > > >
> > > > perf annotate --no-demangle
> > > >
> > > > As you correctly wrote in your commit message and on the
> > > > --demangle-kernel case, enables demangling.
> > >
> > > Fixed that in V2.
Trying to find V2
- Arnaldo
next prev parent reply other threads:[~2021-03-30 15:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-22 8:29 [PATCH] perf annotate: add --demangle and --demangle-kernel Martin Liška
2021-02-23 19:49 ` Arnaldo Carvalho de Melo
2021-02-26 10:01 ` Martin Liška
2021-03-07 19:23 ` Martin Liška
2021-03-30 7:41 ` Martin Liška
2021-03-30 15:42 ` Arnaldo Carvalho de Melo [this message]
2021-03-30 18:19 ` Martin Liška
2021-03-30 18:23 ` Arnaldo Carvalho de Melo
2021-03-30 18:33 ` Martin Liška
2021-02-26 10:03 ` [PATCH] perf config: add annotate.demangle{,_kernel} Martin Liška
2021-02-26 10:08 ` Martin Liška
2021-03-06 13:22 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YGNG9PLKEniErXwy@kernel.org \
--to=acme@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mliska@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).