linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: "Justin M. Forbes" <jforbes@fedoraproject.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
	jmforbes@linuxtx.org
Subject: Re: [PATCH] Fix the perf trace link location
Date: Tue, 6 Jul 2021 16:08:00 -0300	[thread overview]
Message-ID: <YOSqEDU+MjOS29fd@kernel.org> (raw)
In-Reply-To: <20210706185952.116121-1-jforbes@fedoraproject.org>

Em Tue, Jul 06, 2021 at 01:59:51PM -0500, Justin M. Forbes escreveu:
> The install perf_dlfilter.h patch included what seems to be
> a typo in the Makefile.perf, which changed the location of the trace
> link from '$(DESTDIR_SQ)$(bindir_SQ)/trace' to
> '$(DESTDIR_SQ)$(dir_SQ)/trace' This reverts it back to the correct
> location.

Thanks, applied!

- Arnaldo
 
> Fixes: 0beb218315e06 ("perf build: Install perf_dlfilter.h")
> Signed-off-by: Justin M. Forbes <jforbes@fedoraproject.org>
> ---
>  tools/perf/Makefile.perf | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
> index c9e0de5b00c1..a1b9be78a1e0 100644
> --- a/tools/perf/Makefile.perf
> +++ b/tools/perf/Makefile.perf
> @@ -923,7 +923,7 @@ install-tools: all install-gtk
>  	$(call QUIET_INSTALL, binaries) \
>  		$(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(bindir_SQ)'; \
>  		$(INSTALL) $(OUTPUT)perf '$(DESTDIR_SQ)$(bindir_SQ)'; \
> -		$(LN) '$(DESTDIR_SQ)$(bindir_SQ)/perf' '$(DESTDIR_SQ)$(dir_SQ)/trace'; \
> +		$(LN) '$(DESTDIR_SQ)$(bindir_SQ)/perf' '$(DESTDIR_SQ)$(bindir_SQ)/trace'; \
>  		$(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(includedir_SQ)/perf'; \
>  		$(INSTALL) util/perf_dlfilter.h -t '$(DESTDIR_SQ)$(includedir_SQ)/perf'
>  ifndef NO_PERF_READ_VDSO32
> -- 
> 2.31.1
> 

-- 

- Arnaldo

      reply	other threads:[~2021-07-06 19:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-06 18:59 [PATCH] Fix the perf trace link location Justin M. Forbes
2021-07-06 19:08 ` Arnaldo Carvalho de Melo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YOSqEDU+MjOS29fd@kernel.org \
    --to=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=jforbes@fedoraproject.org \
    --cc=jmforbes@linuxtx.org \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).