From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Namhyung Kim <namhyung@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Michael Petlan <mpetlan@redhat.com>,
Ian Rogers <irogers@google.com>,
nakamura.shun@fujitsu.com, linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 7/7] libperf: Add tests for perf_evlist__set_leader function
Date: Fri, 9 Jul 2021 14:59:46 -0300 [thread overview]
Message-ID: <YOiOkgTnd8NC/k+P@kernel.org> (raw)
In-Reply-To: <20210706151704.73662-8-jolsa@kernel.org>
Em Tue, Jul 06, 2021 at 05:17:04PM +0200, Jiri Olsa escreveu:
> Adding test for newly added perf_evlist__set_leader function.
Thanks, applied.
- Arnaldo
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> ---
> tools/lib/perf/tests/test-evlist.c | 27 +++++++++++++++++++++------
> 1 file changed, 21 insertions(+), 6 deletions(-)
>
> diff --git a/tools/lib/perf/tests/test-evlist.c b/tools/lib/perf/tests/test-evlist.c
> index 7435529fb21c..c67c83399170 100644
> --- a/tools/lib/perf/tests/test-evlist.c
> +++ b/tools/lib/perf/tests/test-evlist.c
> @@ -19,6 +19,7 @@
> #include <internal/tests.h>
> #include <api/fs/fs.h>
> #include "tests.h"
> +#include <internal/evsel.h>
>
> static int libperf_print(enum libperf_print_level level,
> const char *fmt, va_list ap)
> @@ -30,7 +31,7 @@ static int test_stat_cpu(void)
> {
> struct perf_cpu_map *cpus;
> struct perf_evlist *evlist;
> - struct perf_evsel *evsel;
> + struct perf_evsel *evsel, *leader;
> struct perf_event_attr attr1 = {
> .type = PERF_TYPE_SOFTWARE,
> .config = PERF_COUNT_SW_CPU_CLOCK,
> @@ -47,7 +48,7 @@ static int test_stat_cpu(void)
> evlist = perf_evlist__new();
> __T("failed to create evlist", evlist);
>
> - evsel = perf_evsel__new(&attr1);
> + evsel = leader = perf_evsel__new(&attr1);
> __T("failed to create evsel1", evsel);
>
> perf_evlist__add(evlist, evsel);
> @@ -57,6 +58,10 @@ static int test_stat_cpu(void)
>
> perf_evlist__add(evlist, evsel);
>
> + perf_evlist__set_leader(evlist);
> + __T("failed to set leader", leader->leader == leader);
> + __T("failed to set leader", evsel->leader == leader);
> +
> perf_evlist__set_maps(evlist, cpus, NULL);
>
> err = perf_evlist__open(evlist);
> @@ -85,7 +90,7 @@ static int test_stat_thread(void)
> struct perf_counts_values counts = { .val = 0 };
> struct perf_thread_map *threads;
> struct perf_evlist *evlist;
> - struct perf_evsel *evsel;
> + struct perf_evsel *evsel, *leader;
> struct perf_event_attr attr1 = {
> .type = PERF_TYPE_SOFTWARE,
> .config = PERF_COUNT_SW_CPU_CLOCK,
> @@ -104,7 +109,7 @@ static int test_stat_thread(void)
> evlist = perf_evlist__new();
> __T("failed to create evlist", evlist);
>
> - evsel = perf_evsel__new(&attr1);
> + evsel = leader = perf_evsel__new(&attr1);
> __T("failed to create evsel1", evsel);
>
> perf_evlist__add(evlist, evsel);
> @@ -114,6 +119,10 @@ static int test_stat_thread(void)
>
> perf_evlist__add(evlist, evsel);
>
> + perf_evlist__set_leader(evlist);
> + __T("failed to set leader", leader->leader == leader);
> + __T("failed to set leader", evsel->leader == leader);
> +
> perf_evlist__set_maps(evlist, NULL, threads);
>
> err = perf_evlist__open(evlist);
> @@ -136,7 +145,7 @@ static int test_stat_thread_enable(void)
> struct perf_counts_values counts = { .val = 0 };
> struct perf_thread_map *threads;
> struct perf_evlist *evlist;
> - struct perf_evsel *evsel;
> + struct perf_evsel *evsel, *leader;
> struct perf_event_attr attr1 = {
> .type = PERF_TYPE_SOFTWARE,
> .config = PERF_COUNT_SW_CPU_CLOCK,
> @@ -157,7 +166,7 @@ static int test_stat_thread_enable(void)
> evlist = perf_evlist__new();
> __T("failed to create evlist", evlist);
>
> - evsel = perf_evsel__new(&attr1);
> + evsel = leader = perf_evsel__new(&attr1);
> __T("failed to create evsel1", evsel);
>
> perf_evlist__add(evlist, evsel);
> @@ -167,6 +176,10 @@ static int test_stat_thread_enable(void)
>
> perf_evlist__add(evlist, evsel);
>
> + perf_evlist__set_leader(evlist);
> + __T("failed to set leader", leader->leader == leader);
> + __T("failed to set leader", evsel->leader == leader);
> +
> perf_evlist__set_maps(evlist, NULL, threads);
>
> err = perf_evlist__open(evlist);
> @@ -254,6 +267,7 @@ static int test_mmap_thread(void)
>
> evsel = perf_evsel__new(&attr);
> __T("failed to create evsel1", evsel);
> + __T("failed to set leader", evsel->leader == evsel);
>
> perf_evlist__add(evlist, evsel);
>
> @@ -339,6 +353,7 @@ static int test_mmap_cpus(void)
>
> evsel = perf_evsel__new(&attr);
> __T("failed to create evsel1", evsel);
> + __T("failed to set leader", evsel->leader == evsel);
>
> perf_evlist__add(evlist, evsel);
>
> --
> 2.31.1
>
--
- Arnaldo
next prev parent reply other threads:[~2021-07-09 17:59 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-06 15:16 [RFCv2 0/7] libperf: Add leader/group info to perf_evsel Jiri Olsa
2021-07-06 15:16 ` [PATCH 1/7] libperf: Change tests to single static and shared binaries Jiri Olsa
2021-07-06 15:16 ` [PATCH 2/7] libperf: Move idx to perf_evsel::idx Jiri Olsa
2021-07-07 14:45 ` Arnaldo Carvalho de Melo
2021-07-07 18:17 ` Jiri Olsa
2021-07-07 18:36 ` Arnaldo Carvalho de Melo
2021-07-07 14:49 ` Arnaldo Carvalho de Melo
2021-07-07 17:48 ` Arnaldo Carvalho de Melo
2021-07-07 18:18 ` Jiri Olsa
2021-07-07 18:17 ` Jiri Olsa
2021-07-06 15:17 ` [PATCH 3/7] libperf: Move leader to perf_evsel::leader Jiri Olsa
2021-07-07 14:53 ` Arnaldo Carvalho de Melo
2021-07-07 18:14 ` Jiri Olsa
2021-07-07 18:34 ` Arnaldo Carvalho de Melo
2021-07-06 15:17 ` [PATCH 4/7] libperf: Move nr_groups to evlist::nr_groups Jiri Olsa
2021-07-06 15:17 ` [PATCH 5/7] libperf: Add perf_evlist__set_leader function Jiri Olsa
2021-07-06 15:17 ` [PATCH 6/7] libperF: Add group support to perf_evsel__open Jiri Olsa
2021-07-07 17:43 ` Arnaldo Carvalho de Melo
2021-07-07 18:15 ` Jiri Olsa
2021-07-09 17:57 ` [PATCH] libperf: Remove BUG_ON() from library code in get_group_fd(). was " Arnaldo Carvalho de Melo
2021-07-06 15:17 ` [PATCH 7/7] libperf: Add tests for perf_evlist__set_leader function Jiri Olsa
2021-07-09 17:59 ` Arnaldo Carvalho de Melo [this message]
2021-07-07 14:47 ` [RFCv2 0/7] libperf: Add leader/group info to perf_evsel Arnaldo Carvalho de Melo
2021-07-07 18:20 ` Jiri Olsa
2021-07-07 18:37 ` Arnaldo Carvalho de Melo
2021-07-09 8:32 ` nakamura.shun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YOiOkgTnd8NC/k+P@kernel.org \
--to=acme@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@kernel.org \
--cc=mpetlan@redhat.com \
--cc=nakamura.shun@fujitsu.com \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).