From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 839BBC4338F for ; Mon, 9 Aug 2021 12:05:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6657360F02 for ; Mon, 9 Aug 2021 12:05:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235321AbhHIMFY (ORCPT ); Mon, 9 Aug 2021 08:05:24 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:56754 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234519AbhHIMFY (ORCPT ); Mon, 9 Aug 2021 08:05:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628510703; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+z9CSxqzwcgihY+rR169k8okLByYqfQprIHpqjQt5hA=; b=Rw36Sb8MfdS2CJ9pmBoBM1jO9DpK/4Hf9yYj6WxsPoycZLebUTUV3Omz5FOhMR3f2YMgAE k8XG27KTZ0gmFCTdy7EpvxQEOdO8Z0q7brn6dzUBFX28d4ErBl90Z9BXq9DuxGguFP+ro5 obMlkUTAmn7WnYif6pg6HoTrV5BUzcc= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-90-XgiGx2ksPmWdHwKjU9tIJA-1; Mon, 09 Aug 2021 08:05:02 -0400 X-MC-Unique: XgiGx2ksPmWdHwKjU9tIJA-1 Received: by mail-ed1-f70.google.com with SMTP id y22-20020a0564023596b02903bd9452ad5cso8737972edc.20 for ; Mon, 09 Aug 2021 05:05:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+z9CSxqzwcgihY+rR169k8okLByYqfQprIHpqjQt5hA=; b=FY/U78hiYB05YR1KQHQYipaO+pFbmHBKWGpv3PH00z8+22jO3J/Gm6ixvBkndoLa3I uWaYMj743S4J/mWXajrUVy1NAiYyDuH0WPAbr11+F3QvpGG2aqVcOGoAJO51ho8528Kk ZXVX8fJPLWbkYwD/Zjh/uCNZkJsuTcGrNFwOYq50su+xrBwJZUByz7pQ2B4waSMf4wQx J8AXQ+WZ78s+7JwjV+FD9rUrWdVlwUUHLF2aOBpNZaJeg2W36p3fKiwfIa5+fDllcsfX LSf/WXqL5tyTwLibhYifgRziyUH7a0+a9cBP4G8Z8mP/qf/yCwhPhKithPs9KNOKGjEP xf2g== X-Gm-Message-State: AOAM5328mn3eJcwDyHO9ArdXEoBDM/1JuA047v2IYdedF7MD8Otp7Kqw BpzUxzewNY/AOCtcSKG0LClVrZu0/BxpDPMHBdaSsbNziePSLGN4g9CzZz/MOEAdcq9P4tnSFTu seiYa4UkeY7an5zoxLGYJDqeIiqxbHQ== X-Received: by 2002:a17:907:2b09:: with SMTP id gc9mr8203846ejc.49.1628510701322; Mon, 09 Aug 2021 05:05:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxnR/WopfgC7031GUaVJc9iF0eg3jJjWLQrhMBUBYQNg2Q8EedFbZgObWIB3eAqyltqsFMA4Q== X-Received: by 2002:a17:907:2b09:: with SMTP id gc9mr8203827ejc.49.1628510701150; Mon, 09 Aug 2021 05:05:01 -0700 (PDT) Received: from krava ([83.240.61.5]) by smtp.gmail.com with ESMTPSA id r27sm8039187edb.66.2021.08.09.05.05.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Aug 2021 05:05:00 -0700 (PDT) Date: Mon, 9 Aug 2021 14:04:59 +0200 From: Jiri Olsa To: Riccardo Mancini Cc: Arnaldo Carvalho de Melo , Ian Rogers , Namhyung Kim , Peter Zijlstra , Ingo Molnar , Mark Rutland , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Alexey Bayduraev Subject: Re: [RFC PATCH v2 06/10] perf workqueue: introduce workqueue struct Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org On Fri, Jul 30, 2021 at 05:34:13PM +0200, Riccardo Mancini wrote: SNIP > +static void worker_thread(int tidx, struct task_struct *task) > +{ > + > + pr_info("Hi from worker %d, executing task %p\n", tidx, task); > +} > + > +/** > + * attach_threadpool_to_workqueue - start @wq workers on @pool > + */ > +static int attach_threadpool_to_workqueue(struct workqueue_struct *wq, > + struct threadpool *pool) > +{ > + if (!threadpool__is_ready(pool)) { > + pr_debug2("workqueue: cannot attach to pool: pool is not ready\n"); > + return -WORKQUEUE_ERROR__NOTALLOWED; > + } > + > + wq->pool = pool; > + > + wq->pool_errno = threadpool__execute(pool, &wq->task); > + if (wq->pool_errno) > + return -WORKQUEUE_ERROR__POOLEXE; SNIP > + > +/** > + * create_workqueue - create a workqueue associated to @pool > + * > + * Only one workqueue can execute on a pool at a time. > + */ > +struct workqueue_struct *create_workqueue(struct threadpool *pool) > +{ > + int ret, err = 0; > + struct workqueue_struct *wq = malloc(sizeof(struct workqueue_struct)); > + > + if (!wq) { > + err = -ENOMEM; > + goto out_return; > + } > + > + ret = pthread_mutex_init(&wq->lock, NULL); > + if (ret) { > + err = -ret; > + goto out_free_wq; > + } > + > + ret = pthread_cond_init(&wq->idle_cond, NULL); > + if (ret) { > + err = -ret; > + goto out_destroy_mutex; > + } > + > + wq->pool = NULL; > + INIT_LIST_HEAD(&wq->busy_list); > + INIT_LIST_HEAD(&wq->idle_list); > + > + INIT_LIST_HEAD(&wq->pending); > + > + ret = pipe(wq->msg_pipe); > + if (ret) { > + err = -ENOMEM; > + goto out_destroy_cond; > + } > + > + wq->task.fn = worker_thread; > + > + ret = attach_threadpool_to_workqueue(wq, pool); > + if (ret) { > + err = ret; > + goto out_destroy_cond; > + } > + > + wq->status = WORKQUEUE_STATUS__READY; > + > + return wq; > + > +out_destroy_cond: > + pthread_cond_destroy(&wq->idle_cond); leaking wq->msg_pipe? thanks, jirka > +out_destroy_mutex: > + pthread_mutex_destroy(&wq->lock); > +out_free_wq: > + free(wq); > +out_return: > + return ERR_PTR(err); > +} > + SNIP