From: Jiri Olsa <jolsa@redhat.com>
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Namhyung Kim <namhyung@kernel.org>,
linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>,
Jin Yao <yao.jin@linux.intel.com>,
John Garry <john.garry@huawei.com>, Paul Clarke <pc@us.ibm.com>,
kajoljain <kjain@linux.ibm.com>,
linux-perf-users@vger.kernel.org,
Stephane Eranian <eranian@google.com>,
Sandeep Dasgupta <sdasgup@google.com>
Subject: Re: [PATCH v8 5/8] perf metric: Add utilities to work on ids map.
Date: Wed, 22 Sep 2021 22:58:33 +0200 [thread overview]
Message-ID: <YUuY+WhB3Y3VQm2w@krava> (raw)
In-Reply-To: <20210918063513.2356923-6-irogers@google.com>
SNIP
> diff --git a/tools/perf/util/expr.c b/tools/perf/util/expr.c
> index adf16bb7571a..34b51ca5e87f 100644
> --- a/tools/perf/util/expr.c
> +++ b/tools/perf/util/expr.c
> @@ -59,8 +59,48 @@ static bool key_equal(const void *key1, const void *key2,
> return !strcmp((const char *)key1, (const char *)key2);
> }
>
> -/* Caller must make sure id is allocated */
> -int expr__add_id(struct expr_parse_ctx *ctx, const char *id)
> +struct hashmap *ids__new(void)
> +{
> + return hashmap__new(key_hash, key_equal, NULL);
> +}
> +
> +void ids__free(struct hashmap *ids)
> +{
> + struct hashmap_entry *cur;
> + size_t bkt;
> +
> + if (ids == NULL)
> + return;
> +
> +#ifdef PARSER_DEBUG
> + fprintf(stderr, "freeing ids: ");
> + ids__print(ids);
> + fprintf(stderr, "\n");
> +#endif
hum, is this intended or forgotten debug leftover?
jirka
> +
> + hashmap__for_each_entry(ids, cur, bkt) {
> + free((char *)cur->key);
> + free(cur->value);
> + }
> +
> + hashmap__free(ids);
> +}
> +
> +void ids__print(struct hashmap *ids)
SNIP
next prev parent reply other threads:[~2021-09-22 20:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-18 6:35 [PATCH v8 0/8] Don't compute events that won't be used in a metric Ian Rogers
2021-09-18 6:35 ` [PATCH v8 1/8] perf metric: Restructure struct expr_parse_ctx Ian Rogers
2021-09-22 20:59 ` Jiri Olsa
2021-09-23 0:21 ` Ian Rogers
2021-09-18 6:35 ` [PATCH v8 2/8] perf metric: Use NAN for missing event IDs Ian Rogers
2021-09-18 6:35 ` [PATCH v8 3/8] perf expr: Modify code layout Ian Rogers
2021-09-22 20:58 ` Jiri Olsa
2021-09-18 6:35 ` [PATCH v8 4/8] perf metric: Rename expr__find_other Ian Rogers
2021-09-18 6:35 ` [PATCH v8 5/8] perf metric: Add utilities to work on ids map Ian Rogers
2021-09-22 20:58 ` Jiri Olsa [this message]
2021-09-22 20:59 ` Jiri Olsa
2021-09-18 6:35 ` [PATCH v8 6/8] perf metric: Allow metrics with no events Ian Rogers
2021-09-18 6:35 ` [PATCH v8 7/8] perf metric: Don't compute unused events Ian Rogers
2021-09-18 6:35 ` [PATCH v8 8/8] perf test: Add metric test for eliminating events Ian Rogers
2021-09-20 13:46 ` [PATCH v8 0/8] Don't compute events that won't be used in a metric Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUuY+WhB3Y3VQm2w@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=john.garry@huawei.com \
--cc=kjain@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=pc@us.ibm.com \
--cc=peterz@infradead.org \
--cc=sdasgup@google.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).