linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: "Liang, Kan" <kan.liang@linux.intel.com>
Cc: Ian Rogers <irogers@google.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
	Zhengjun Xing <zhengjun.xing@linux.intel.com>,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
	Edward Baker <edward.baker@intel.com>,
	Dan Williams <dan.j.williams@intel.com>,
	perry.taylor@intel.com, caleb.biggers@intel.com,
	samantha.alt@intel.com, weilin.wang@intel.com
Subject: Re: [PATCH v3 0/9] Update Intel events and make nvdimm events dynamic
Date: Fri, 24 Mar 2023 17:02:42 -0300	[thread overview]
Message-ID: <ZB4B4kD5t77T/E5T@kernel.org> (raw)
In-Reply-To: <acb7dcae-6365-b2cb-6147-589376116df0@linux.intel.com>

Em Fri, Mar 24, 2023 at 08:11:44AM -0400, Liang, Kan escreveu:
> 
> 
> On 2023-03-24 3:22 a.m., Ian Rogers wrote:
> > Update events from:
> > https://github.com/intel/perfmon/pull/62
> > 
> > Add new #has_pmem literal to allow memory metrics to be dynamic in how
> > nvdimm events are enabled. Update CLX, ICX and SPR for this using this
> > PR:
> > https://github.com/intel/perfmon/pull/63
> > 
> > v3. Change has_optane to has_pmem as suggested by Kan Liang and Dan Williams.
> > 
> > Ian Rogers (9):
> >   perf vendor events: Broadwell v27 events
> >   perf vendor events: Broadwellde v9 events
> >   perf vendor events: Broadwellx v20 events
> >   perf vendor events: Haswell v33 events
> >   perf vendor events: Haswellx v27 events
> >   perf vendor events: Jaketown v23 events
> >   perf vendor events: Sandybridge v19 events
> >   perf metrics: Add has_pmem literal
> >   perf vendor events: Update metrics to detect pmem at runtime
> > 
> 
> 
> Thanks Ian. The patch series looks good to me.
> 
> Reviewed-by: Kan Liang <kan.liang@linux.intel.com>

Thanks, applied.

- Arnaldo

> 
> Thanks,
> Kan
> 
> >  .../pmu-events/arch/x86/broadwell/cache.json  | 296 +++++-----
> >  .../arch/x86/broadwell/floating-point.json    |   7 +
> >  .../arch/x86/broadwell/frontend.json          |  18 +-
> >  .../pmu-events/arch/x86/broadwell/memory.json | 248 ++++-----
> >  .../arch/x86/broadwell/pipeline.json          |  22 +-
> >  .../arch/x86/broadwell/uncore-other.json      |   2 +-
> >  .../arch/x86/broadwellde/cache.json           | 105 ++--
> >  .../arch/x86/broadwellde/floating-point.json  |  45 +-
> >  .../arch/x86/broadwellde/frontend.json        |  18 +-
> >  .../arch/x86/broadwellde/memory.json          |  64 ++-
> >  .../arch/x86/broadwellde/pipeline.json        |  79 +--
> >  .../arch/x86/broadwellde/uncore-cache.json    |  72 +--
> >  .../arch/x86/broadwellde/uncore-memory.json   | 256 ++++++++-
> >  .../arch/x86/broadwellde/uncore-other.json    |  27 +-
> >  .../arch/x86/broadwellde/uncore-power.json    |  10 +-
> >  .../pmu-events/arch/x86/broadwellx/cache.json |  16 +-
> >  .../arch/x86/broadwellx/frontend.json         |  18 +-
> >  .../arch/x86/broadwellx/pipeline.json         |  20 +-
> >  .../arch/x86/broadwellx/uncore-cache.json     | 156 ++----
> >  .../x86/broadwellx/uncore-interconnect.json   |  84 +--
> >  .../arch/x86/broadwellx/uncore-memory.json    | 522 +++++++++---------
> >  .../arch/x86/broadwellx/uncore-other.json     |  44 +-
> >  .../arch/x86/broadwellx/uncore-power.json     |  10 +-
> >  .../arch/x86/cascadelakex/clx-metrics.json    |  10 +-
> >  .../pmu-events/arch/x86/haswell/cache.json    |  38 +-
> >  .../pmu-events/arch/x86/haswell/memory.json   |  38 +-
> >  .../pmu-events/arch/x86/haswell/pipeline.json |   8 +
> >  .../pmu-events/arch/x86/haswellx/cache.json   |   2 +-
> >  .../arch/x86/haswellx/pipeline.json           |   8 +
> >  .../arch/x86/haswellx/uncore-cache.json       |  16 +-
> >  .../arch/x86/haswellx/uncore-other.json       |   6 +-
> >  .../arch/x86/icelakex/icx-metrics.json        |  10 +-
> >  .../arch/x86/jaketown/pipeline.json           |   8 +
> >  tools/perf/pmu-events/arch/x86/mapfile.csv    |  14 +-
> >  .../arch/x86/sandybridge/pipeline.json        |   8 +
> >  .../arch/x86/sapphirerapids/spr-metrics.json  |  10 +-
> >  tools/perf/util/expr.c                        |  19 +
> >  37 files changed, 1323 insertions(+), 1011 deletions(-)
> > 

-- 

- Arnaldo

      reply	other threads:[~2023-03-24 20:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-24  7:22 [PATCH v3 0/9] Update Intel events and make nvdimm events dynamic Ian Rogers
2023-03-24  7:22 ` [PATCH v3 4/9] perf vendor events: Haswell v33 events Ian Rogers
2023-03-24  7:22 ` [PATCH v3 5/9] perf vendor events: Haswellx v27 events Ian Rogers
2023-03-24  7:22 ` [PATCH v3 6/9] perf vendor events: Jaketown v23 events Ian Rogers
2023-03-24  7:22 ` [PATCH v3 7/9] perf vendor events: Sandybridge v19 events Ian Rogers
2023-03-24  7:22 ` [PATCH v3 8/9] perf metrics: Add has_pmem literal Ian Rogers
2023-03-24  7:22 ` [PATCH v3 9/9] perf vendor events: Update metrics to detect pmem at runtime Ian Rogers
2023-03-24 12:11 ` [PATCH v3 0/9] Update Intel events and make nvdimm events dynamic Liang, Kan
2023-03-24 20:02   ` Arnaldo Carvalho de Melo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZB4B4kD5t77T/E5T@kernel.org \
    --to=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=caleb.biggers@intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=edward.baker@intel.com \
    --cc=irogers@google.com \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=perry.taylor@intel.com \
    --cc=peterz@infradead.org \
    --cc=samantha.alt@intel.com \
    --cc=weilin.wang@intel.com \
    --cc=zhengjun.xing@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).