From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F2C2C77B60 for ; Wed, 29 Mar 2023 13:18:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230255AbjC2NSd (ORCPT ); Wed, 29 Mar 2023 09:18:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230293AbjC2NSY (ORCPT ); Wed, 29 Mar 2023 09:18:24 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A97E5588; Wed, 29 Mar 2023 06:18:14 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2D8C061D11; Wed, 29 Mar 2023 13:18:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4FF1DC43321; Wed, 29 Mar 2023 13:18:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680095893; bh=0kws+d9Nmkb4SZo6HGrrZaRdbgyyJEYMqGYIL1EJG+Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QztLpmc+Q5DKUUvHOYSENPRc98tzx/hhOu6lJ1d6I9qpVZT26qGVSp49GnAAiz+sg 55GtTS6RhMyFouLI2CJbzzZcWwnSPo3rRjRTF+fR3qcTWXVzOnfa8k3/NR7A+/gvjM Z0Y9bXrpiOxg66k3dy1IwHG+WDeVRlEKalykiVJivfEYi8nRbQ1uoM8XEMEMcRc26y ujaaZC6OWc3EliSgIbaDTKoV0ugw8TYmVcZHsSghKSZEQtCumQmvp8ZTBPfgO/0br1 kyQ4VoWf3UNUOTaqrdrQXrfcVkvC1TJ9m7RQ+V5JwR+oD4wmr5hHYRd0jhxZlv/M4z /Q84b0E+Wzrkw== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id D678B4052D; Wed, 29 Mar 2023 10:18:10 -0300 (-03) Date: Wed, 29 Mar 2023 10:18:10 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Nathan Chancellor , Nick Desaulniers , Tom Rix , James Clark , Andi Kleen , Kan Liang , German Gomez , Sandipan Das , Andres Freund , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH v1 1/6] perf annotate: Delete session for debug builds Message-ID: References: <20230328235543.1082207-1-irogers@google.com> <20230328235543.1082207-2-irogers@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Em Wed, Mar 29, 2023 at 10:09:48AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Tue, Mar 28, 2023 at 04:55:38PM -0700, Ian Rogers escreveu: > > Use the debug build indicator as the guide to free the session. This > > implements a behavior described in a comment, which is consequentially > > removed. > > > > Signed-off-by: Ian Rogers > > --- > > tools/perf/builtin-annotate.c | 16 ++++++---------- > > 1 file changed, 6 insertions(+), 10 deletions(-) > > > > diff --git a/tools/perf/builtin-annotate.c b/tools/perf/builtin-annotate.c > > index 4750fac7bf93..98d1b6379230 100644 > > --- a/tools/perf/builtin-annotate.c > > +++ b/tools/perf/builtin-annotate.c > > @@ -692,16 +692,12 @@ int cmd_annotate(int argc, const char **argv) > > > > out_delete: > > /* > > - * Speed up the exit process, for large files this can > > - * take quite a while. > > - * > > - * XXX Enable this when using valgrind or if we ever > > - * librarize this command. > > - * > > - * Also experiment with obstacks to see how much speed > > - * up we'll get here. > > - * > > - * perf_session__delete(session); > > + * Speed up the exit process by only deleting for debug builds. For > > + * large files this can save time. > > */ > > +#ifndef NDEBUG > > + perf_session__delete(annotate.session); > > +#endif > > So now, but default, we will call this, as we don't have this defined > only if DEBUG=1 is set, right? > > ⬢[acme@toolbox perf-tools-next]$ find tools/perf/ -type f | xargs grep NDEBUG > tools/perf/util/mutex.c:#ifndef NDEBUG > ⬢[acme@toolbox perf-tools-next]$ We can discuss this later, applied the series with just that zfree() change to annotation_options__exit(). - Arnaldo