From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B859C6FD18 for ; Wed, 29 Mar 2023 22:15:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229875AbjC2WO7 (ORCPT ); Wed, 29 Mar 2023 18:14:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229481AbjC2WO7 (ORCPT ); Wed, 29 Mar 2023 18:14:59 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 53F134ED5; Wed, 29 Mar 2023 15:14:58 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DF36361E6C; Wed, 29 Mar 2023 22:14:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1B2E5C433EF; Wed, 29 Mar 2023 22:14:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680128095; bh=MFuPZQqD4TiUnyMW84dUQN7dzlnJ8J7WDOdYQ93UJo0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pTgNPDTA+25+D2uNWZwzzg1Twzc9rkdhgrg0y6MiThrNBTlqNVI65BTFUbAflhz76 pPjQ7kwQkmc9KSG0HaFeBh1ulLSGX24cEmATOc+UULC+XVGKyjjJMfTkTacGzqzTDZ 7SxMQmiMinb95O1I0xLl2aCSkncPGQNdHQ+Gg1luYEuIGOCx/vY70+wWdLCAeZih3h wx7h1fA1HVxg0vCxQ390OLKmYY8vBy1xKN3dDQfJyle7lOYB6lQSO+UjNAatMgU2sV QzmG71QA28+tDg9XBMILrEJm03kQVlmBCjhb6CiiUFITvBAAiLJ+nCieglmjzodlun 2QQRyy94Rl0xw== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 941194052D; Wed, 29 Mar 2023 19:14:52 -0300 (-03) Date: Wed, 29 Mar 2023 19:14:52 -0300 From: Arnaldo Carvalho de Melo To: Mike Leach Cc: linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org, linux-kernel@vger.kernel.org, suzuki.poulose@arm.com, leo.yan@linaro.org, peterz@infradead.org, mingo@redhat.com, will@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@redhat.com, namhyung@kernel.org, gankulkarni@os.amperecomputing.com, darren@os.amperecomputing.com, James Clark Subject: Re: [PATCH v8 1/3] perf: cs-etm: Move mapping of Trace ID and cpu into helper function Message-ID: References: <20230329111422.3693-1-mike.leach@linaro.org> <20230329111422.3693-2-mike.leach@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Em Wed, Mar 29, 2023 at 04:28:19PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Mar 29, 2023 at 03:47:25PM +0100, Mike Leach escreveu: > > On Wed, 29 Mar 2023 at 14:22, Arnaldo Carvalho de Melo wrote: > > > > > > Em Wed, Mar 29, 2023 at 01:59:10PM +0100, Mike Leach escreveu: > > > > Sorry - my error. > > > > > > > > The same change is made in patch 3/3 of this set. > > > > > > > > Looks like I didn't do a patch by patch build check when I was testing yesterday > > > > > > np, its fixed now and pushed to tmp.perf-tools-next, please check, will > > > go to perf-tools-next later today after passing thru my set of container > > > build tests. > > > > > > - Arnaldo > > > > tmp.perf-tools-next - Builds and tests OK > > Not here, I'll check after a call: > > 50 9.90 ubuntu:18.04-x-arm : FAIL gcc version 7.5.0 (Ubuntu/Linaro 7.5.0-3ubuntu1~18.04) > arch/arm/util/cs-etm.c: In function 'cs_etm_save_ete_header': > arch/arm/util/cs-etm.c:720:29: error: implicit declaration of function 'coresight_get_trace_id' [-Werror=implicit-function-declaration] > data[CS_ETE_TRCTRACEIDR] = coresight_get_trace_id(cpu); > ^~~~~~~~~~~~~~~~~~~~~~ This function was removed in: Author: Mike Leach Date: Wed Mar 29 12:14:21 2023 +0100 perf cs-etm: Update record event to use new Trace ID protocol Trace IDs are now dynamically allocated. I'm removing this series from perf-tools-next, please address this issue and send a v9. Thanks, - Arnaldo > cc1: all warnings being treated as errors > /git/perf-6.3.0-rc1/tools/build/Makefile.build:140: recipe for target 'util' failed > make[5]: *** [util] Error 2 > /git/perf-6.3.0-rc1/tools/build/Makefile.build:140: recipe for target 'arm' failed > make[4]: *** [arm] Error 2 > /git/perf-6.3.0-rc1/tools/build/Makefile.build:140: recipe for target 'arch' failed > make[3]: *** [arch] Error 2 > 51 9.50 ubuntu:18.04-x-arm64 : FAIL gcc version 7.5.0 (Ubuntu/Linaro 7.5.0-3ubuntu1~18.04) > arch/arm64/util/../../arm/util/cs-etm.c: In function 'cs_etm_save_ete_header': > arch/arm64/util/../../arm/util/cs-etm.c:720:29: error: implicit declaration of function 'coresight_get_trace_id' [-Werror=implicit-function-declaration] > data[CS_ETE_TRCTRACEIDR] = coresight_get_trace_id(cpu); > ^~~~~~~~~~~~~~~~~~~~~~ > cc1: all warnings being treated as errors > /git/perf-6.3.0-rc1/tools/build/Makefile.build:140: recipe for target 'util' failed > make[5]: *** [util] Error 2 > /git/perf-6.3.0-rc1/tools/build/Makefile.build:140: recipe for target 'arm64' failed > make[4]: *** [arm64] Error 2 > /git/perf-6.3.0-rc1/tools/build/Makefile.build:140: recipe for target 'arch' failed > make[3]: *** [arch] Error 2 > 52 19.34 ubuntu:18.04-x-m68k : Ok m68k-linux-gnu-gcc (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0 -- - Arnaldo