From: James Clark <james.clark@arm.com>
To: Alexandre Truong <alexandre.truong@arm.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org
Cc: John Garry <john.garry@huawei.com>, Leo Yan <leo.yan@linaro.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>
Subject: Re: [PATCH] perf tools: add aarch64 registers to --user-regs
Date: Mon, 30 Nov 2020 17:54:57 +0200 [thread overview]
Message-ID: <cd0592be-68d2-c88d-ff18-05f7d3ba8cc2@arm.com> (raw)
In-Reply-To: <20201127153923.26717-1-alexandre.truong@arm.com>
On 27/11/2020 17:39, Alexandre Truong wrote:
> Previously, this command returns no help message on aarch64:
>
> -> ./perf record --user-regs=?
>
> available registers:
> Usage: perf record [<options>] [<command>]
> or: perf record [<options>] -- <command> [<options>]
>
> With this change, the registers are listed.
>
> -> ./perf record --user-regs=?
>
> available registers: x0 x1 x2 x3 x4 x5 x6 x7 x8 x9 x10 x11 x12 x13 x14 x15 x16 x17 x18 x19 x20 x21 x22 x23 x24 x25 x26 x27 x28 x29 lr sp pc
>
> It's also now possible to record subsets of registers on aarch64:
>
> -> ./perf record --user-regs=x4,x5 ls
> -> ./perf report --dump-raw-trace
>
> 12801163749305260 0xc70 [0x40]: PERF_RECORD_SAMPLE(IP, 0x2): 51956/51956: 0xffffaa6571f0 period: 145785 addr: 0
> ... user regs: mask 0x30 ABI 64-bit
> .... x4 0x000000000000006c
> .... x5 0x0000001001000001
> ... thread: ls:51956
> ...... dso: /usr/lib64/ld-2.17.so
>
Checked that the registers can be listed with =? and that recording different combinations of registers works as expected.
Tested-by: James Clark <james.clark@arm.com>
next prev parent reply other threads:[~2020-11-30 15:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-27 15:39 [PATCH] perf tools: add aarch64 registers to --user-regs Alexandre Truong
2020-11-30 15:54 ` James Clark [this message]
2020-11-30 17:30 ` John Garry
2020-11-30 17:41 ` Arnaldo Carvalho de Melo
2020-12-01 3:46 ` Leo Yan
2020-12-01 3:48 ` Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd0592be-68d2-c88d-ff18-05f7d3ba8cc2@arm.com \
--to=james.clark@arm.com \
--cc=acme@kernel.org \
--cc=alexandre.truong@arm.com \
--cc=john.garry@huawei.com \
--cc=jolsa@redhat.com \
--cc=leo.yan@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).