From mboxrd@z Thu Jan  1 00:00:00 1970
From: John Garry <john.garry@huawei.com>
Subject: Re: [PATCH] perf vendor events arm64: Enable JSON events for eMAG
Date: Fri, 3 Aug 2018 15:41:06 +0100
Message-ID: <d6d9db03-657e-005c-8aa2-d0b3b41acb47@huawei.com>
References: <20180803041811.17065-1-seanvk.dev@oregontracks.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org>
In-Reply-To: <20180803041811.17065-1-seanvk.dev@oregontracks.org>
List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-arm-kernel>,
 <mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe>
List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/>
List-Post: <mailto:linux-arm-kernel@lists.infradead.org>
List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help>
List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>,
 <mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe>
Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org>
Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org
To: Sean V Kelley <seanvk.dev@oregontracks.org>, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org
Cc: skelley@amperecomputing.com, Peter Zijlstra <peterz@infradead.org>, Will Deacon <will.deacon@arm.com>, Arnaldo Carvalho de Melo <acme@kernel.org>, Alexander Shishkin <alexander.shishkin@linux.intel.com>, Ingo Molnar <mingo@redhat.com>, Ganapatrao Kulkarni <ganapatrao.kulkarni@cavium.com>, Namhyung Kim <namhyung@kernel.org>, William Cohen <wcohen@redhat.com>, Jiri Olsa <jolsa@redhat.com>
List-Id: linux-perf-users.vger.kernel.org

On 03/08/2018 05:18, Sean V Kelley wrote:
> This patch adds the Ampere Computing eMAG file.  This platform
> follows the ARMv8 recommended IMPLEMENTATION DEFINED events, where
> applicable.
>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
> Cc: Jiri Olsa <jolsa@redhat.com>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: John Garry <john.garry@huawei.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Cc: Ganapatrao Kulkarni <ganapatrao.kulkarni@cavium.com>
> Cc: William Cohen <wcohen@redhat.com>
>
> Signed-off-by: Sean V Kelley <seanvk.dev@oregontracks.org>

Reviewed-by: John Garry <john.garry@huawei.com>

> ---
>  .../arch/arm64/ampere/emag/core-imp-def.json  | 32 +++++++++++++++++++
>  tools/perf/pmu-events/arch/arm64/mapfile.csv  |  1 +
>  2 files changed, 33 insertions(+)
>  create mode 100644 tools/perf/pmu-events/arch/arm64/ampere/emag/core-imp-def.json
>
> diff --git a/tools/perf/pmu-events/arch/arm64/ampere/emag/core-imp-def.json b/tools/perf/pmu-events/arch/arm64/ampere/emag/core-imp-def.json
> new file mode 100644
> index 000000000000..bc03c06c3918
> --- /dev/null
> +++ b/tools/perf/pmu-events/arch/arm64/ampere/emag/core-imp-def.json
> @@ -0,0 +1,32 @@
> +[
> +    {
> +        "ArchStdEvent": "L1D_CACHE_RD",
> +    },
> +    {
> +        "ArchStdEvent": "L1D_CACHE_WR",
> +    },
> +    {
> +        "ArchStdEvent": "L1D_CACHE_REFILL_RD",
> +    },
> +    {
> +        "ArchStdEvent": "L1D_CACHE_REFILL_WR",
> +    },
> +    {
> +        "ArchStdEvent": "L1D_TLB_REFILL_RD",
> +    },
> +    {
> +        "ArchStdEvent": "L1D_TLB_REFILL_WR",
> +    },
> +    {
> +        "ArchStdEvent": "L1D_TLB_RD",
> +    },
> +    {
> +        "ArchStdEvent": "L1D_TLB_WR",
> +    },
> +    {
> +        "ArchStdEvent": "BUS_ACCESS_RD",
> +   },
> +   {
> +        "ArchStdEvent": "BUS_ACCESS_WR",
> +   }
> +]
> diff --git a/tools/perf/pmu-events/arch/arm64/mapfile.csv b/tools/perf/pmu-events/arch/arm64/mapfile.csv
> index f03e26ecb658..59cd8604b0bd 100644
> --- a/tools/perf/pmu-events/arch/arm64/mapfile.csv
> +++ b/tools/perf/pmu-events/arch/arm64/mapfile.csv
> @@ -16,3 +16,4 @@
>  0x00000000420f5160,v1,cavium/thunderx2,core
>  0x00000000430f0af0,v1,cavium/thunderx2,core
>  0x00000000480fd010,v1,hisilicon/hip08,core
> +0x00000000500f0000,v1,ampere/emag,core

We could order by vendor/platform, but not so important as I see.

>