From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1124C6FD18 for ; Wed, 29 Mar 2023 12:03:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229601AbjC2MDQ (ORCPT ); Wed, 29 Mar 2023 08:03:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41738 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229485AbjC2MDQ (ORCPT ); Wed, 29 Mar 2023 08:03:16 -0400 Received: from out30-100.freemail.mail.aliyun.com (out30-100.freemail.mail.aliyun.com [115.124.30.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67D78268B; Wed, 29 Mar 2023 05:03:13 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R181e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045176;MF=renyu.zj@linux.alibaba.com;NM=1;PH=DS;RN=16;SR=0;TI=SMTPD_---0VewkIyt_1680091388; Received: from 30.221.149.47(mailfrom:renyu.zj@linux.alibaba.com fp:SMTPD_---0VewkIyt_1680091388) by smtp.aliyun-inc.com; Wed, 29 Mar 2023 20:03:09 +0800 Message-ID: Date: Wed, 29 Mar 2023 20:03:08 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH RFC 3/4] driver/perf: Add identifier sysfs file for Yitian 710 DDR To: Shuai Xue , John Garry , Ian Rogers , Will Deacon , James Clark , Mike Leach , Leo Yan , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, Zhuo Song References: <1679885172-95021-1-git-send-email-renyu.zj@linux.alibaba.com> <1679885172-95021-4-git-send-email-renyu.zj@linux.alibaba.com> <7060f009-2964-30af-3d12-2bb3e21b6c1e@linux.alibaba.com> From: Jing Zhang In-Reply-To: <7060f009-2964-30af-3d12-2bb3e21b6c1e@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org 在 2023/3/29 下午3:55, Shuai Xue 写道: > > > On 2023/3/27 AM10:46, Jing Zhang wrote: >> To allow userspace to identify the specific implementation of the device, >> add an "identifier" sysfs file. >> >> The perf tool can match the Yitian 710 DDR metric through the identifier. >> >> Signed-off-by: Jing Zhang >> --- >> drivers/perf/alibaba_uncore_drw_pmu.c | 27 +++++++++++++++++++++++++++ >> 1 file changed, 27 insertions(+) >> >> diff --git a/drivers/perf/alibaba_uncore_drw_pmu.c b/drivers/perf/alibaba_uncore_drw_pmu.c >> index a7689fe..6639a57 100644 >> --- a/drivers/perf/alibaba_uncore_drw_pmu.c >> +++ b/drivers/perf/alibaba_uncore_drw_pmu.c >> @@ -236,10 +236,37 @@ static ssize_t ali_drw_pmu_cpumask_show(struct device *dev, >> .attrs = ali_drw_pmu_cpumask_attrs, >> }; >> >> +static ssize_t ali_drw_pmu_identifier_show(struct device *dev, >> + struct device_attribute *attr, >> + char *page) >> +{ >> + return sysfs_emit(page, "%s\n", "ali_drw_yitian710"); > > Is it possible to rename identifier as "ali_drw_pmu"? I don't think we need only > limit alibaba_uncore_drw_pmu to Yitian710 SoC here. > Ok, I will rename it as "ali_drw_pmu". Thanks, Jing > Thank you. > Shuai > >> +} >> + >> +static umode_t ali_drw_pmu_identifier_attr_visible(struct kobject *kobj, >> + struct attribute *attr, int n) >> +{ >> + return attr->mode; >> +} >> + >> +static struct device_attribute ali_drw_pmu_identifier_attr = >> + __ATTR(identifier, 0444, ali_drw_pmu_identifier_show, NULL); >> + >> +static struct attribute *ali_drw_pmu_identifier_attrs[] = { >> + &ali_drw_pmu_identifier_attr.attr, >> + NULL, >> +}; >> + >> +static const struct attribute_group ali_drw_pmu_identifier_attr_group = { >> + .attrs = ali_drw_pmu_identifier_attrs, >> + .is_visible = ali_drw_pmu_identifier_attr_visible, >> +}; >> + >> static const struct attribute_group *ali_drw_pmu_attr_groups[] = { >> &ali_drw_pmu_events_attr_group, >> &ali_drw_pmu_cpumask_attr_group, >> &ali_drw_pmu_format_group, >> + &ali_drw_pmu_identifier_attr_group, >> NULL, >> }; >>