From: Adrian Hunter <adrian.hunter@intel.com>
To: Namhyung Kim <namhyung@kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Jiri Olsa <jolsa@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
Ian Rogers <irogers@google.com>,
linux-perf-users@vger.kernel.org,
Kan Liang <kan.liang@linux.intel.com>,
Leo Yan <leo.yan@linaro.org>
Subject: Re: [PATCH 1/5] libperf: Populate system-wide evsel maps
Date: Tue, 27 Sep 2022 09:56:06 +0300 [thread overview]
Message-ID: <e9f85e23-3544-5bbd-4579-cd994a12b3a2@intel.com> (raw)
In-Reply-To: <20220924165737.956428-2-namhyung@kernel.org>
On 24/09/22 19:57, Namhyung Kim wrote:
> Setting proper cpu and thread maps for system wide evsels regardless of
> user requested cpu in __perf_evlist__propagate_maps(). Those evsels
> need to be active on all cpus always. Do it in the libperf so that we
> can guarantee it has proper maps.
>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Reviewed-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> tools/lib/perf/evlist.c | 15 +++++++++------
> 1 file changed, 9 insertions(+), 6 deletions(-)
>
> diff --git a/tools/lib/perf/evlist.c b/tools/lib/perf/evlist.c
> index 6b1bafe267a4..187129652ab6 100644
> --- a/tools/lib/perf/evlist.c
> +++ b/tools/lib/perf/evlist.c
> @@ -40,11 +40,11 @@ static void __perf_evlist__propagate_maps(struct perf_evlist *evlist,
> * We already have cpus for evsel (via PMU sysfs) so
> * keep it, if there's no target cpu list defined.
> */
> - if (!evsel->own_cpus ||
> - (!evsel->system_wide && evlist->has_user_cpus) ||
> - (!evsel->system_wide &&
> - !evsel->requires_cpu &&
> - perf_cpu_map__empty(evlist->user_requested_cpus))) {
> + if (evsel->system_wide) {
> + perf_cpu_map__put(evsel->cpus);
> + evsel->cpus = perf_cpu_map__new(NULL);
> + } else if (!evsel->own_cpus || evlist->has_user_cpus ||
> + (!evsel->requires_cpu && perf_cpu_map__empty(evlist->user_requested_cpus))) {
> perf_cpu_map__put(evsel->cpus);
> evsel->cpus = perf_cpu_map__get(evlist->user_requested_cpus);
> } else if (evsel->cpus != evsel->own_cpus) {
> @@ -52,7 +52,10 @@ static void __perf_evlist__propagate_maps(struct perf_evlist *evlist,
> evsel->cpus = perf_cpu_map__get(evsel->own_cpus);
> }
>
> - if (!evsel->system_wide) {
> + if (evsel->system_wide) {
> + perf_thread_map__put(evsel->threads);
> + evsel->threads = perf_thread_map__new_dummy();
> + } else {
> perf_thread_map__put(evsel->threads);
> evsel->threads = perf_thread_map__get(evlist->threads);
> }
next prev parent reply other threads:[~2022-09-27 6:56 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-24 16:57 [PATCH 0/5] perf tools: Clean up cpu map handling for a system-wide evsel (v1) Namhyung Kim
2022-09-24 16:57 ` [PATCH 1/5] libperf: Populate system-wide evsel maps Namhyung Kim
2022-09-27 6:56 ` Adrian Hunter [this message]
2022-09-24 16:57 ` [PATCH 2/5] libperf: Propagate maps only if necessary Namhyung Kim
2022-09-27 7:06 ` Adrian Hunter
2022-09-27 17:28 ` Namhyung Kim
2022-09-28 7:53 ` Adrian Hunter
2022-09-28 23:46 ` Namhyung Kim
2022-09-29 2:07 ` Ian Rogers
2022-09-29 5:09 ` Namhyung Kim
2022-09-29 5:18 ` Adrian Hunter
2022-09-29 20:42 ` Namhyung Kim
2022-09-30 12:49 ` Adrian Hunter
2022-09-30 16:44 ` Namhyung Kim
2022-09-30 16:56 ` Arnaldo Carvalho de Melo
2022-09-24 16:57 ` [PATCH 3/5] perf tools: Get rid of evlist__add_on_all_cpus() Namhyung Kim
2022-09-27 7:07 ` Adrian Hunter
2022-09-24 16:57 ` [PATCH 4/5] perf tools: Add evlist__add_sched_switch() Namhyung Kim
2022-09-27 7:07 ` Adrian Hunter
2022-09-24 16:57 ` [PATCH 5/5] perf tools: Remove special handling of system-wide evsel Namhyung Kim
2022-09-27 7:09 ` Adrian Hunter
2022-09-26 19:24 ` [PATCH 0/5] perf tools: Clean up cpu map handling for a system-wide evsel (v1) Arnaldo Carvalho de Melo
2022-09-30 17:27 [PATCH 0/5] perf tools: Clean up cpu map handling for system-wide evsel (v2) Namhyung Kim
2022-09-30 17:27 ` [PATCH 1/5] libperf: Populate system-wide evsel maps Namhyung Kim
2022-10-03 20:46 [PATCH 0/5] perf tools: Clean up cpu map handling for system-wide evsel (v3) Namhyung Kim
2022-10-03 20:46 ` [PATCH 1/5] libperf: Populate system-wide evsel maps Namhyung Kim
2022-10-06 18:43 ` Ian Rogers
2022-10-06 23:13 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9f85e23-3544-5bbd-4579-cd994a12b3a2@intel.com \
--to=adrian.hunter@intel.com \
--cc=acme@kernel.org \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=leo.yan@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).