From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Julien Stephan <jstephan@baylibre.com>
Cc: Phi-bang Nguyen <pnguyen@baylibre.com>,
Louis Kuo <louis.kuo@mediatek.com>,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
Andy Hsieh <andy.hsieh@mediatek.com>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Chun-Kuang Hu <chunkuang.hu@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
"moderated list:ARM/Mediatek USB3 PHY DRIVER"
<linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek USB3 PHY DRIVER"
<linux-mediatek@lists.infradead.org>,
"open list:GENERIC PHY FRAMEWORK" <linux-phy@lists.infradead.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
"open list:DRM DRIVERS FOR MEDIATEK"
<dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 2/2] phy: mtk-mipi-csi: add driver for CSI phy
Date: Mon, 3 Apr 2023 11:51:50 +0200 [thread overview]
Message-ID: <6c9c74ee-b9ed-815f-dd92-37eb4c8f802a@linaro.org> (raw)
In-Reply-To: <20230403071929.360911-3-jstephan@baylibre.com>
On 03/04/2023 09:19, Julien Stephan wrote:
> From: Phi-bang Nguyen <pnguyen@baylibre.com>
>
> This is a new driver that supports the MIPI CSI CD-PHY for mediatek
> mt8365 soc
>
> Signed-off-by: Louis Kuo <louis.kuo@mediatek.com>
> Signed-off-by: Phi-bang Nguyen <pnguyen@baylibre.com>
> [Julien Stephan: use regmap]
> [Julien Stephan: use GENMASK]
> Co-developed-by: Julien Stephan <jstephan@baylibre.com>
> Signed-off-by: Julien Stephan <jstephan@baylibre.com>
> ---
> .../bindings/phy/mediatek,csi-phy.yaml | 9 +-
> MAINTAINERS | 1 +
> drivers/phy/mediatek/Kconfig | 8 +
> drivers/phy/mediatek/Makefile | 2 +
> .../phy/mediatek/phy-mtk-mipi-csi-rx-reg.h | 435 ++++++++++++++++++
> drivers/phy/mediatek/phy-mtk-mipi-csi.c | 392 ++++++++++++++++
> 6 files changed, 845 insertions(+), 2 deletions(-)
> create mode 100644 drivers/phy/mediatek/phy-mtk-mipi-csi-rx-reg.h
> create mode 100644 drivers/phy/mediatek/phy-mtk-mipi-csi.c
>
> diff --git a/Documentation/devicetree/bindings/phy/mediatek,csi-phy.yaml b/Documentation/devicetree/bindings/phy/mediatek,csi-phy.yaml
> index c026e43f35fd..ad4ba1d93a68 100644
> --- a/Documentation/devicetree/bindings/phy/mediatek,csi-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/mediatek,csi-phy.yaml
NAK, bindings are always separate patches. It also does not make any
sense - you just added it.
> @@ -33,9 +33,14 @@ additionalProperties: false
>
> examples:
> - |
> - phy@10011800 {
> + soc {
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + phy@11c10000 {
> compatible = "mediatek,mt8365-mipi-csi";
> - reg = <0 0x10011800 0 0x60>;
> + reg = <0 0x11c10000 0 0x4000>;
> #phy-cells = <1>;
> + };
> };
k_mipi_dphy_of_match[] = {
> + {.compatible = "mediatek,mt8365-mipi-csi"},
> + {},
> +};
> +MODULE_DEVICE_TABLE(of, mtk_mipi_dphy_of_match);
> +
> +static struct platform_driver mipi_dphy_pdrv = {
> + .probe = mtk_mipi_dphy_probe,
> + .remove = mtk_mipi_dphy_remove,
> + .driver = {
> + .name = "mtk-mipi-csi",
> + .of_match_table = of_match_ptr(mtk_mipi_dphy_of_match),
Drop of_match_ptr(). You should see W=1 warnings when compile testing.
Best regards,
Krzysztof
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2023-04-03 9:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230403071929.360911-1-jstephan@baylibre.com>
2023-04-03 7:19 ` [PATCH 1/2] dt-bindings: phy: add mtk-mipi-csi driver Julien Stephan
2023-04-03 9:49 ` Krzysztof Kozlowski
[not found] ` <CAEHHSvYJrCZop8OvTjsLJjr5HHSrG8dsSQ+K_W2cjdKJ4xfodA@mail.gmail.com>
2023-04-03 14:54 ` Krzysztof Kozlowski
2023-04-03 13:10 ` Rob Herring
2023-04-07 2:40 ` Chunfeng Yun (云春峰)
2023-04-03 7:19 ` [PATCH 2/2] phy: mtk-mipi-csi: add driver for CSI phy Julien Stephan
2023-04-03 9:51 ` Krzysztof Kozlowski [this message]
2023-04-05 9:27 ` Julien Stephan
2023-04-03 10:15 ` Chun-Kuang Hu
2023-04-03 15:21 ` Chun-Kuang Hu
2023-04-03 16:36 ` Chun-Kuang Hu
2023-04-07 3:31 ` Chunfeng Yun (云春峰)
2023-04-07 5:30 ` Chunfeng Yun (云春峰)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c9c74ee-b9ed-815f-dd92-37eb4c8f802a@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andy.hsieh@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunfeng.yun@mediatek.com \
--cc=chunkuang.hu@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jstephan@baylibre.com \
--cc=kishon@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-phy@lists.infradead.org \
--cc=louis.kuo@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=pnguyen@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).