From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Johan Hovold <johan@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
Johan Hovold <johan+linaro@kernel.org>
Subject: Re: [PATCH 2/2] phy: qcom-qmp-pcie: sc8180x PCIe PHY has 2 lanes
Date: Fri, 24 Mar 2023 14:19:10 +0200 [thread overview]
Message-ID: <CAA8EJprw0kPZtbO22-TcMYy+cqyUZCbJdMvUoiXWbcWDPCe0Aw@mail.gmail.com> (raw)
In-Reply-To: <ZB1P7h0FdT66k/LG@hovoldconsulting.com>
On Fri, 24 Mar 2023 at 09:23, Johan Hovold <johan@kernel.org> wrote:
>
> On Fri, Mar 24, 2023 at 03:17:52AM +0300, Dmitry Baryshkov wrote:
> > All PCIe PHYs on sc8180x platform have 2 lanes, so change the number of
> > lanes to 2.
> >
> > Fixes: 94a407cc17a4 ("phy: qcom-qmp: create copies of QMP PHY driver")
>
> This is not the right fixes tag either. This should have been
>
> Fixes: f839f14e24f2 ("phy: qcom-qmp: Add sc8180x PCIe support")
>
> Should this also be backported (i.e. should you add a stable tag)?
Maybe, but it's not that important. We don't have corresponding DT
bits, so it seems not that urgent.
>
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> > ---
> > drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c
> > index d580f3d3e221..c95bf7ec2abe 100644
> > --- a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c
> > +++ b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c
> > @@ -2193,7 +2193,7 @@ static const struct qmp_phy_cfg msm8998_pciephy_cfg = {
> > };
> >
> > static const struct qmp_phy_cfg sc8180x_pciephy_cfg = {
> > - .lanes = 1,
> > + .lanes = 2,
> >
> > .tbls = {
> > .serdes = sc8180x_qmp_pcie_serdes_tbl,
>
> Johan
--
With best wishes
Dmitry
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2023-03-24 12:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-24 0:17 [PATCH 1/2] phy: qcom-qmp-pcie: drop sdm845_qhp_pcie_rx_tbl Dmitry Baryshkov
2023-03-24 0:17 ` [PATCH 2/2] phy: qcom-qmp-pcie: sc8180x PCIe PHY has 2 lanes Dmitry Baryshkov
2023-03-24 7:23 ` Johan Hovold
2023-03-24 12:19 ` Dmitry Baryshkov [this message]
2023-03-24 7:21 ` [PATCH 1/2] phy: qcom-qmp-pcie: drop sdm845_qhp_pcie_rx_tbl Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAA8EJprw0kPZtbO22-TcMYy+cqyUZCbJdMvUoiXWbcWDPCe0Aw@mail.gmail.com \
--to=dmitry.baryshkov@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=johan+linaro@kernel.org \
--cc=johan@kernel.org \
--cc=kishon@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).