From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7E048C6FD1C for ; Fri, 24 Mar 2023 08:04:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XLvK7YpybUPaXBsZ7q9rHUIDidDYG3wJVsLBK9eufkk=; b=ABmapVrTQADKwZ cpJASFpWxhc9ih9lBakrJCCZJx+CHXGwguV6WFBO4AtlP44rvbJDcQv0Pmf1+ec5YSBXfgvzDHxc5 pW5Y31jc6xM3MaRz8OVdQU+/MfWTJ2+uMSdNHMglydDSOkM3VAj3MvN04n2T1x9Nbb/j0nK9ttxKg OybTcqvAMYctRa2M8bluJVE/kY5MeXzDTLyM1WmWrcPdDZ77bObbfmrx4CXfPWkjnOKq3Rd2WfkGn ahPhW6jtvK7pWC9LDdQHhih7+NJAAeTPzFBkWM4SIRqNvF9cneI92KyS7qqtaMYerAgpLY4wM2qcH u3jh3GG0nApyPgWS97CQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pfcPM-003pLQ-0l; Fri, 24 Mar 2023 08:04:20 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pfcPJ-003pKY-10 for linux-phy@lists.infradead.org; Fri, 24 Mar 2023 08:04:19 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A40FFB822F4; Fri, 24 Mar 2023 08:04:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3C987C433D2; Fri, 24 Mar 2023 08:04:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679645054; bh=2K/slDnR4IfjpiOGtIogZtO+BX/WGlJNuHWsirhnpmY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kh7FhJf9qECLiGxLEzChbAa/IhiRDumUvlvOAjIZQ4GJRemH1OtpjngiLH/ys4jED 2mPnbO/mv9nBw4EiyOO2QWH5YWUR1P+XbBRlnpFSOalLKuyxGUDI6Vf35pcrVI57rx D8gSluQExvNSizmYXBQCeiRVj8f4oIZBd/808ZdLYIFRnTn1aSRX74kmbJA/5rT59c cnApfkG4F79wdmlTmZ9fbSMapUJHQFFkfYzqkLarOr9LrFCNYBZwKfoVqM11BHgG+g 5SznNTkPKUUQxGdguZMKeKLtU4ov6qkxdbTCmy4v1TOFpeJoC2eUWkTQa8RnjHipJk fQS7ubKvKKaqw== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1pfcPF-0003Fo-F8; Fri, 24 Mar 2023 09:04:13 +0100 Date: Fri, 24 Mar 2023 09:04:13 +0100 From: Johan Hovold To: Dmitry Baryshkov Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Vinod Koul , Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, Johan Hovold Subject: Re: [PATCH 04/41] dt-bindings: phy: migrate QMP PCIe PHY bindings to qcom,sc8280xp-qmp-pcie-phy.yaml Message-ID: References: <20230324022514.1800382-1-dmitry.baryshkov@linaro.org> <20230324022514.1800382-5-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230324022514.1800382-5-dmitry.baryshkov@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230324_010417_644155_844CE665 X-CRM114-Status: GOOD ( 16.41 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On Fri, Mar 24, 2023 at 05:24:37AM +0300, Dmitry Baryshkov wrote: > Migrate legacy bindings (described in qcom,ipq8074-qmp-pcie-phy.yaml) > to qcom,sc8280xp-qmp-pcie-phy.yaml. This removes a need to declare > the child PHY node or split resource regions. > > Signed-off-by: Dmitry Baryshkov > --- > .../phy/qcom,ipq8074-qmp-pcie-phy.yaml | 299 ------------------ > .../phy/qcom,sc8280xp-qmp-pcie-phy.yaml | 213 +++++++++++-- > 2 files changed, 187 insertions(+), 325 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/phy/qcom,ipq8074-qmp-pcie-phy.yaml > diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml > index ef49efbd0a20..328588448c6b 100644 > --- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml > @@ -16,10 +16,23 @@ description: > properties: > compatible: > enum: > + - qcom,ipq6018-qmp-pcie-phy > + - qcom,ipq8074-qmp-gen3-pcie-phy > + - qcom,ipq8074-qmp-pcie-phy > + - qcom,msm8998-qmp-pcie-phy > + - qcom,sc8180x-qmp-pcie-phy > - qcom,sc8280xp-qmp-gen3x1-pcie-phy > - qcom,sc8280xp-qmp-gen3x2-pcie-phy > - qcom,sc8280xp-qmp-gen3x4-pcie-phy > + - qcom,sdm845-qhp-pcie-phy > + - qcom,sdm845-qmp-pcie-phy > + - qcom,sdx55-qmp-pcie-phy > + - qcom,sm8250-qmp-gen3x1-pcie-phy > + - qcom,sm8250-qmp-gen3x2-pcie-phy > + - qcom,sm8250-qmp-modem-pcie-phy > - qcom,sm8350-qmp-gen3x1-pcie-phy > + - qcom,sm8450-qmp-gen3x1-pcie-phy > + - qcom,sm8450-qmp-gen4x2-pcie-phy > - qcom,sm8550-qmp-gen3x2-pcie-phy > - qcom,sm8550-qmp-gen4x2-pcie-phy > > @@ -28,18 +41,12 @@ properties: > maxItems: 2 > > clocks: > - minItems: 5 > + minItems: 3 > maxItems: 6 > > clock-names: > - minItems: 5 > - items: > - - const: aux > - - const: cfg_ahb > - - const: ref > - - const: rchng > - - const: pipe > - - const: pipediv2 > + minItems: 3 > + maxItems: 6 > > power-domains: > maxItems: 1 > @@ -50,9 +57,7 @@ properties: > > reset-names: > minItems: 1 > - items: > - - const: phy > - - const: phy_nocsr > + maxItems: 2 > > vdda-phy-supply: true > > @@ -83,11 +88,8 @@ required: > - reg > - clocks > - clock-names > - - power-domains > - resets > - reset-names > - - vdda-phy-supply > - - vdda-pll-supply > - "#clock-cells" > - clock-output-names > - "#phy-cells" > @@ -119,21 +121,116 @@ allOf: > compatible: > contains: > enum: > - - qcom,sm8350-qmp-gen3x1-pcie-phy > - - qcom,sm8550-qmp-gen3x2-pcie-phy > - - qcom,sm8550-qmp-gen4x2-pcie-phy > + - qcom,msm8998-qmp-pcie-phy > then: > properties: > clocks: > - maxItems: 5 > + maxItems: 4 > clock-names: > + items: > + - const: aux > + - const: cfg_ahb > + - const: ref > + - const: pipe > + resets: > + maxItems: 2 > + reset-names: > + items: > + - const: phy > + - const: common Reset name looks wrong here too. > + required: > + - vdda-phy-supply > + - vdda-pll-supply > + > + - if: > + properties: > + compatible: > + contains: > + enum: > + - qcom,ipq6018-qmp-pcie-phy > + - qcom,ipq8074-qmp-gen3-pcie-phy > + - qcom,ipq8074-qmp-pcie-phy > + then: > + properties: > + clocks: > + maxItems: 3 > + clock-names: > + items: > + - const: aux > + - const: cfg_ahb > + - const: pipe > + resets: > + maxItems: 2 > + reset-names: > + items: > + - const: phy > + - const: common Same here. > + > + - if: > + properties: > + compatible: > + contains: > + enum: > + - qcom,sc8180x-qmp-pcie-phy > + - qcom,sdm845-qhp-pcie-phy > + - qcom,sdm845-qmp-pcie-phy > + - qcom,sdx55-qmp-pcie-phy > + - qcom,sm8250-qmp-gen3x1-pcie-phy > + - qcom,sm8250-qmp-gen3x2-pcie-phy > + - qcom,sm8250-qmp-modem-pcie-phy > + - qcom,sm8450-qmp-gen3x1-pcie-phy > + - qcom,sm8450-qmp-gen4x2-pcie-phy > + then: > + properties: > + clocks: > maxItems: 5 > - else: > + clock-names: > + items: > + - const: aux > + - const: cfg_ahb > + - const: ref > + - const: refgen This one should be named 'rchng' and this set a strict subset of the sc8280xp clocks. > + - const: pipe > + resets: > + maxItems: 1 > + reset-names: > + items: > + - const: phy > + required: > + - vdda-phy-supply > + - vdda-pll-supply > + > + - if: > + properties: > + compatible: > + contains: > + enum: > + - qcom,sm8350-qmp-gen3x1-pcie-phy > + - qcom,sm8550-qmp-gen3x2-pcie-phy > + resets: > + minItems: 1 > + reset-names: > + items: > + - const: phy > + then: > properties: > clocks: > - minItems: 6 > + maxItems: 5 > clock-names: > - minItems: 6 > + items: > + - const: aux > + - const: cfg_ahb > + - const: ref > + - const: rchng > + - const: pipe > + resets: > + maxItems: 1 > + reset-names: > + items: > + - const: phy > + required: > + - vdda-phy-supply > + - vdda-pll-supply > > - if: > properties: > @@ -143,16 +240,53 @@ allOf: > - qcom,sm8550-qmp-gen4x2-pcie-phy > then: > properties: > + clocks: > + maxItems: 5 > + clock-names: > + items: > + - const: aux > + - const: cfg_ahb > + - const: ref > + - const: rchng > + - const: pipe > resets: > minItems: 2 > reset-names: > - minItems: 2 > - else: > + items: > + - const: phy > + - const: phy_nocsr > + required: > + - vdda-phy-supply > + - vdda-pll-supply > + > + - if: > + properties: > + compatible: > + contains: > + enum: > + - qcom,sc8280xp-qmp-gen3x1-pcie-phy > + - qcom,sc8280xp-qmp-gen3x2-pcie-phy > + - qcom,sc8280xp-qmp-gen3x4-pcie-phy > + then: > properties: > + clocks: > + minItems: 6 > + clock-names: > + items: > + - const: aux > + - const: cfg_ahb > + - const: ref > + - const: rchng > + - const: pipe > + - const: pipediv2 > resets: > - maxItems: 1 > + minItems: 1 > reset-names: > - maxItems: 1 > + items: > + - const: phy > + required: > + - vdda-phy-supply > + - vdda-pll-supply > > examples: > - | > @@ -213,3 +347,30 @@ examples: > > #phy-cells = <0>; > }; > + - | > + #define GCC_PCIE1_PHY_REFGEN_CLK 47 > + #define GCC_PCIE_PHY_AUX_CLK 71 > + #define GCC_PCIE_WIGIG_CLKREF_EN 74 > + > + phy@1c0e000 { > + compatible = "qcom,sm8250-qmp-gen3x2-pcie-phy"; > + reg = <0x01c0e000 0x1c0>; > + > + clocks = <&gcc GCC_PCIE_PHY_AUX_CLK>, > + <&gcc GCC_PCIE_1_CFG_AHB_CLK>, > + <&gcc GCC_PCIE_WIGIG_CLKREF_EN>, > + <&gcc GCC_PCIE1_PHY_REFGEN_CLK>, > + <&gcc GCC_PCIE_1_PIPE_CLK>; > + clock-names = "aux", "cfg_ahb", "ref", "refgen", "pipe"; > + > + resets = <&gcc GCC_PCIE_1_PHY_BCR>; > + reset-names = "phy"; > + > + vdda-phy-supply = <&vreg_l10c_0p88>; > + vdda-pll-supply = <&vreg_l6b_1p2>; > + > + #clock-cells = <0>; > + clock-output-names = "pcie_1_pipe_clk"; > + > + #phy-cells = <0>; > + }; This example also looks redundant. Johan -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy