From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9AF82C678D5 for ; Wed, 8 Mar 2023 10:18:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9gz2dGzeNiKQOzd0JgOrJcw8WYFkyRe8vXpfOiTFFBk=; b=ffJehlcKcrgNVA 3xJhVcrrD4KOvO6LiJg0EdgJWA26HkXmMBHjY1qgSMSvmZp+P9N9vrQq9jKhbuYkapdmFKiAPdyLH UTyWvZWiT2WyV2Un7lQpvTiTWQcN/HYVEFMKR3c6heDqZ6d3CWP4p/ZJhGch/o5YTlt/ewcimxW94 tkFnUhk3j0vrrrpx4gSdADM/m10rCiYQ0YMQHfEVAA6NCTeYK0Z0+xnpjaBzYKpKvM/JjOCa6xr8a rjsNB+lgFVPhO0dgluSXQjAj0Rrrk/Au+sbRLeWUvYf9nTU/5ptNwc4e/wkagOa00OWaSdauk1XfB 8wgguR8s0c9eoRIvtetQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZqs3-004Ncn-Rz; Wed, 08 Mar 2023 10:18:07 +0000 Received: from mail-lj1-x229.google.com ([2a00:1450:4864:20::229]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZqs1-004Nbn-CM for linux-phy@lists.infradead.org; Wed, 08 Mar 2023 10:18:06 +0000 Received: by mail-lj1-x229.google.com with SMTP id g18so16056999ljl.3 for ; Wed, 08 Mar 2023 02:18:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678270681; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=krZQpr7uIm4vLx88h00ljILNedqe5S23Jc9CthZt6vU=; b=PEerjSzms92KVfFhY/EDDlsfRjdHx3uWqwcch/aK80fwALOeLAy74p2WPgAFoQNSSr sonOqt17DNZvs3NnL7QFpRcFnb/rklcHvxjsoXqPYtgwyQe8ahAiuPmtrYNDQLWG+XTb tbvH0r/yU5DXqsZxHw4ggMmgkQgS/DOmH2q3TLWciwkiXcnwB7pQFO8y78XRgdoK+v0H 2FT7VtiOankxEG3I3fZUkq6pNqY5MQJtuGBlLYr88pEuOw2Q/ddpZz6JPf+1gtzX8KqH +WizrEyfHbtEKvSwd8SG6RyPFdt273usiyvAh84KpFdLTG2bDzvdZeoGpfg3xL3nqSsf NMWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678270681; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=krZQpr7uIm4vLx88h00ljILNedqe5S23Jc9CthZt6vU=; b=fd6SItqcB9SzAhV5CtqZCzTeSwo/3Kmcx6RSB4+PLGaUA8ePIY7T14SExlqSg+rOI1 sJTDZKhIFTK9KU77sCVyxuxoOkZKtthCjc7cE1XeDDZEN++b5KWiHuIUJmeF3TAxE1HT kBH4EQ4ap/gwgVmmAUn1wilQOtDBpNWC2/Ey5zacNWWxjtv/vkB/2mmdt20e8xPsY/Hi cBRYuZQe1D4DfzQdq3paC1PXlV0weLJTr60TzJ+POjhgf49EgJq0HK1lr5+9quUk4riE FAvj8NzOXKw+M6cz5BsMbkxDkRdPPemlhn1OuNWVQZsM6NsZ42t5qUasYS65AXIrvkRq v4sA== X-Gm-Message-State: AO0yUKUu7xN/aWTltA7sat8dzA41o8I58uWPPiZ+rgmM0BYiZE8W38/v rRHRVLUKxTGCo4DNRmsz2aJ2tQ== X-Google-Smtp-Source: AK7set9n1U1YMBH0wlOoSKEkMVTtc4syUR8K40rQA+XD5LofbKGrhDBmIn2Es6laJf5Gpzy+YqdFcg== X-Received: by 2002:a2e:3111:0:b0:290:6e3b:be34 with SMTP id x17-20020a2e3111000000b002906e3bbe34mr4957732ljx.42.1678270681440; Wed, 08 Mar 2023 02:18:01 -0800 (PST) Received: from [192.168.1.101] (abyj16.neoplus.adsl.tpnet.pl. [83.9.29.16]) by smtp.gmail.com with ESMTPSA id c19-20020ac244b3000000b004cc9c2932a9sm2304433lfm.302.2023.03.08.02.17.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Mar 2023 02:18:01 -0800 (PST) Message-ID: Date: Wed, 8 Mar 2023 11:17:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v7 4/6] arm64: dts: qcom: sm6125: Add UFS nodes Content-Language: en-US To: Lux Aliaga , agross@kernel.org, andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, vkoul@kernel.org, kishon@kernel.org, alim.akhtar@samsung.com, avri.altman@wdc.com, bvanassche@acm.org, keescook@chromium.org, tony.luck@intel.com, gpiccoli@igalia.com Cc: ~postmarketos/upstreaming@lists.sr.ht, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-scsi@vger.kernel.org, linux-hardening@vger.kernel.org, phone-devel@vger.kernel.org, martin.botka@somainline.org, marijn.suijten@somainline.org References: <20230306170817.3806-1-they@mint.lgbt> <20230306170817.3806-5-they@mint.lgbt> From: Konrad Dybcio In-Reply-To: <20230306170817.3806-5-they@mint.lgbt> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230308_021805_450896_909BFFB4 X-CRM114-Status: UNSURE ( 7.63 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On 6.03.2023 18:08, Lux Aliaga wrote: > Adds a UFS host controller node and its corresponding PHY to > the sm6125 platform. > > Signed-off-by: Lux Aliaga > --- [...] > + ufs_mem_phy: phy@4807000 { > + compatible = "qcom,sm6125-qmp-ufs-phy"; > + reg = <0x04807000 0xdb8>; > + > + clocks = <&gcc GCC_UFS_MEM_CLKREF_CLK>, <&gcc GCC_UFS_PHY_PHY_AUX_CLK>; > + clock-names = "ref", "ref_aux"; Please wrap it into clocks = <&gcc GCC_UFS_MEM_CLKREF_CLK>, <&gcc GCC_UFS_PHY_PHY_AUX_CLK>; clock-names = "ref", "ref_aux"; and resolve the binding/offset situation. Otherwise, LGTM! Konrad > + > + resets = <&ufs_mem_hc 0>; > + reset-names = "ufsphy"; > + > + power-domains = <&gcc UFS_PHY_GDSC>; > + > + #phy-cells = <0>; > + > + status = "disabled"; > + }; > + > gpi_dma0: dma-controller@4a00000 { > compatible = "qcom,sm6125-gpi-dma", "qcom,sdm845-gpi-dma"; > reg = <0x04a00000 0x60000>; -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy