From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Johan Hovold <johan@kernel.org>
Cc: Lux Aliaga <they@mint.lgbt>,
agross@kernel.org, andersson@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, vkoul@kernel.org,
kishon@kernel.org, alim.akhtar@samsung.com, avri.altman@wdc.com,
bvanassche@acm.org, keescook@chromium.org, tony.luck@intel.com,
gpiccoli@igalia.com, ~postmarketos/upstreaming@lists.sr.ht,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org,
linux-scsi@vger.kernel.org, linux-hardening@vger.kernel.org,
phone-devel@vger.kernel.org, martin.botka@somainline.org,
marijn.suijten@somainline.org
Subject: Re: [PATCH v7 3/6] phy: qcom-qmp: Add SM6125 UFS PHY support
Date: Wed, 8 Mar 2023 12:34:15 +0100 [thread overview]
Message-ID: <cf6af928-78a9-7990-71d4-9f17daf718d8@linaro.org> (raw)
In-Reply-To: <ZAhwTcMZoCQVULQe@hovoldconsulting.com>
On 8.03.2023 12:23, Johan Hovold wrote:
> On Wed, Mar 08, 2023 at 12:15:39PM +0100, Konrad Dybcio wrote:
>>
>>
>> On 8.03.2023 12:02, Johan Hovold wrote:
>>> On Wed, Mar 08, 2023 at 11:09:48AM +0100, Konrad Dybcio wrote:
>>>>
>>>>
>>>> On 6.03.2023 18:08, Lux Aliaga wrote:
>>>>> The SM6125 UFS PHY is compatible with the one from SM6115. Add a
>>>>> compatible for it and modify the config from SM6115 to make them
>>>>> compatible with the SC8280XP binding
>>>>>
>>>>> Signed-off-by: Lux Aliaga <they@mint.lgbt>
>>>>> Reviewed-by: Martin Botka <martin.botka@somainline.org>
>>>>> ---
>>>>> drivers/phy/qualcomm/phy-qcom-qmp-ufs.c | 12 ++++++++++++
>>>>> 1 file changed, 12 insertions(+)
>>>>>
>>>>> diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c b/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
>>>>> index 318eea35b972..44c29fdfc551 100644
>>>>> --- a/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
>>>>> +++ b/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
>>>>> @@ -620,6 +620,13 @@ static const char * const qmp_phy_vreg_l[] = {
>>>>> "vdda-phy", "vdda-pll",
>>>>> };
>>>>>
>>>>> +static const struct qmp_ufs_offsets qmp_ufs_offsets_v3_660 = {
>>>>> + .serdes = 0,
>>>>> + .pcs = 0xc00,
>>>>> + .tx = 0x400,
>>>>> + .rx = 0x600,
>>>>> +};
>>>>> +
>>>>> static const struct qmp_ufs_offsets qmp_ufs_offsets_v5 = {
>>>>> .serdes = 0,
>>>>> .pcs = 0xc00,
>>>>> @@ -693,6 +700,8 @@ static const struct qmp_phy_cfg sdm845_ufsphy_cfg = {
>>>>> static const struct qmp_phy_cfg sm6115_ufsphy_cfg = {
>>>>> .lanes = 1,
>>>>>
>>>>> + .offsets = &qmp_ufs_offsets_v3_660,
>>>> Will this not trigger OOB r/w for the users of qcom,sm6115-smp-ufs-phy
>>>> which specify the regions separately (old binding style)?
>>>
>>> No, that should work fine.
>> So do you think the SM6115 binding could be updated too? Or should
>> we keep it as-is for ABI purposes?..
>
> They could be and the possibility has been raised. I think it may be
> more important to convert the old combo-phy binding (it's on my list,
> but I keep getting preempted), but at some point we can get rid of the
> legacy UFS binding as well.
Okay sounds good!
>
>>> But looks like this series needs to be rebased on 6.3-rc1 as these
>>> offsets are now already set in mainline.
>> ..Or did you do that already and I can't find it?
>
> It seems a previous version of this patch was merged almost two months
> ago.
>
> 9b9e29af984c ("phy: qcom-qmp: Add SM6125 UFS PHY support")
>
> Not sure what failed here.
My eyes :)
Konrad
>
> Johan
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2023-03-08 11:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-06 17:08 [PATCH v7 0/6] arm64: dts: qcom: sm6125: UFS and xiaomi-laurel-sprout support Lux Aliaga
2023-03-06 17:08 ` [PATCH v7 1/6] dt-bindings: ufs: qcom: Add SM6125 compatible string Lux Aliaga
2023-03-24 8:49 ` Krzysztof Kozlowski
2023-03-06 17:08 ` [PATCH v7 2/6] dt-bindings: phy: Add QMP UFS PHY compatible for SM6125 Lux Aliaga
2023-03-06 17:08 ` [PATCH v7 3/6] phy: qcom-qmp: Add SM6125 UFS PHY support Lux Aliaga
2023-03-08 10:09 ` Konrad Dybcio
2023-03-08 11:02 ` Johan Hovold
2023-03-08 11:15 ` Konrad Dybcio
2023-03-08 11:23 ` Johan Hovold
2023-03-08 11:34 ` Konrad Dybcio [this message]
2023-03-08 11:37 ` Lux Aliaga
2023-03-08 13:27 ` Johan Hovold
2023-03-06 17:08 ` [PATCH v7 4/6] arm64: dts: qcom: sm6125: Add UFS nodes Lux Aliaga
2023-03-08 10:17 ` Konrad Dybcio
2023-03-06 17:08 ` [PATCH v7 5/6] dt-bindings: arm: qcom: Document xiaomi,laurel-sprout board Lux Aliaga
2023-03-06 17:08 ` [PATCH v7 6/6] arm64: dts: qcom: sm6125: Initial support for xiaomi-laurel-sprout Lux Aliaga
2023-04-07 18:51 ` (subset) [PATCH v7 0/6] arm64: dts: qcom: sm6125: UFS and xiaomi-laurel-sprout support Bjorn Andersson
-- strict thread matches above, loose matches on Subject: below --
2023-03-06 16:52 Lux Aliaga
2023-03-06 16:52 ` [PATCH v7 3/6] phy: qcom-qmp: Add SM6125 UFS PHY support Lux Aliaga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf6af928-78a9-7990-71d4-9f17daf718d8@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=andersson@kernel.org \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=devicetree@vger.kernel.org \
--cc=gpiccoli@igalia.com \
--cc=johan@kernel.org \
--cc=keescook@chromium.org \
--cc=kishon@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=martin.botka@somainline.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=they@mint.lgbt \
--cc=tony.luck@intel.com \
--cc=vkoul@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).