From: "Ardelean, Alexandru" <alexandru.Ardelean@analog.com>
To: "lkp@intel.com" <lkp@intel.com>
Cc: "kbuild-all@lists.01.org" <kbuild-all@lists.01.org>,
"Popa, Stefan Serban" <StefanSerban.Popa@analog.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"sre@kernel.org" <sre@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3][RESEND] adp5061: Add support for battery charging enable
Date: Fri, 1 Nov 2019 13:52:02 +0000 [thread overview]
Message-ID: <0676d4f49624a60a6cb596eea8e9962b3dce531c.camel@analog.com> (raw)
In-Reply-To: <201910140646.Ch4WbSsG%lkp@intel.com>
On Mon, 2019-10-14 at 07:10 +0800, kbuild test robot wrote:
> [External]
>
> Hi Alexandru,
>
Phew.
My bad here.
Either I have based it an older tree probably, or the ARM compilers did not
catch this.
The x86_64 compiler seems pretty nitpick-y [which is good[.
Will fix.
> I love your patch! Yet something to improve:
>
> [auto build test ERROR on power-supply/for-next]
> [cannot apply to v5.4-rc2 next-20191011]
> [if your patch is applied to the wrong git tree, please drop us a note to
> help
> improve the system. BTW, we also suggest to use '--base' option to
> specify the
> base tree in git format-patch, please see
> https://stackoverflow.com/a/37406982]
>
> url:
> https://github.com/0day-ci/linux/commits/Alexandru-Ardelean/adp5061-Add-support-for-battery-charging-enable/20191014-035456
> base:
> https://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply.git
> for-next
> config: sparc64-allmodconfig (attached as .config)
> compiler: sparc64-linux-gcc (GCC) 7.4.0
> reproduce:
> wget
> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross
> -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # save the attached .config to linux build tree
> GCC_VERSION=7.4.0 make.cross ARCH=sparc64
>
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
>
> All error/warnings (new ones prefixed by >>):
>
> In file included from include/linux/kobject.h:20:0,
> from include/linux/module.h:17,
> from drivers/power/supply/adp5061.c:9:
> > > drivers/power/supply/adp5061.c:738:44: error: initialization from
> > > incompatible pointer type [-Werror=incompatible-pointer-types]
> static DEVICE_ATTR(charging_enabled, 0644,
> adp5061_get_charging_enabled,
> ^
> include/linux/sysfs.h:104:10: note: in definition of macro '__ATTR'
> .show = _show, \
> ^~~~~
> > > drivers/power/supply/adp5061.c:738:8: note: in expansion of macro
> > > 'DEVICE_ATTR'
> static DEVICE_ATTR(charging_enabled, 0644,
> adp5061_get_charging_enabled,
> ^~~~~~~~~~~
> drivers/power/supply/adp5061.c:738:44: note: (near initialization for
> 'dev_attr_charging_enabled.show')
> static DEVICE_ATTR(charging_enabled, 0644,
> adp5061_get_charging_enabled,
> ^
> include/linux/sysfs.h:104:10: note: in definition of macro '__ATTR'
> .show = _show, \
> ^~~~~
> > > drivers/power/supply/adp5061.c:738:8: note: in expansion of macro
> > > 'DEVICE_ATTR'
> static DEVICE_ATTR(charging_enabled, 0644,
> adp5061_get_charging_enabled,
> ^~~~~~~~~~~
> drivers/power/supply/adp5061.c:739:6: error: initialization from
> incompatible pointer type [-Werror=incompatible-pointer-types]
> adp5061_set_charging_enabled);
> ^
> include/linux/sysfs.h:105:11: note: in definition of macro '__ATTR'
> .store = _store, \
> ^~~~~~
> > > drivers/power/supply/adp5061.c:738:8: note: in expansion of macro
> > > 'DEVICE_ATTR'
> static DEVICE_ATTR(charging_enabled, 0644,
> adp5061_get_charging_enabled,
> ^~~~~~~~~~~
> drivers/power/supply/adp5061.c:739:6: note: (near initialization for
> 'dev_attr_charging_enabled.store')
> adp5061_set_charging_enabled);
> ^
> include/linux/sysfs.h:105:11: note: in definition of macro '__ATTR'
> .store = _store, \
> ^~~~~~
> > > drivers/power/supply/adp5061.c:738:8: note: in expansion of macro
> > > 'DEVICE_ATTR'
> static DEVICE_ATTR(charging_enabled, 0644,
> adp5061_get_charging_enabled,
> ^~~~~~~~~~~
> cc1: some warnings being treated as errors
>
> vim +738 drivers/power/supply/adp5061.c
>
> 737
> > 738 static DEVICE_ATTR(charging_enabled, 0644,
> adp5061_get_charging_enabled,
> 739 adp5061_set_charging_enabled);
> 740
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology
> Center
> https://lists.01.org/pipermail/kbuild-all Intel
> Corporation
prev parent reply other threads:[~2019-11-01 13:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-04 8:17 [PATCH 2/3] adp5061: Add support for battery charging enable Stefan Popa
2018-04-04 17:01 ` kbuild test robot
2018-04-10 9:51 ` [PATCH v2 " Stefan Popa
2018-04-11 15:10 ` [PATCH v3 3/4] " Stefan Popa
2019-10-11 10:56 ` [PATCH v3][RESEND] " Alexandru Ardelean
2019-10-13 23:10 ` kbuild test robot
2019-11-01 13:52 ` Ardelean, Alexandru [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0676d4f49624a60a6cb596eea8e9962b3dce531c.camel@analog.com \
--to=alexandru.ardelean@analog.com \
--cc=StefanSerban.Popa@analog.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lkp@intel.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).