From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47DE4EE4996 for ; Mon, 21 Aug 2023 13:11:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234117AbjHUNLo (ORCPT ); Mon, 21 Aug 2023 09:11:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233988AbjHUNLn (ORCPT ); Mon, 21 Aug 2023 09:11:43 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 524EFE8; Mon, 21 Aug 2023 06:11:41 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DC7B563544; Mon, 21 Aug 2023 13:11:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 81813C433C8; Mon, 21 Aug 2023 13:11:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692623500; bh=fKeIzDelBhcXSFwPC4v8AT95YfiJ57nqdgQdtNrfJN4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VsfbPZUkFt08a+Wx0UN0m8lvTnb/61UGGxfrg1HRj7GndsGHSlQ6Z7DiMk+vQwlho TTSL29bxPpzAy02jyElUvTTOnXNiWXT/Mm/G5GFQJAL8AzvZs4N9NR9yS8DvmAsiE2 X+/mMIN1FnSaaYoXTbhV7ANfuPzYQzpLlF75tlgPgbFAs/ooMbq7cGQILEV6ZpWJ2k fGLfYtU0WktuizrYDj2suYlO/9wI2muPELUhvd5nfPR+Jq8iAyGqaNVy/PnM6qo171 9dek6upF92jpbeNkPF5C1jx2jDXOUklt8z3S0Mf4ZbxHLmC1ei/bIkCxIDhEy2Doqs a/DT28fVwfJnQ== Date: Mon, 21 Aug 2023 14:11:30 +0100 From: Mark Brown To: Robin Murphy Cc: Shreeya Patel , Saravana Kannan , Geert Uytterhoeven , Greg Kroah-Hartman , stable@vger.kernel.org, John Stultz , "David S. Miller" , Alexey Kuznetsov , Hideaki YOSHIFUJI , Jakub Kicinski , Rob Herring , Geert Uytterhoeven , Yoshihiro Shimoda , Andy Shevchenko , Sudeep Holla , Andy Shevchenko , Naresh Kamboju , Basil Eljuse , Ferry Toth , Arnd Bergmann , Anders Roxell , linux-pm@vger.kernel.org, Nathan Chancellor , Sebastian Andrzej Siewior , "Rafael J. Wysocki" , Linus Torvalds , Sasha Levin , linux-kernel@vger.kernel.org, "gustavo.padovan@collabora.com" , Ricardo =?iso-8859-1?Q?Ca=F1uelo?= Navarro , Guillaume Charles Tucker , usama.anjum@collabora.com, kernelci@lists.linux.dev Subject: Re: [PATCH 5.17 127/298] driver core: Fix wait_for_device_probe() & deferred_probe_timeout interaction Message-ID: <0a06a54e-0348-4964-ab90-48c648712ed6@sirena.org.uk> References: <20220613094924.913340374@linuxfoundation.org> <20220613094928.793712131@linuxfoundation.org> <6283c4b1-2513-207d-4ed6-fdabf3f3880e@collabora.com> <2023081619-slapping-congrats-8e85@gregkh> <471bf84d-9d58-befc-8224-359a62e29786@collabora.com> <97b06c78-da3c-d8ab-ca72-ff37b9976f2a@collabora.com> <6d7a7ecc-1364-5cbe-0485-01d693dbdc6c@arm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="9yeLbFu7ADkQpySe" Content-Disposition: inline In-Reply-To: <6d7a7ecc-1364-5cbe-0485-01d693dbdc6c@arm.com> X-Cookie: Do not write below this line. Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org --9yeLbFu7ADkQpySe Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Aug 21, 2023 at 01:39:11PM +0100, Robin Murphy wrote: > On 2023-08-21 12:35, Shreeya Patel wrote: > > AFAIK, script for running the tests is immediately ran after the boot > > process is complete so there is no wait time. > Regardless of what the kernel is doing, it seems like a fundamentally dumb > test to specifically ask deferred probe to wait for up to a minute then > complain that it hasn't finished after 11 seconds :/ IIRC that stuff is expecting the modules to be loaded from the initramfs and checking from the main system which is a bit more sensible (at least in the case where there is a main filesystem). It's vulnerable to races but less so, especially given the time a Debian rootfs typically takes to boot over NFS. --9yeLbFu7ADkQpySe Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmTjYoEACgkQJNaLcl1U h9A6Swf/XtoTqsAUrhDq/Wh7JfVm3BoLQKbTuySudRcbCDjKQqaSOK6krL2dOyho pMlwv20MA3H+NF8I/hbsKh76FXvk08d1iLcKHll3kfZOxLUmdhOXY56bn88FStfd Yja0b9OFe5TkkxZngSggpps6F+hhI0Q1GbuX+VZKqwZ3+1cbM+osTfZDzxy5Y47x NwqGj95If45WtM2T1uom9ODZS1xKNH3Y7TO7Ifkpqf9sV0h+l4cWYEUOahfcEh6z hIH1+EeAJSqWhvoWxXgc0KkmrTV3MQetnfOOpofb9YEO7zvRnU2k/vzhY142cS3Z MfbPxUXC9o6LeMMrbYdhvLEEImawAQ== =cxsG -----END PGP SIGNATURE----- --9yeLbFu7ADkQpySe--