Linux-PM Archive on lore.kernel.org
 help / color / Atom feed
From: Georgi Djakov <georgi.djakov@linaro.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Linux PM list <linux-pm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>
Subject: Re: [GIT PULL] interconnect changes for 5.5
Date: Thu, 7 Nov 2019 17:42:13 +0200
Message-ID: <0cb5a6a6-399f-99e3-dc41-50114eea4025@linaro.org> (raw)
In-Reply-To: <20191107142111.GB109902@kroah.com>

Hi Greg,

On 11/7/19 16:21, Greg Kroah-Hartman wrote:
> On Thu, Nov 07, 2019 at 02:46:53PM +0200, Georgi Djakov wrote:
>> Hi Greg,
>>
>> This is a pull request with interconnect patches for the 5.5 merge window.
>> All patches have been for a while in linux-next without reported issues. The
>> details are in the signed tag. Please consider pulling into char-misc-next.
> 
> I don't know about
> 0003-interconnect-Disallow-interconnect-core-to-be-built-.patch here.
> Shouldn't you just fix up the dependancies of subsystems that rely on
> this?  We are moving more and more to kernels that "just work" with
> everything as modules, even on arm64 systems.  So forbiding the
> interconnect code from being able to be built as a module does not feel
> good to me at all.

Thank you for commenting on this! The initial idea was to keep everything as
modular as possible. The reasons behind this change is that other core
frameworks like cpufreq (and possibly others) want to call the interconnect
APIs. Some of these frameworks are built-in only and it would be easier to
handle dependencies if interconnect core built-in too. Now each user that
can be built-in has to specify in Kconfig that it depends on INTERCONNECT ||
!INTERCONNECT.

> 
> Same for
> 0007-interconnect-Remove-unused-module-exit-code-from-cor.patch, we are
> adding module_init/exit() calls to modules, do not remove them!
> 
> 
> Can you drop those two patches and resend?  Or I can just take these out
> of the pull request and apply the rest as patches for now, if that's
> easier for you to handle.

Ok, will drop them for now and re-send!

Thanks,
Georgi

  reply index

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-07 12:46 Georgi Djakov
2019-11-07 14:21 ` Greg Kroah-Hartman
2019-11-07 15:42   ` Georgi Djakov [this message]
2019-11-08 10:39     ` Greg Kroah-Hartman
2019-11-08 11:44       ` Georgi Djakov
2019-11-09  1:36       ` Bjorn Andersson
2019-11-09  8:48         ` Greg Kroah-Hartman
2019-11-09 20:27           ` Bjorn Andersson
2019-11-10 10:16             ` Greg Kroah-Hartman
2019-11-11  4:54               ` Viresh Kumar
2019-11-11  5:26                 ` Greg Kroah-Hartman
2019-11-14  8:41               ` Viresh Kumar
2019-11-14 12:59                 ` Georgi Djakov

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0cb5a6a6-399f-99e3-dc41-50114eea4025@linaro.org \
    --to=georgi.djakov@linaro.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-PM Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-pm/0 linux-pm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-pm linux-pm/ https://lore.kernel.org/linux-pm \
		linux-pm@vger.kernel.org
	public-inbox-index linux-pm

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-pm


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git