From: Douglas Raillard <douglas.raillard@arm.com>
To: Patrick Bellasi <patrick.bellasi@arm.com>,
Quentin Perret <quentin.perret@arm.com>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
mingo@redhat.com, peterz@infradead.org, dietmar.eggemann@arm.com
Subject: Re: [RFC PATCH 1/7] PM: Introduce em_pd_get_higher_freq()
Date: Wed, 19 Jun 2019 17:08:37 +0100 [thread overview]
Message-ID: <11976c37-65d3-e0c6-034d-cfec9ebb5b49@arm.com> (raw)
In-Reply-To: <20190516132250.hedtianse7rnk3wq@e110439-lin>
Hi Patrick,
On 5/16/19 2:22 PM, Patrick Bellasi wrote:
> On 16-May 14:01, Quentin Perret wrote:
>> On Thursday 16 May 2019 at 13:42:00 (+0100), Patrick Bellasi wrote:
>>>> +static inline unsigned long em_pd_get_higher_freq(struct em_perf_domain *pd,
>>>> + unsigned long min_freq, unsigned long cost_margin)
>>>> +{
>>>> + unsigned long max_cost = 0;
>>>> + struct em_cap_state *cs;
>>>> + int i;
>>>> +
>>>> + if (!pd)
>>>> + return min_freq;
>>>> +
>>>> + /* Compute the maximum allowed cost */
>>>> + for (i = 0; i < pd->nr_cap_states; i++) {
>>>> + cs = &pd->table[i];
>>>> + if (cs->frequency >= min_freq) {
>>>> + max_cost = cs->cost + (cs->cost * cost_margin) / 1024;
>>> ^^^^
>>> ... end here we should probably better use SCHED_CAPACITY_SCALE
>>> instead of hard-coding in values, isn't it?
>>
>> I'm not sure to agree. This isn't part of the scheduler per se, and the
>> cost thing isn't in units of capacity, but in units of power, so I don't
>> think SCHED_CAPACITY_SCALE is correct here.
>
> Right, I get the units do not match and it would not be elegant to use
> it here...
>
>> But I agree these hard coded values (that one, and the 512 in one of the
>> following patches) could use some motivation :-)
>
> ... ultimately SCHED_CAPACITY_SCALE is just SCHED_FIXEDPOINT_SCALE,
> which is adimensional. Perhaps we should use that or yet another alias
> for the same.
Would it be a good idea to use SCHED_FIXEDPOINT_SCALE in energy.c ?
Since it's not part of the scheduler, maybe there is a scale covering a wider scope,
or we can introduce a similar ENERGY_FIXEDPOINT_SCALE in energy_model.h.
>> Thanks,
>> Quentin
>
Thanks,
Douglas
next prev parent reply other threads:[~2019-06-19 16:08 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-08 17:42 [RFC PATCH 0/7] sched/cpufreq: Make schedutil energy aware douglas.raillard
2019-05-08 17:42 ` douglas.raillard
2019-05-08 17:42 ` [RFC PATCH 1/7] PM: Introduce em_pd_get_higher_freq() douglas.raillard
2019-05-08 17:42 ` douglas.raillard
2019-05-16 12:42 ` Patrick Bellasi
2019-05-16 12:42 ` Patrick Bellasi
2019-05-16 13:01 ` Quentin Perret
2019-05-16 13:01 ` Quentin Perret
2019-05-16 13:22 ` Patrick Bellasi
2019-05-16 13:22 ` Patrick Bellasi
2019-06-19 16:08 ` Douglas Raillard [this message]
2019-06-20 13:04 ` Patrick Bellasi
2019-06-21 10:17 ` Quentin Perret
2019-06-21 10:22 ` Quentin Perret
2019-05-16 13:06 ` Douglas Raillard
2019-05-16 13:06 ` Douglas Raillard
2019-05-08 17:42 ` [RFC PATCH 2/7] sched/cpufreq: Attach perf domain to sugov policy douglas.raillard
2019-05-08 17:42 ` douglas.raillard
2019-05-08 17:42 ` [RFC PATCH 3/7] sched/cpufreq: Hook em_pd_get_higher_power() into get_next_freq() douglas.raillard
2019-05-08 17:42 ` douglas.raillard
2019-05-08 17:42 ` [RFC PATCH 4/7] sched/cpufreq: Move up sugov_cpu_is_busy() douglas.raillard
2019-05-08 17:42 ` douglas.raillard
2019-05-08 17:42 ` [RFC PATCH 5/7] sched/cpufreq: sugov_cpu_is_busy for shared policy douglas.raillard
2019-05-08 17:42 ` douglas.raillard
2019-05-08 17:43 ` [RFC PATCH 6/7] sched/cpufreq: Improve sugov_cpu_is_busy accuracy douglas.raillard
2019-05-08 17:43 ` douglas.raillard
2019-05-16 12:55 ` Patrick Bellasi
2019-05-16 12:55 ` Patrick Bellasi
2019-06-19 16:19 ` Douglas Raillard
2019-06-20 11:05 ` Patrick Bellasi
2019-05-08 17:43 ` [RFC PATCH 7/7] sched/cpufreq: Boost schedutil frequency ramp up douglas.raillard
2019-05-08 17:43 ` douglas.raillard
2019-05-13 7:12 ` [RFC PATCH 0/7] sched/cpufreq: Make schedutil energy aware Viresh Kumar
2019-05-13 7:12 ` Viresh Kumar
2019-05-13 13:52 ` Douglas Raillard
2019-05-13 13:52 ` Douglas Raillard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11976c37-65d3-e0c6-034d-cfec9ebb5b49@arm.com \
--to=douglas.raillard@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=patrick.bellasi@arm.com \
--cc=peterz@infradead.org \
--cc=quentin.perret@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).