From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA096C31E5B for ; Wed, 19 Jun 2019 16:08:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AEE20217D7 for ; Wed, 19 Jun 2019 16:08:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725843AbfFSQIl (ORCPT ); Wed, 19 Jun 2019 12:08:41 -0400 Received: from foss.arm.com ([217.140.110.172]:46740 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727242AbfFSQIl (ORCPT ); Wed, 19 Jun 2019 12:08:41 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3E0E1344; Wed, 19 Jun 2019 09:08:40 -0700 (PDT) Received: from [10.1.195.43] (e107049-lin.cambridge.arm.com [10.1.195.43]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4BC9F3F246; Wed, 19 Jun 2019 09:08:39 -0700 (PDT) Subject: Re: [RFC PATCH 1/7] PM: Introduce em_pd_get_higher_freq() To: Patrick Bellasi , Quentin Perret Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, mingo@redhat.com, peterz@infradead.org, dietmar.eggemann@arm.com References: <20190508174301.4828-1-douglas.raillard@arm.com> <20190508174301.4828-2-douglas.raillard@arm.com> <20190516124200.opxczohjelhvrzmo@e110439-lin> <20190516130148.uhq55ptut47usnae@queper01-lin> <20190516132250.hedtianse7rnk3wq@e110439-lin> From: Douglas Raillard Organization: ARM Message-ID: <11976c37-65d3-e0c6-034d-cfec9ebb5b49@arm.com> Date: Wed, 19 Jun 2019 17:08:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190516132250.hedtianse7rnk3wq@e110439-lin> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB-large Content-Transfer-Encoding: 7bit Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Hi Patrick, On 5/16/19 2:22 PM, Patrick Bellasi wrote: > On 16-May 14:01, Quentin Perret wrote: >> On Thursday 16 May 2019 at 13:42:00 (+0100), Patrick Bellasi wrote: >>>> +static inline unsigned long em_pd_get_higher_freq(struct em_perf_domain *pd, >>>> + unsigned long min_freq, unsigned long cost_margin) >>>> +{ >>>> + unsigned long max_cost = 0; >>>> + struct em_cap_state *cs; >>>> + int i; >>>> + >>>> + if (!pd) >>>> + return min_freq; >>>> + >>>> + /* Compute the maximum allowed cost */ >>>> + for (i = 0; i < pd->nr_cap_states; i++) { >>>> + cs = &pd->table[i]; >>>> + if (cs->frequency >= min_freq) { >>>> + max_cost = cs->cost + (cs->cost * cost_margin) / 1024; >>> ^^^^ >>> ... end here we should probably better use SCHED_CAPACITY_SCALE >>> instead of hard-coding in values, isn't it? >> >> I'm not sure to agree. This isn't part of the scheduler per se, and the >> cost thing isn't in units of capacity, but in units of power, so I don't >> think SCHED_CAPACITY_SCALE is correct here. > > Right, I get the units do not match and it would not be elegant to use > it here... > >> But I agree these hard coded values (that one, and the 512 in one of the >> following patches) could use some motivation :-) > > ... ultimately SCHED_CAPACITY_SCALE is just SCHED_FIXEDPOINT_SCALE, > which is adimensional. Perhaps we should use that or yet another alias > for the same. Would it be a good idea to use SCHED_FIXEDPOINT_SCALE in energy.c ? Since it's not part of the scheduler, maybe there is a scale covering a wider scope, or we can introduce a similar ENERGY_FIXEDPOINT_SCALE in energy_model.h. >> Thanks, >> Quentin > Thanks, Douglas