From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PM-runtime: add tracepoints for usage_count changes
Date: Mon, 13 Jan 2020 12:29:33 +0100 [thread overview]
Message-ID: <12840272.KYWuQ3LjJR@kreacher> (raw)
In-Reply-To: <20200106100004.GA10946@qmqm.qmqm.pl>
On Monday, January 6, 2020 11:00:04 AM CET Michał Mirosław wrote:
> On Sat, Jan 04, 2020 at 07:21:23PM +0100, Greg Kroah-Hartman wrote:
> > On Sat, Jan 04, 2020 at 05:27:57PM +0100, Michał Mirosław wrote:
> > > Add tracepoints to remaining places where device's power.usage_count
> > > is changed. This helps debugging where and why autosuspend is prevented.
> > >
> > > Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
> > > ---
> > > drivers/base/power/runtime.c | 13 +++++++++++--
> > > include/trace/events/rpm.h | 6 ++++++
> > > 2 files changed, 17 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/base/power/runtime.c b/drivers/base/power/runtime.c
> > > index 48616f358854..16134a69bf6f 100644
> > > --- a/drivers/base/power/runtime.c
> > > +++ b/drivers/base/power/runtime.c
> > > @@ -1006,8 +1006,10 @@ int __pm_runtime_idle(struct device *dev, int rpmflags)
> > > int retval;
> > >
> > > if (rpmflags & RPM_GET_PUT) {
> > > - if (!atomic_dec_and_test(&dev->power.usage_count))
> > > + if (!atomic_dec_and_test(&dev->power.usage_count)) {
> > > + trace_rpm_usage_rcuidle(dev, rpmflags);
> >
> > Who and what is really going to use these tracepoints?
> >
> > And putting them in these if statements seems odd, are you sure that's
> > the correct place? What do these show to userspace?
> >
> > > return 0;
> > > + }
> > > }
> > >
> > > might_sleep_if(!(rpmflags & RPM_ASYNC) && !dev->power.irq_safe);
> > > @@ -1038,8 +1040,10 @@ int __pm_runtime_suspend(struct device *dev, int rpmflags)
> > > int retval;
> > >
> > > if (rpmflags & RPM_GET_PUT) {
> > > - if (!atomic_dec_and_test(&dev->power.usage_count))
> > > + if (!atomic_dec_and_test(&dev->power.usage_count)) {
> > > + trace_rpm_usage_rcuidle(dev, rpmflags);
> > > return 0;
> > > + }
> > > }
> > >
> > > might_sleep_if(!(rpmflags & RPM_ASYNC) && !dev->power.irq_safe);
> > > @@ -1101,6 +1105,7 @@ int pm_runtime_get_if_in_use(struct device *dev)
> > > retval = dev->power.disable_depth > 0 ? -EINVAL :
> > > dev->power.runtime_status == RPM_ACTIVE
> > > && atomic_inc_not_zero(&dev->power.usage_count);
> > > + trace_rpm_usage_rcuidle(dev, 0);
> >
> > Why this one?
> >
> >
> > > spin_unlock_irqrestore(&dev->power.lock, flags);
> > > return retval;
> > > }
> > > @@ -1434,6 +1439,8 @@ void pm_runtime_allow(struct device *dev)
> > > dev->power.runtime_auto = true;
> > > if (atomic_dec_and_test(&dev->power.usage_count))
> > > rpm_idle(dev, RPM_AUTO | RPM_ASYNC);
> > > + else
> > > + trace_rpm_usage_rcuidle(dev, RPM_AUTO | RPM_ASYNC);
> >
> > Are you sure this is correct?
> >
> > These feel odd...
>
> This covers all places where power.usage_count might have changed.
> If atomic_dec_and_test() decrements usage_count but not to zero,
> the new value will be traced in rpm_idle(). But if the value drops to
> zero, then we need to trace it explicitly to be able to have all changes
> accounted for in the trace.
>
> I actually used this patch to track down why USB storage device was
> not autosuspending correctly.
Fair enough, and the patch makes sense to me, so I'm queuing it up as 5.6
material.
Thanks!
prev parent reply other threads:[~2020-01-13 11:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-04 16:27 [PATCH] PM-runtime: add tracepoints for usage_count changes Michał Mirosław
2020-01-04 18:21 ` Greg Kroah-Hartman
2020-01-06 10:00 ` Michał Mirosław
2020-01-13 11:29 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12840272.KYWuQ3LjJR@kreacher \
--to=rjw@rjwysocki.net \
--cc=gregkh@linuxfoundation.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=pavel@ucw.cz \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).