From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Qais Yousef <qais.yousef@arm.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
Ingo Molnar <mingo@redhat.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpufreq: schedutil: fix equation in comment
Date: Wed, 07 Aug 2019 11:42:11 +0200 [thread overview]
Message-ID: <13854122.nn4VJ8hDQq@kreacher> (raw)
In-Reply-To: <20190805130620.GL2349@hirez.programming.kicks-ass.net>
On Monday, August 5, 2019 3:06:20 PM CEST Peter Zijlstra wrote:
> On Fri, Aug 02, 2019 at 11:46:28AM +0100, Qais Yousef wrote:
> > scale_irq_capacity() call in schedutil_cpu_util() does
> >
> > util *= (max - irq)
> > util /= max
> >
> > But the comment says
> >
> > util *= (1 - irq)
> > util /= max
> >
> > Fix the comment to match what the scaling function does.
> >
> > Signed-off-by: Qais Yousef <qais.yousef@arm.com>
>
> Thanks!
>
I've applied this, so please let me know if it has gone into -tip too and I'll drop it then.
next prev parent reply other threads:[~2019-08-07 9:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-02 10:46 [PATCH] cpufreq: schedutil: fix equation in comment Qais Yousef
2019-08-02 13:19 ` Vincent Guittot
2019-08-05 4:54 ` Viresh Kumar
2019-08-05 13:06 ` Peter Zijlstra
2019-08-07 9:42 ` Rafael J. Wysocki [this message]
2019-08-08 11:44 ` Qais Yousef
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13854122.nn4VJ8hDQq@kreacher \
--to=rjw@rjwysocki.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=qais.yousef@arm.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).