linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wang Weidong <wangweidong1@huawei.com>
To: rjw@rjwysocki.net, viresh.kumar@linaro.org
Cc: wangweidong1@huawei.com, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org, guohanjun@huawei.com
Subject: [PATCH 1/2] acpi-cpufreq: make the freq_table store the same freq value
Date: Fri, 28 Nov 2014 10:43:38 +0800	[thread overview]
Message-ID: <1417142619-14548-2-git-send-email-wangweidong1@huawei.com> (raw)
In-Reply-To: <1417142619-14548-1-git-send-email-wangweidong1@huawei.com>

As the initialized freq_tables maybe different from the p-states
values, so the array index is different as well.

Although in this case:
p-states value: [2400 2400 2000 ...], while the freq_tables:
[2400 2000 ... CPUFREQ_TABLE_END]. After setted the freqs 2000,
the perf->state is 3 while the freqs_table's index should be 2.
So when call the get_cur_freq_on_cpu, the freqs value we get
is 2400.

So, make the freq_table store the same value as well.

Signed-off-by: Wang Weidong <wangweidong1@huawei.com>
---
 drivers/cpufreq/acpi-cpufreq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c
index b0c18ed..93634a4 100644
--- a/drivers/cpufreq/acpi-cpufreq.c
+++ b/drivers/cpufreq/acpi-cpufreq.c
@@ -779,7 +779,7 @@ static int acpi_cpufreq_cpu_init(struct cpufreq_policy *policy)
 
 	/* table init */
 	for (i = 0; i < perf->state_count; i++) {
-		if (i > 0 && perf->states[i].core_frequency >=
+		if (i > 0 && perf->states[i].core_frequency >
 		    data->freq_table[valid_states-1].frequency / 1000)
 			continue;
 
-- 
1.7.12

  reply	other threads:[~2014-11-28  2:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-28  2:43 [PATCH 0/2] fix some problems for cpufreq Wang Weidong
2014-11-28  2:43 ` Wang Weidong [this message]
2014-11-28  2:43 ` [PATCH 2/2] cpufreq: show the real avail freqs with the freq_table Wang Weidong
2014-11-29  1:26 ` [PATCH 0/2] fix some problems for cpufreq Rafael J. Wysocki
2014-11-29  1:40   ` Wang Weidong
2014-11-29 22:30     ` Rafael J. Wysocki
2014-11-30  8:23       ` Wang Weidong
2014-12-02  4:38         ` Viresh Kumar
2014-12-03  5:49           ` Wang Weidong
2014-11-30 10:17 ` [PATCH v2] acpi-cpufreq: make the freq_table store the same freq value Wang Weidong
2014-12-27  1:33   ` [PATCH RESEND " Wang Weidong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1417142619-14548-2-git-send-email-wangweidong1@huawei.com \
    --to=wangweidong1@huawei.com \
    --cc=guohanjun@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).