linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "thermal-bot for Lukasz Luba" <tip-bot2@linutronix.de>
To: linux-pm@vger.kernel.org
Cc: Lukasz Luba <lukasz.luba@arm.com>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	rui.zhang@intel.com, amitk@kernel.org
Subject: [thermal: thermal/next] thermal/core/fair share: Use the lockless __thermal_cdev_update() function
Date: Tue, 27 Apr 2021 19:44:23 -0000	[thread overview]
Message-ID: <161955266363.29796.213784428248674373.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20210422153624.6074-3-lukasz.luba@arm.com>

The following commit has been merged into the thermal/next branch of thermal:

Commit-ID:     1a93369810660905f5e89b527cd709fa6832f7c8
Gitweb:        https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git//1a93369810660905f5e89b527cd709fa6832f7c8
Author:        Lukasz Luba <lukasz.luba@arm.com>
AuthorDate:    Thu, 22 Apr 2021 16:36:23 +01:00
Committer:     Daniel Lezcano <daniel.lezcano@linaro.org>
CommitterDate: Thu, 22 Apr 2021 23:51:32 +02:00

thermal/core/fair share: Use the lockless __thermal_cdev_update() function

Use the new helper function and avoid unnecessery second lock/unlock,
which was present in old approach with thermal_cdev_update().

Signed-off-by: Lukasz Luba <lukasz.luba@arm.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20210422153624.6074-3-lukasz.luba@arm.com
---
 drivers/thermal/gov_fair_share.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/thermal/gov_fair_share.c b/drivers/thermal/gov_fair_share.c
index 645432c..1e5abf4 100644
--- a/drivers/thermal/gov_fair_share.c
+++ b/drivers/thermal/gov_fair_share.c
@@ -107,10 +107,9 @@ static int fair_share_throttle(struct thermal_zone_device *tz, int trip)
 		instance->target = get_target_state(tz, cdev, percentage,
 						    cur_trip_level);
 
-		mutex_lock(&instance->cdev->lock);
-		instance->cdev->updated = false;
-		mutex_unlock(&instance->cdev->lock);
-		thermal_cdev_update(cdev);
+		mutex_lock(&cdev->lock);
+		__thermal_cdev_update(cdev);
+		mutex_unlock(&cdev->lock);
 	}
 
 	mutex_unlock(&tz->lock);

  reply	other threads:[~2021-04-27 19:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-22 15:36 [PATCH 0/3] Thermal governors improvements and a fix Lukasz Luba
2021-04-22 15:36 ` [PATCH 1/3] thermal: fair share: lock thermal zone while looping over instances Lukasz Luba
2021-04-27 19:44   ` [thermal: thermal/next] thermal/core/fair share: Lock the " thermal-bot for Lukasz Luba
2021-04-22 15:36 ` [PATCH 2/3] thermal: fair share: use __thermal_cdev_update() Lukasz Luba
2021-04-27 19:44   ` thermal-bot for Lukasz Luba [this message]
2021-04-22 15:36 ` [PATCH 3/3] thermal: power allocator: " Lukasz Luba
2021-04-27 19:44   ` [thermal: thermal/next] thermal/core/power allocator: Use the lockless __thermal_cdev_update() function thermal-bot for Lukasz Luba
2021-04-22 17:31 ` [PATCH 0/3] Thermal governors improvements and a fix Daniel Lezcano
2021-04-22 17:33   ` Lukasz Luba
2021-04-22 17:36     ` Daniel Lezcano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=161955266363.29796.213784428248674373.tip-bot2@tip-bot2 \
    --to=tip-bot2@linutronix.de \
    --cc=amitk@kernel.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=lukasz.luba@arm.com \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).