From: Stephen Boyd <sboyd@kernel.org>
To: Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Lee Jones <lee.jones@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
Sebastian Reichel <sre@kernel.org>,
devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org
Cc: Krzysztof Kozlowski <krzk@kernel.org>, Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v2 2/7] mfd: max77686: Do not enforce (incorrect) interrupt trigger type
Date: Wed, 26 May 2021 15:33:34 -0700 [thread overview]
Message-ID: <162206841417.4130789.13945208806958598688@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20210526172036.183223-3-krzysztof.kozlowski@canonical.com>
Quoting Krzysztof Kozlowski (2021-05-26 10:20:31)
> From: Krzysztof Kozlowski <krzk@kernel.org>
>
> Interrupt line can be configured on different hardware in different way,
> even inverted. Therefore driver should not enforce specific trigger
> type - edge falling - but instead rely on Devicetree to configure it.
>
> The Maxim 77686 datasheet describes the interrupt line as active low
> with a requirement of acknowledge from the CPU therefore the edge
> falling is not correct.
>
> The interrupt line is shared between PMIC and RTC driver, so using level
> sensitive interrupt is here especially important to avoid races. With
> an edge configuration in case if first PMIC signals interrupt followed
> shortly after by the RTC, the interrupt might not be yet cleared/acked
> thus the second one would not be noticed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> Acked-by: Rob Herring <robh@kernel.org>
>
> ---
Acked-by: Stephen Boyd <sboyd@kernel.org> # clock binding
next prev parent reply other threads:[~2021-05-26 22:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 17:20 [PATCH v2 0/7] mfd/power/rtc: Do not enforce (incorrect) interrupt trigger type Krzysztof Kozlowski
2021-05-26 17:20 ` [PATCH v2 1/7] mfd: sec-irq: " Krzysztof Kozlowski
2021-05-26 17:20 ` [PATCH v2 2/7] mfd: max77686: " Krzysztof Kozlowski
2021-05-26 22:33 ` Stephen Boyd [this message]
2021-05-26 17:20 ` [PATCH v2 3/7] mfd: max77693: " Krzysztof Kozlowski
2021-05-26 17:20 ` [PATCH v2 4/7] mfd: max14577: " Krzysztof Kozlowski
2021-05-26 17:20 ` [PATCH v2 5/7] rtc: max77686: " Krzysztof Kozlowski
2021-05-26 17:20 ` [PATCH v2 6/7] power: supply: max17042: " Krzysztof Kozlowski
2021-06-04 10:00 ` Sebastian Reichel
2021-05-26 17:20 ` [PATCH v2 7/7] power: supply: max17040: " Krzysztof Kozlowski
2021-06-02 20:06 ` Rob Herring
2021-06-04 10:01 ` Sebastian Reichel
2021-06-01 15:41 ` [PATCH v2 0/7] mfd/power/rtc: " Lee Jones
2021-06-01 16:13 ` Krzysztof Kozlowski
2021-06-20 20:22 ` (subset) " Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=162206841417.4130789.13945208806958598688@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=b.zolnierkie@samsung.com \
--cc=broonie@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).