From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Kelsey Skunberg <skunberg.kelsey@gmail.com>
Cc: rui.zhang@intel.com, edubezval@gmail.com,
daniel.lezcano@linaro.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, bjorn@helgaas.com,
skhan@linuxfoundation.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH] thermal: intel: int340x_thermal: Remove unnecessary acpi_has_method() uses
Date: Thu, 18 Jul 2019 10:36:57 +0200 [thread overview]
Message-ID: <1780280.CEgozTfreW@kreacher> (raw)
In-Reply-To: <20190717192639.90092-1-skunberg.kelsey@gmail.com>
On Wednesday, July 17, 2019 9:26:39 PM CEST Kelsey Skunberg wrote:
> acpi_evaluate_object() will already return in error if the method does not
> exist. Checking if the method is absent before the acpi_evaluate_object()
> call is not needed. Remove acpi_has_method() calls to avoid additional
> work.
>
> Signed-off-by: Kelsey Skunberg <skunberg.kelsey@gmail.com>
LGTM:
Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
> drivers/thermal/intel/int340x_thermal/acpi_thermal_rel.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/thermal/intel/int340x_thermal/acpi_thermal_rel.c b/drivers/thermal/intel/int340x_thermal/acpi_thermal_rel.c
> index 9716bc3abaf9..7130e90773ed 100644
> --- a/drivers/thermal/intel/int340x_thermal/acpi_thermal_rel.c
> +++ b/drivers/thermal/intel/int340x_thermal/acpi_thermal_rel.c
> @@ -77,9 +77,6 @@ int acpi_parse_trt(acpi_handle handle, int *trt_count, struct trt **trtp,
> struct acpi_buffer element = { 0, NULL };
> struct acpi_buffer trt_format = { sizeof("RRNNNNNN"), "RRNNNNNN" };
>
> - if (!acpi_has_method(handle, "_TRT"))
> - return -ENODEV;
> -
> status = acpi_evaluate_object(handle, "_TRT", NULL, &buffer);
> if (ACPI_FAILURE(status))
> return -ENODEV;
> @@ -158,9 +155,6 @@ int acpi_parse_art(acpi_handle handle, int *art_count, struct art **artp,
> struct acpi_buffer art_format = {
> sizeof("RRNNNNNNNNNNN"), "RRNNNNNNNNNNN" };
>
> - if (!acpi_has_method(handle, "_ART"))
> - return -ENODEV;
> -
> status = acpi_evaluate_object(handle, "_ART", NULL, &buffer);
> if (ACPI_FAILURE(status))
> return -ENODEV;
>
prev parent reply other threads:[~2019-07-18 8:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-17 19:26 [PATCH] thermal: intel: int340x_thermal: Remove unnecessary acpi_has_method() uses Kelsey Skunberg
2019-07-18 8:36 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1780280.CEgozTfreW@kreacher \
--to=rjw@rjwysocki.net \
--cc=bjorn@helgaas.com \
--cc=daniel.lezcano@linaro.org \
--cc=edubezval@gmail.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=skhan@linuxfoundation.org \
--cc=skunberg.kelsey@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).