linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: brcm,avs-ro-thermal: Fix binding check issues
@ 2020-01-16 18:41 Stefan Wahren
  2020-01-16 18:58 ` Rob Herring
  2020-01-16 19:09 ` Daniel Lezcano
  0 siblings, 2 replies; 3+ messages in thread
From: Stefan Wahren @ 2020-01-16 18:41 UTC (permalink / raw)
  To: Zhang Rui, Daniel Lezcano, Amit Kucheria, Rob Herring,
	Mark Rutland, Nicolas Saenz Julienne, Florian Fainelli,
	Catalin Marinas, Will Deacon
  Cc: linux-pm, linux-arm-kernel, bcm-kernel-feedback-list, devicetree,
	Stefan Wahren

Drop the reg property since this only necessary for the parent and
add the missing thermal-sensor-cells property description.

Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Fixes: 3d4849897691 ("dt-bindings: Add Broadcom AVS RO thermal")
---
 .../devicetree/bindings/thermal/brcm,avs-ro-thermal.yaml         | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/thermal/brcm,avs-ro-thermal.yaml b/Documentation/devicetree/bindings/thermal/brcm,avs-ro-thermal.yaml
index 98e7b57..d9fdf48 100644
--- a/Documentation/devicetree/bindings/thermal/brcm,avs-ro-thermal.yaml
+++ b/Documentation/devicetree/bindings/thermal/brcm,avs-ro-thermal.yaml
@@ -23,12 +23,15 @@ properties:
   compatible:
     const: brcm,bcm2711-thermal
 
-  reg:
-    maxItems: 1
+  # See ./thermal.txt for details
+  "#thermal-sensor-cells":
+    const: 0
 
 required:
   - compatible
-  - reg
+  - '#thermal-sensor-cells'
+
+additionalProperties: false
 
 examples:
   - |
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: brcm,avs-ro-thermal: Fix binding check issues
  2020-01-16 18:41 [PATCH] dt-bindings: brcm,avs-ro-thermal: Fix binding check issues Stefan Wahren
@ 2020-01-16 18:58 ` Rob Herring
  2020-01-16 19:09 ` Daniel Lezcano
  1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2020-01-16 18:58 UTC (permalink / raw)
  To: Stefan Wahren
  Cc: Zhang Rui, Daniel Lezcano, Amit Kucheria, Mark Rutland,
	Nicolas Saenz Julienne, Florian Fainelli, Catalin Marinas,
	Will Deacon, open list:THERMAL,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
	maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE, devicetree

On Thu, Jan 16, 2020 at 12:42 PM Stefan Wahren <stefan.wahren@i2se.com> wrote:
>
> Drop the reg property since this only necessary for the parent and
> add the missing thermal-sensor-cells property description.
>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> Fixes: 3d4849897691 ("dt-bindings: Add Broadcom AVS RO thermal")
> ---
>  .../devicetree/bindings/thermal/brcm,avs-ro-thermal.yaml         | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)

Thanks for the quick fix.

Reviewed-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: brcm,avs-ro-thermal: Fix binding check issues
  2020-01-16 18:41 [PATCH] dt-bindings: brcm,avs-ro-thermal: Fix binding check issues Stefan Wahren
  2020-01-16 18:58 ` Rob Herring
@ 2020-01-16 19:09 ` Daniel Lezcano
  1 sibling, 0 replies; 3+ messages in thread
From: Daniel Lezcano @ 2020-01-16 19:09 UTC (permalink / raw)
  To: Stefan Wahren, Zhang Rui, Amit Kucheria, Rob Herring,
	Mark Rutland, Nicolas Saenz Julienne, Florian Fainelli,
	Catalin Marinas, Will Deacon
  Cc: linux-pm, linux-arm-kernel, bcm-kernel-feedback-list, devicetree

On 16/01/2020 19:41, Stefan Wahren wrote:
> Drop the reg property since this only necessary for the parent and
> add the missing thermal-sensor-cells property description.
> 
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> Fixes: 3d4849897691 ("dt-bindings: Add Broadcom AVS RO thermal")
> ---

Applied, thanks

>  .../devicetree/bindings/thermal/brcm,avs-ro-thermal.yaml         | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/thermal/brcm,avs-ro-thermal.yaml b/Documentation/devicetree/bindings/thermal/brcm,avs-ro-thermal.yaml
> index 98e7b57..d9fdf48 100644
> --- a/Documentation/devicetree/bindings/thermal/brcm,avs-ro-thermal.yaml
> +++ b/Documentation/devicetree/bindings/thermal/brcm,avs-ro-thermal.yaml
> @@ -23,12 +23,15 @@ properties:
>    compatible:
>      const: brcm,bcm2711-thermal
>  
> -  reg:
> -    maxItems: 1
> +  # See ./thermal.txt for details
> +  "#thermal-sensor-cells":
> +    const: 0
>  
>  required:
>    - compatible
> -  - reg
> +  - '#thermal-sensor-cells'
> +
> +additionalProperties: false
>  
>  examples:
>    - |
> 


-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-01-16 19:09 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-16 18:41 [PATCH] dt-bindings: brcm,avs-ro-thermal: Fix binding check issues Stefan Wahren
2020-01-16 18:58 ` Rob Herring
2020-01-16 19:09 ` Daniel Lezcano

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).