From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7803EC6FA86 for ; Tue, 27 Sep 2022 06:39:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229698AbiI0Gjp (ORCPT ); Tue, 27 Sep 2022 02:39:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42280 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229458AbiI0Gjo (ORCPT ); Tue, 27 Sep 2022 02:39:44 -0400 Received: from loongson.cn (mail.loongson.cn [114.242.206.163]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 4C8601BEAE; Mon, 26 Sep 2022 23:39:41 -0700 (PDT) Received: from [10.180.13.64] (unknown [10.180.13.64]) by localhost.localdomain (Coremail) with SMTP id AQAAf8DxvmummjJjMaEiAA--.52293S2; Tue, 27 Sep 2022 14:39:34 +0800 (CST) Subject: Re: [PATCH v2 2/3] dt-bindings: thermal: Convert loongson2 to json-schema To: Krzysztof Kozlowski Cc: Rob Herring , "Rafael J . Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, zhanghongchen , =?UTF-8?B?5YiY5L2p5a6d?= , Yinbo Zhu , Daniel Lezcano , Amit Kucheria , Zhang Rui , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, zhanghongchen , =?UTF-8?B?5YiY5L2p5a6d?= References: <20220921015605.17078-1-zhuyinbo@loongson.cn> <20220921015605.17078-2-zhuyinbo@loongson.cn> <28a78a10.a7dd.1835f5aaf90.Coremail.zhuyinbo@loongson.cn> <4febe7e4.a96c.18362d997e3.Coremail.zhuyinbo@loongson.cn> <20220924174258.GA1011284-robh@kernel.org> <4ce14e3c.bf79.18377f44118.Coremail.zhuyinbo@loongson.cn> <1f3e153b-da8a-43fa-162f-9bea2ed3ef78@linaro.org> <73282433.c0c0.18378f2cf65.Coremail.zhuyinbo@loongson.cn> From: Yinbo Zhu Message-ID: <1f423ccd-9b2b-3416-c594-7ded6a3b32b6@loongson.cn> Date: Tue, 27 Sep 2022 14:39:34 +0800 User-Agent: Mozilla/5.0 (X11; Linux loongarch64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <73282433.c0c0.18378f2cf65.Coremail.zhuyinbo@loongson.cn> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-CM-TRANSID: AQAAf8DxvmummjJjMaEiAA--.52293S2 X-Coremail-Antispam: 1UD129KBjvJXoW3Gw15Wry7Xw4UKFyxXF4UCFg_yoWfAr47pF 17CayUCr4kJr18uwnrKF1UCFn0q345tr1DXrnrGw18Jryqqw13XF43Xr1UuryxGryjgF4U ZrWvgw12ga4UJ3DanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUU9l14x267AKxVW5JVWrJwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26ryj6F1UM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26F4j 6r4UJwA2z4x0Y4vEx4A2jsIE14v26F4UJVW0owA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gc CE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E 2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJV W8JwACjcxG0xvEwIxGrwACjI8F5VA0II8E6IAqYI8I648v4I1lFIxGxcIEc7CjxVA2Y2ka 0xkIwI1lc7I2V7IY0VAS07AlzVAYIcxG8wCY02Avz4vE-syl42xK82IYc2Ij64vIr41l4I 8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AK xVWUGVWUWwC2zVAF1VAY17CE14v26r4a6rW5MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcV AFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r4j6F4UMIIF0xvE42xK8VAvwI8I cIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r 4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjfUOmhFUUUUU X-CM-SenderInfo: 52kx5xhqerqz5rrqw2lrqou0/ Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org 在 2022/9/26 下午4:38, Yinbo Zhu 写道: > > >> -----原始邮件----- >> 发件人: "Krzysztof Kozlowski" >> 发送时间:2022-09-26 14:21:41 (星期一) >> 收件人: "Yinbo Zhu" , "Rob Herring" >> 抄送: "Rafael J . Wysocki" , "Daniel Lezcano" , "Amit Kucheria" , "Zhang Rui" , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, zhanghongchen , "刘佩宝" >> 主题: Re: [PATCH v2 2/3] dt-bindings: thermal: Convert loongson2 to json-schema >> >> On 26/09/2022 06:00, Yinbo Zhu wrote: >>> >>> >>>> -----原始邮件----- >>>> 发件人: "Rob Herring" >>>> 发送时间:2022-09-25 01:42:58 (星期日) >>>> 收件人: "朱银波" >>>> 抄送: "Krzysztof Kozlowski" , "Rafael J . Wysocki" , "Daniel Lezcano" , "Amit Kucheria" , "Zhang Rui" , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, zhanghongchen >>>> 主题: Re: Re: [PATCH v2 2/3] dt-bindings: thermal: Convert loongson2 to json-schema >>>> >>>> On Thu, Sep 22, 2022 at 09:39:30AM +0800, 朱银波 wrote: >>>>> >>>>> >>>>>> -----原始邮件----- >>>>>> 发件人: "Krzysztof Kozlowski" >>>>>> 发送时间:2022-09-21 17:31:11 (星期三) >>>>>> 收件人: "朱银波" >>>>>> 抄送: "Rafael J . Wysocki" , "Daniel Lezcano" , "Amit Kucheria" , "Zhang Rui" , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, zhanghongchen >>>>>> 主题: Re: [PATCH v2 2/3] dt-bindings: thermal: Convert loongson2 to json-schema >>>>>> >>>>>> On 21/09/2022 11:22, 朱银波 wrote: >>>>>>>> -----原始邮件----- >>>>>>>> 发件人: "Krzysztof Kozlowski" >>>>>>>> 发送时间:2022-09-21 15:05:00 (星期三) >>>>>>>> 收件人: "Yinbo Zhu" , "Rafael J . Wysocki" , "Daniel Lezcano" , "Amit Kucheria" , "Zhang Rui" , "Rob Herring" , "Krzysztof Kozlowski" , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org >>>>>>>> 抄送: zhanghongchen >>>>>>>> 主题: Re: [PATCH v2 2/3] dt-bindings: thermal: Convert loongson2 to json-schema >>>>>>>> >>>>>>>> On 21/09/2022 03:56, Yinbo Zhu wrote: >>>>>>>>> Convert the loongson2 thermal binding to DT schema format using >>>>>>>>> json-schema. >>>>>>>> Incorrect subject and incorrect commit msg. There is no conversion here. >>>>>>> Our soc architecture is the loongson2 series, so we will modify it accordingly. >>>>>> How the soc architecture is related to my comment that you do not >>>>>> perform conversion? >>>>> I got it, and I will aad a conversion. >>>>>>>>> Signed-off-by: Yinbo Zhu >>>>>>>>> --- >>>>>>>>> Change in v2: >>>>>>>>> 1. Add description and type about the "id". >>>>>>>>> 2. Make the filename was based on compatible. >>>>>>>>> >>>>>>>>> .../bindings/thermal/loongson2-thermal.yaml | 52 +++++++++++++++++++ >>>>>>>>> 1 file changed, 52 insertions(+) >>>>>>>>> create mode 100644 Documentation/devicetree/bindings/thermal/loongson2-thermal.yaml >>>>>>>>> >>>>>>>>> diff --git a/Documentation/devicetree/bindings/thermal/loongson2-thermal.yaml b/Documentation/devicetree/bindings/thermal/loongson2-thermal.yaml >>>>>>>>> new file mode 100644 >>>>>>>>> index 000000000000..2994ae3a56aa >>>>>>>>> --- /dev/null >>>>>>>>> +++ b/Documentation/devicetree/bindings/thermal/loongson2-thermal.yaml >>>>>>>> >>>>>>>> No improvements here. You ignore my comments, so I am going to NAK it. >>>>>>> I don't get your point, that dts compatible is "loongson,loongson2-thermal", so this driver file name is named >>>>>>> loongson2-thermal that according what you said about "Filename based on compatible." >>>>>>> If what I understand is not what you expect, please tell me how to modify it. >>>>>> >>>>>> Filename must match the compatible, so: loongson,loongson2-thermal.yaml >>>>> I got it, and I will add a conversion. >>>>>>>> >>>>>>>>> @@ -0,0 +1,52 @@ >>>>>>>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>>>>>>>> +%YAML 1.2 >>>>>>>>> +--- >>>>>>>>> +$id: http://devicetree.org/schemas/thermal/loongson2-thermal.yaml# >>>>>>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>>>>>>>> + >>>>>>>>> +title: Thermal sensors on loongson2 SoCs >>>>>>>>> + >>>>>>>>> +maintainers: >>>>>>>>> + - zhanghongchen >>>>>>>>> + - Yinbo Zhu >>>>>>>>> + >>>>>>>>> +properties: >>>>>>>>> + compatible: >>>>>>>>> + const: loongson,loongson2-thermal >>>>>>>>> + >>>>>>>>> + reg: >>>>>>>>> + maxItems: 1 >>>>>>>>> + >>>>>>>>> + id: >>>>>>>>> + $ref: '//schemas/types.yaml#/definitions/uint32' >>>>>>>> No improvements here, so let me be specific - you need to really justify >>>>>>>> such property or it cannot go to schema. >>>>>>> The loongson2_thermal.c driver need parse this "id" property. >>>>>> This is not reason to add properties to DT. DT describes the hardware, >>>>>> not driver behavior. >>>>>> >>>>>> Why hardware needs arbitrary, additional addressing number instead of >>>>>> standard unit address? >>>>> The loongson2 series soc supports up to four sensors, but the 2K1000 has only one sensor, so the ID must be 0. >>>>> For the 2K1000, in order to distinguish the differences between different hardware in the Loongson2 SoC series, >>>>> the ID is added to the dts >>>> Differences in SoCs is what 'compatible' is for. If 'loongson2' is not a >>>> specific SoC, then your compatible string is not specific enough. >>> If other loongson2 platforms are different from the thermal sensor, I will add compatible >>> "loongson,loongson2-thermal-xxx", please you note. >> No, this compatible looks wrong then. What is your SoC model number? You >> called loongson2 a "series", so that's not appropriate. Compatible >> should be specific. > Must it be strict here? I have a look about other platforms are similar to this one, eg. > examples: > - | > tmu@f0000 { > compatible = "fsl,qoriq-tmu"; > the qoriq series soc include ls1046a/ls1043/ls1088a/... > > and the compatible was "loongson,loongson2-xxx" is internal rules, we hope that code can as the rules > to upstream. > >>>>>>>>> + description: | >>>>>>>>> + Specify the thermal sensor id. >>>>>>>>> + minimum: 0 >>>>>>>>> + maximum: 3 >>>>>>>>> + >>>>>>>>> + interrupts: >>>>>>>>> + maxItems: 1 >>>>>>>>> + >>>>>>>>> + "#thermal-sensor-cells": >>>>>>>>> + const: 1 >>>> If one SoC only has 1 sensor, then this could be 0. However, you don't >>>> have to do that, but it's another way to distinguish differences. >>> okay ,I got it. >>>>>>>>> + >>>>>>>>> +required: >>>>>>>>> + - compatible >>>>>>>>> + - reg >>>>>>>>> + - id >>>>>>>>> + - interrupt-parent >>>>>>>> Why? >>>>>>> The interrupts of our dts do not specify an interrupt parent, >>>>>>> eg. interrupts = <7 IRQ_TYPE_LEVEL_LOW> >>>>>>> so we need to add an interrupt parent property. >>>>>> You can add but I am asking why is it required? >>>>> Since there is more than one interrupt controller in the Loongson2 series soc, that need to specify the interrupt >>>>> controller in the dts, that is, the interrupt parent. If different interrupt parents are used in dts, the interrupt >>>>> numbers are different. >>>> It is perfectly valid for the 'interrupt-parent' to be in *any* parent >>>> node. So it is never required by any binding. >>> I don't get your meaning, You mean I can add it in the dts, but I don't need to add it in the binding file, right? >> You should not add it to the binding because it is not related to the >> device itself. > okay, I got it. >>>> Rob >>> >> Don't include such footers. We cannot talk over confidential emails and >> you clearly state that here. >> >> Best regards, >> Krzysztof I'm sorry to add this footers,  this is a problem with my website mailbox. Later, I use my local mailbox to send emails, there will be no footprints in my local mailbox. TKs, BRs Yinbo Zhu. >