Linux-PM Archive on
 help / color / Atom feed
From: Shawn Guo <>
To: Zhang Rui <>
	Eduardo Valentin <>,
Subject: Re: [PATCH] thermal: add imx thermal driver support
Date: Thu, 13 Jun 2013 12:12:09 +0800
Message-ID: <> (raw)
In-Reply-To: <1371093177.2135.24.camel@rzhang1-mobl4>

On Thu, Jun 13, 2013 at 11:12:57AM +0800, Zhang Rui wrote:
> On Tue, 2013-06-04 at 15:13 +0800, Shawn Guo wrote:
> > This is based on the initial imx thermal work done by
> > Rob Lee <> (Not sure if the email address is still
> > valid).  Since he is no longer interested in the work and I have
> > rewritten a significant amount of the code, I just took the authorship
> > over from him.
> > 
> > It adds the imx thermal support using Temperature Monitor (TEMPMON)
> > block found on some Freescale i.MX SoCs.  The driver uses syscon regmap
> > interface to access TEMPMON control registers and calibration data, and
> > supports cpufreq as the cooling device.
> > 
> you're using the cpufrq_cooling to throttle cpus at 85C, right?


> then you should register it as THERMAL_TRIP_PASSIVE instead of

Yes, literally it should be a passive trip point rather than active
one.  But I'm not sure if there is any real functional differences
between them in my thermal case, except I have to give both
passive_delay and polling_delay in thermal_zone_device_register()
call for passive type while it only needs polling_delay for active type
to work properly.

Besides, both exynos and db8500 thermal drivers register active trip
point while they are using cpufreq as the cooling device.  So I thought
it's fine to not have the trip type literally correct.


  reply index

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-04  7:13 Shawn Guo
2013-06-13  0:16 ` Shawn Guo
2013-06-13  3:12 ` Zhang Rui
2013-06-13  4:12   ` Shawn Guo [this message]
2013-06-13  5:14     ` Zhang Rui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-PM Archive on

Archives are clonable:
	git clone --mirror linux-pm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-pm linux-pm/ \
	public-inbox-index linux-pm

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone