From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: =?utf-8?B?562U5aSNOiBbUEFUQ0g=?= =?utf-8?Q?=5D?= Delete some unusefull operations for centaur CPU/platform Date: Mon, 12 Mar 2018 10:46:09 +0100 Message-ID: <20180312094609.46sw3ojaa7sw3mee@gmail.com> References: <1519963908-4359-1-git-send-email-davidwang@zhaoxin.com> <20180312084033.lignixrpg4ruoxbq@gmail.com> <1792259.nnz4czxE5K@aspire.rjw.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1792259.nnz4czxE5K@aspire.rjw.lan> Sender: linux-kernel-owner@vger.kernel.org To: "Rafael J. Wysocki" Cc: David Wang , "len.brown@intel.com" , "pavel@ucw.cz" , "tglx@linutronix.de" , "mingo@redhat.com" , "hpa@zytor.com" , "x86@kernel.org" , "linux-pm@kernel.org" , "linux-kernel@vger.kernel.org" , "Bruce Chang (VAS)" , "Cooper Yan(BJ-RD)" , "Qiyuan Wang(BJ-RD)" , Benjamin Pan , Luke Lin , "Tim Guo(BJ-RD)" , "Cobe Chen(BJ-RD)" , "Jiangbo Wang(BJ-RD)" List-Id: linux-pm@vger.kernel.org * Rafael J. Wysocki wrote: > On Monday, March 12, 2018 9:40:33 AM CET Ingo Molnar wrote: > > > > * David Wang wrote: > > > > > [David] pr->flags.has_cst means BIOS define valid C state table. And at lease > > > define 2 entries. On all centaur platform which support C3, this condition is > > > always true. > > > > > [David] Just as the following comment said, we need not execute WBINVD and > > > ARB_DISABLE/ARB_ENABLE when entering C3 if bm_check=1 and bm_control=0. This > > > logic is valid for all platform not only for Centaur, I think. > > > > Ok, fair enough! > > Well, I still have this one queued up as cpuidle material. > > I can drop it if you want to take it instead. No need to drop it, it looks good to me! Thanks, Ingo