From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Lina Iyer <ilina@codeaurora.org>
Cc: edubezval@gmail.com, rui.zhang@intel.com,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
Ram Chandrasekar <rkumbako@codeaurora.org>
Subject: Re: [PATCH] drivers: thermal: step_wise: add support for hysteresis
Date: Tue, 8 May 2018 04:04:53 +0200 [thread overview]
Message-ID: <20180508020453.GH19313@mai> (raw)
In-Reply-To: <20180507175408.2154-1-ilina@codeaurora.org>
On Mon, May 07, 2018 at 11:54:08AM -0600, Lina Iyer wrote:
> From: Ram Chandrasekar <rkumbako@codeaurora.org>
>
> From: Ram Chandrasekar <rkumbako@codeaurora.org>
>
> Step wise governor increases the mitigation level when the temperature
> goes above a threshold and will decrease the mitigation when the
> temperature falls below the threshold. If it were a case, where the
> temperature hovers around a threshold, the mitigation will be applied
> and removed at every iteration. This reaction to the temperature is
> inefficient for performance.
>
> The use of hysteresis temperature could avoid this ping-pong of
> mitigation by relaxing the mitigation to happen only when the
> temperature goes below this lower hysteresis value.
I don't disagree with this but the ping-pong around a temperature is usually
avoided with a P-I-D computation which is implemented with the IPA governor.
Wouldn't be more interesting to add the power numbers like some other
platforms, so the IPA could be used?
You will probably have better results with the IPA than changing the step-wise
governor behavior (which may potentially impact other users).
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2018-05-08 2:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-07 17:54 [PATCH] drivers: thermal: step_wise: add support for hysteresis Lina Iyer
2018-05-08 2:04 ` Daniel Lezcano [this message]
2018-05-09 16:25 ` Lina Iyer
2018-07-26 8:49 ` Zhang Rui
2019-11-21 5:50 Amit Kucheria
2019-11-21 14:09 ` Thara Gopinath
2019-11-21 14:38 ` Amit Kucheria
2019-11-21 21:07 ` Thara Gopinath
2019-11-21 20:57 ` Thara Gopinath
2019-12-10 6:51 ` Amit Kucheria
2019-12-11 13:35 ` Daniel Lezcano
2020-01-08 0:31 ` Ram Chandrasekar
2020-01-09 22:46 ` Daniel Lezcano
2020-01-24 17:13 ` Ram Chandrasekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180508020453.GH19313@mai \
--to=daniel.lezcano@linaro.org \
--cc=edubezval@gmail.com \
--cc=ilina@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rkumbako@codeaurora.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).