From: Rob Herring <robh@kernel.org>
To: Craig Tatlor <ctatlor97@gmail.com>
Cc: linux-arm-msm@vger.kernel.org, Sebastian Reichel <sre@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Walleij <linus.walleij@linaro.org>,
Randy Dunlap <rdunlap@infradead.org>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 3/4] dt-bindings: power: supply: qcom_bms: Add bindings
Date: Mon, 11 Jun 2018 12:15:15 -0600 [thread overview]
Message-ID: <20180611181515.GA32546@rob-hp-laptop> (raw)
In-Reply-To: <20180607181306.9766-3-ctatlor97@gmail.com>
On Thu, Jun 07, 2018 at 07:12:51PM +0100, Craig Tatlor wrote:
> Add bindings for the Qualcomm Battery Monitoring system.
>
> Signed-off-by: Craig Tatlor <ctatlor97@gmail.com>
> ---
> * Changes from v4:
> Uses proper units and expands some definitions,
> along with changing vadc@ to adc@.
>
> .../bindings/power/supply/qcom_bms.txt | 91 +++++++++++++++++++
> 1 file changed, 91 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/power/supply/qcom_bms.txt
>
> diff --git a/Documentation/devicetree/bindings/power/supply/qcom_bms.txt b/Documentation/devicetree/bindings/power/supply/qcom_bms.txt
> new file mode 100644
> index 000000000000..a1a32d6ab460
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/supply/qcom_bms.txt
> @@ -0,0 +1,91 @@
> +Qualcomm Battery Monitoring System
> +
> +The Qualcomm Battery Monitoring System is found inside of Qualcomm PM8941
> +PMICs. It provides open circuit voltage (OCV) and coulomb counter registers
> +that allow the OS to infer a capacity level.
> +
> +Required properties:
> +- compatible: Should contain "qcom,pm8941-bms".
> +- reg: Specifies the SPMI address and length of the
> + controller's registers.
> +- interrupts: OCV threshold interrupt.
> +- io-channels: Should contain IIO channel specifier for the
> + ADC channel that reports battery temperature.
> +- io-channel-names: Should contain "temp".
> +- qcom,fcc-temp-legend-celcius: An array containing the temperature, in degC,
> + for each column of the full charge capacity
> + lookup table.
> +- qcom,fcc-lut-microamp-hours: An array of full charge capacity values in uah,
> + one entry for each temperature defined in in
> + qcom,fcc-temp-legend-celcius.
> +- qcom,ocv-temp-legend-celcius: An array containing the temperature, in degC,
> + for each column of the OCV lookup table.
> +- qcom,ocv-capacity-legend: An array containing the capacity for each
> + row of the OCV lookup table.
> +- qcom,ocv-lut-microvolt: An array of OCV values in uV, one entry for each
> + capacity defined in qcom,ocv-capacity-legend.
Need to say which of these are 8-bit values.
With that,
Reviewed-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2018-06-11 18:15 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-07 13:59 [PATCH v3 1/3] power: supply: Add support for the Qualcomm Battery Monitoring System Craig Tatlor
2018-04-07 13:59 ` [PATCH v3 2/3] dt-bindings: power: supply: qcom_bms: Add bindings Craig Tatlor
2018-04-07 13:59 ` [PATCH v3 3/3] MAINTAINERS: Add entry for the Qualcomm BMS Craig Tatlor
2018-04-07 16:37 ` [PATCH v3 1/3] power: supply: Add support for the Qualcomm Battery Monitoring System Randy Dunlap
2018-04-07 17:54 ` Craig Tatlor
2018-04-07 17:57 ` [PATCH v4 " Craig Tatlor
2018-04-07 17:57 ` [PATCH v4 2/3] dt-bindings: power: supply: qcom_bms: Add bindings Craig Tatlor
2018-04-13 16:35 ` Rob Herring
2018-04-13 17:08 ` Craig Tatlor
2018-04-13 17:10 ` Craig Tatlor
2018-04-15 12:55 ` Craig Tatlor
2018-04-18 21:16 ` Rob Herring
2018-04-07 17:57 ` [PATCH v4 3/3] MAINTAINERS: Add entry for the Qualcomm BMS Craig Tatlor
2018-04-26 11:34 ` [PATCH v4 1/3] power: supply: Add support for the Qualcomm Battery Monitoring System Linus Walleij
2018-04-30 18:06 ` Craig Tatlor
2018-06-07 18:12 ` [PATCH v5 1/4] fixp-arith: add a linear interpolation function Craig Tatlor
2018-06-07 18:12 ` [PATCH v5 2/4] power: supply: Add support for the Qualcomm Battery Monitoring System Craig Tatlor
2018-06-07 19:08 ` Randy Dunlap
2018-06-13 15:58 ` Craig Tatlor
2018-06-07 18:12 ` [PATCH v5 3/4] dt-bindings: power: supply: qcom_bms: Add bindings Craig Tatlor
2018-06-11 18:15 ` Rob Herring [this message]
2018-06-13 16:00 ` Craig Tatlor
2018-06-07 18:12 ` [PATCH v5 4/4] MAINTAINERS: Add entry for the Qualcomm BMS Craig Tatlor
2018-06-13 11:06 ` [PATCH v5 1/4] fixp-arith: add a linear interpolation function Linus Walleij
2018-06-13 11:12 ` Linus Walleij
2018-06-13 16:01 ` Craig Tatlor
2018-06-13 16:06 ` [PATCH v6 " Craig Tatlor
2018-06-13 16:06 ` [PATCH v6 2/4] power: supply: Add support for the Qualcomm Battery Monitoring System Craig Tatlor
2018-06-14 14:06 ` Linus Walleij
2018-06-13 16:06 ` [PATCH v6 3/4] dt-bindings: power: supply: qcom_bms: Add bindings Craig Tatlor
2018-06-13 22:53 ` Matthias Kaehlcke
2018-06-13 16:06 ` [PATCH v6 4/4] MAINTAINERS: Add entry for the Qualcomm BMS Craig Tatlor
2018-06-14 15:14 ` [PATCH v7 1/4] fixp-arith: add a linear interpolation function Craig Tatlor
2018-06-14 15:14 ` [PATCH v7 2/4] power: supply: Add support for the Qualcomm Battery Monitoring System Craig Tatlor
2018-09-16 13:48 ` Sebastian Reichel
2018-09-20 14:43 ` Craig
2018-06-14 15:14 ` [PATCH v7 3/4] dt-bindings: power: supply: qcom_bms: Add bindings Craig Tatlor
2018-09-16 12:10 ` Sebastian Reichel
2018-09-20 14:32 ` Craig
2018-09-20 16:58 ` Sebastian Reichel
2018-09-20 19:13 ` Craig
2018-09-20 21:42 ` Sebastian Reichel
2018-09-20 20:08 ` Baolin Wang
2018-09-20 22:13 ` Sebastian Reichel
2018-09-21 15:40 ` Linus Walleij
2018-06-14 15:14 ` [PATCH v7 4/4] MAINTAINERS: Add entry for the Qualcomm BMS Craig Tatlor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180611181515.GA32546@rob-hp-laptop \
--to=robh@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=ctatlor97@gmail.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab+samsung@kernel.org \
--cc=rdunlap@infradead.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).