From: Viresh Kumar <viresh.kumar@linaro.org>
To: Niklas Cassel <niklas.cassel@linaro.org>
Cc: Ilia Lin <ilia.lin@kernel.org>, Viresh Kumar <vireshk@kernel.org>,
Nishanth Menon <nm@ti.com>, Stephen Boyd <sboyd@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-arm-msm@vger.kernel.org, jorge.ramirez-ortiz@linaro.org,
Sricharan R <sricharan@codeaurora.org>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 2/9] cpufreq: qcom: Re-organise kryo cpufreq to use it for other nvmem based qcom socs
Date: Mon, 8 Apr 2019 16:14:49 +0530 [thread overview]
Message-ID: <20190408104449.zqbamhcrjheanlgt@vireshk-i7> (raw)
In-Reply-To: <20190404050931.9812-3-niklas.cassel@linaro.org>
On 04-04-19, 07:09, Niklas Cassel wrote:
> From: Sricharan R <sricharan@codeaurora.org>
>
> The kryo cpufreq driver reads the nvmem cell and uses that data to
> populate the opps. There are other qcom cpufreq socs like krait which
> does similar thing. Except for the interpretation of the read data,
> rest of the driver is same for both the cases. So pull the common things
> out for reuse.
This is really sad for me. The driver was added in May last year and I am quite
sure it would have been known at that time itself that there are more hardware
platforms which will end up using this driver because of the similarity in
hardware. Not that you (personally) could have done anything about it as you
weren't there then, but it should have been taken care of by the then
developers.
Anyway, its okay now, can't do anything but rename things.
--
viresh
next prev parent reply other threads:[~2019-04-08 10:44 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-04 5:09 [RFC PATCH 0/9] Add support for QCOM Core Power Reduction Niklas Cassel
2019-04-04 5:09 ` [RFC PATCH 2/9] cpufreq: qcom: Re-organise kryo cpufreq to use it for other nvmem based qcom socs Niklas Cassel
2019-04-06 6:07 ` Rob Herring
2019-04-06 6:07 ` Rob Herring
2019-04-08 7:04 ` Sricharan R
2019-04-08 7:04 ` Sricharan R
2019-04-08 10:44 ` Viresh Kumar [this message]
2019-04-08 10:44 ` Viresh Kumar
2019-04-04 5:09 ` [RFC PATCH 3/9] cpufreq: qcom: create a driver struct Niklas Cassel
2019-04-09 5:42 ` Viresh Kumar
2019-04-09 5:42 ` Viresh Kumar
2019-04-04 5:09 ` [RFC PATCH 4/9] cpufreq: qcom: support qcs404 on nvmem driver Niklas Cassel
2019-04-09 5:48 ` Viresh Kumar
2019-04-09 5:48 ` Viresh Kumar
2019-04-04 5:09 ` [RFC PATCH 5/9] cpufreq: Add qcs404 to cpufreq-dt-platdev blacklist Niklas Cassel
2019-04-04 5:09 ` [RFC PATCH 6/9] dt-bindings: opp: Add qcom-opp bindings with properties needed for CPR Niklas Cassel
2019-04-09 9:23 ` Viresh Kumar
2019-04-09 9:23 ` Viresh Kumar
2019-07-05 10:56 ` Niklas Cassel
2019-04-04 5:09 ` [RFC PATCH 8/9] power: avs: Add support for CPR (Core Power Reduction) Niklas Cassel
2019-04-08 10:30 ` [RFC PATCH 0/9] Add support for QCOM Core Power Reduction Viresh Kumar
2019-04-08 10:30 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190408104449.zqbamhcrjheanlgt@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=andy.gross@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=ilia.lin@kernel.org \
--cc=jorge.ramirez-ortiz@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=niklas.cassel@linaro.org \
--cc=nm@ti.com \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=sricharan@codeaurora.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).