From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BD55C43219 for ; Wed, 1 May 2019 23:42:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4A1C921479 for ; Wed, 1 May 2019 23:42:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PtzVkK4b" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726438AbfEAXmv (ORCPT ); Wed, 1 May 2019 19:42:51 -0400 Received: from mail-it1-f194.google.com ([209.85.166.194]:50822 "EHLO mail-it1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726380AbfEAXmE (ORCPT ); Wed, 1 May 2019 19:42:04 -0400 Received: by mail-it1-f194.google.com with SMTP id q14so363161itk.0; Wed, 01 May 2019 16:42:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VRrBRm+Zojzq1Xs8C9ndqMr3g130PwILxKvLl3EyBq0=; b=PtzVkK4bXPQLQ1KxKJjRnLy9Jzk62yNT6LaV9ugG04rl3m8c+4SNYWw9jxCrfy+emv 6my1oaDPLEa4TqHkOv2ZgjI3dmlITKvT1dLQWcQ9qRxMs1I/UE5nI2aoI6ewOJwP2Rfj +FwRD7zjxU42dbvBHT4woq3VNXUvY48thJEhQvEJAvGDbjWTnRrL/cxOxU+CEdclEChl Ma5ohYxpAWZBdxeAaghiBmf63SLg445soW+ouBmIwwJ6Je3VA0IutwKvoZNvecRSnHbf rwGRkcpJ2Dkl8j6gIVSpfF8ccaavqMErUDpDqumpd9SinYUHLt3JlKai2a78VVyhtOiL uB+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VRrBRm+Zojzq1Xs8C9ndqMr3g130PwILxKvLl3EyBq0=; b=BLLiCQ6DV1ZxP4u5bkfc7hpiTppX7VYkWWgTA3aTklGhPgqW1YHA8IIYYppbm884RR kWQSihLKL1fbH0pAak5kh+dSb/ggdSyxW6vIttnrPBxXvbUQc30idbAcVSkq4eaHdR8I QK2A1IVHy/XvSKbuvu8R/fZ4SP7mWd8Z0VLFkFL+kyx7XB1q8u3ti6Wsp7wqgkMpiYUT RFDv5UWG4qVzzk5ne4RRluKZkQQpHJr/RZl/GL91oe6fhTh5fILlQ7Mvc+xVJcGa9kub PxBIPqv2M3j7atXqfYbM35009jxAS3yO0eaBOnxYYdZ1lzkN6+vl7VfIfRZrksZK7/aT e2yw== X-Gm-Message-State: APjAAAXJ3RrUbWhTst+bfdP9RPSWM2+CWlJEIUYAm1YPIpfFVsTnDqd6 gU0TiesIZHo0jOvzOS4Grn0= X-Google-Smtp-Source: APXvYqwmIeMUoR/eZ2dqiRwYWtZe+e+IVQoxt32E9XCZdsA1OyVypjcufCzvutl6UBKmyl7kdJJoeA== X-Received: by 2002:a05:6638:209:: with SMTP id e9mr363429jaq.22.1556754123190; Wed, 01 May 2019 16:42:03 -0700 (PDT) Received: from localhost.localdomain (ppp94-29-35-107.pppoe.spdop.ru. [94.29.35.107]) by smtp.gmail.com with ESMTPSA id m3sm2392507ion.69.2019.05.01.16.42.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 01 May 2019 16:42:02 -0700 (PDT) From: Dmitry Osipenko To: Thierry Reding , Jonathan Hunter , MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Tomeu Vizoso Cc: linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 09/16] PM / devfreq: tegra: Avoid inconsistency of current frequency value Date: Thu, 2 May 2019 02:38:08 +0300 Message-Id: <20190501233815.32643-10-digetx@gmail.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190501233815.32643-1-digetx@gmail.com> References: <20190501233815.32643-1-digetx@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Message-ID: <20190501233808.xtKENtEhmpxP1e4vZbZVl1TimKCmHc2L3n2GOAu3ltg@z> The frequency value potentially could change in-between. It doesn't cause any real problem at all right now, but that could change in the future. Hence let's avoid the inconsistency. Reviewed-by: Chanwoo Choi Signed-off-by: Dmitry Osipenko --- drivers/devfreq/tegra-devfreq.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/devfreq/tegra-devfreq.c b/drivers/devfreq/tegra-devfreq.c index ea0da05cd7f2..5265d735419f 100644 --- a/drivers/devfreq/tegra-devfreq.c +++ b/drivers/devfreq/tegra-devfreq.c @@ -509,13 +509,15 @@ static int tegra_devfreq_get_dev_status(struct device *dev, { struct tegra_devfreq *tegra = dev_get_drvdata(dev); struct tegra_devfreq_device *actmon_dev; + unsigned long cur_freq; - stat->current_frequency = tegra->cur_freq * KHZ; + cur_freq = READ_ONCE(tegra->cur_freq); /* To be used by the tegra governor */ stat->private_data = tegra; /* The below are to be used by the other governors */ + stat->current_frequency = cur_freq * KHZ; actmon_dev = &tegra->devices[MCALL]; @@ -526,7 +528,7 @@ static int tegra_devfreq_get_dev_status(struct device *dev, stat->busy_time *= 100 / BUS_SATURATION_RATIO; /* Number of cycles in a sampling period */ - stat->total_time = ACTMON_SAMPLING_PERIOD * tegra->cur_freq; + stat->total_time = ACTMON_SAMPLING_PERIOD * cur_freq; stat->busy_time = min(stat->busy_time, stat->total_time); -- 2.21.0