From: Lubomir Rintel <lkundrak@v3.sk>
To: Andy Shevchenko <andy@infradead.org>, Darren Hart <dvhart@infradead.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Russell King <linux@armlinux.org.uk>,
Mark Rutland <mark.rutland@arm.com>,
platform-driver-x86@vger.kernel.org, linux-pm@vger.kernel.org,
Sebastian Reichel <sebastian.reichel@collabora.com>,
Lubomir Rintel <lkundrak@v3.sk>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Subject: [PATCH v7 05/10] Platform: OLPC: Use BIT() and GENMASK() for event masks
Date: Mon, 13 May 2019 09:56:36 +0200 [thread overview]
Message-ID: <20190513075641.1277716-6-lkundrak@v3.sk> (raw)
In-Reply-To: <20190513075641.1277716-1-lkundrak@v3.sk>
Just a cosmetic tidy-up.
Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
---
Changes since v5:
- Added Andy Shevchenko's Reviewed-by tag
Changes since v1:
- This patch was added to the set.
include/linux/olpc-ec.h | 23 ++++++++++++-----------
1 file changed, 12 insertions(+), 11 deletions(-)
diff --git a/include/linux/olpc-ec.h b/include/linux/olpc-ec.h
index 7fa3d27f7fee..f7b6a7eda232 100644
--- a/include/linux/olpc-ec.h
+++ b/include/linux/olpc-ec.h
@@ -2,6 +2,8 @@
#ifndef _LINUX_OLPC_EC_H
#define _LINUX_OLPC_EC_H
+#include <linux/bits.h>
+
/* XO-1 EC commands */
#define EC_FIRMWARE_REV 0x08
#define EC_WRITE_SCI_MASK 0x1b
@@ -17,17 +19,16 @@
#define EC_EXT_SCI_QUERY 0x85
/* SCI source values */
-#define EC_SCI_SRC_EMPTY 0x00
-#define EC_SCI_SRC_GAME 0x01
-#define EC_SCI_SRC_BATTERY 0x02
-#define EC_SCI_SRC_BATSOC 0x04
-#define EC_SCI_SRC_BATERR 0x08
-#define EC_SCI_SRC_EBOOK 0x10 /* XO-1 only */
-#define EC_SCI_SRC_WLAN 0x20 /* XO-1 only */
-#define EC_SCI_SRC_ACPWR 0x40
-#define EC_SCI_SRC_BATCRIT 0x80
-#define EC_SCI_SRC_GPWAKE 0x100 /* XO-1.5 only */
-#define EC_SCI_SRC_ALL 0x1FF
+#define EC_SCI_SRC_GAME BIT(0)
+#define EC_SCI_SRC_BATTERY BIT(1)
+#define EC_SCI_SRC_BATSOC BIT(2)
+#define EC_SCI_SRC_BATERR BIT(3)
+#define EC_SCI_SRC_EBOOK BIT(4) /* XO-1 only */
+#define EC_SCI_SRC_WLAN BIT(5) /* XO-1 only */
+#define EC_SCI_SRC_ACPWR BIT(6)
+#define EC_SCI_SRC_BATCRIT BIT(7)
+#define EC_SCI_SRC_GPWAKE BIT(8) /* XO-1.5 only */
+#define EC_SCI_SRC_ALL GENMASK(8, 0)
struct platform_device;
--
2.21.0
next prev parent reply other threads:[~2019-05-13 7:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-13 7:56 [PATCH v7 00/10] Add support for OLPC XO 1.75 Embedded Controller Lubomir Rintel
2019-05-13 7:56 ` [PATCH v7 01/10] dt-bindings: olpc,xo1.75-ec: Add OLPC XO-1.75 EC bindings Lubomir Rintel
2019-05-13 9:07 ` Pavel Machek
2019-05-13 13:18 ` Lubomir Rintel
2019-05-24 16:29 ` Andy Shevchenko
2019-08-01 19:27 ` OLPC in 5.3? was " Pavel Machek
2019-08-02 10:39 ` Lubomir Rintel
2019-08-03 8:47 ` Pavel Machek
2019-08-05 10:26 ` Lubomir Rintel
2019-08-07 12:31 ` Pavel Machek
2019-08-07 12:41 ` Lubomir Rintel
2019-05-13 7:56 ` [PATCH v7 02/10] Platform: OLPC: Remove an unused include Lubomir Rintel
2019-05-13 7:56 ` [PATCH v7 03/10] Platform: OLPC: Move EC-specific functionality out from x86 Lubomir Rintel
2019-05-13 7:56 ` [PATCH v7 04/10] Platform: OLPC: Avoid a warning if the EC didn't register yet Lubomir Rintel
2019-05-13 7:56 ` Lubomir Rintel [this message]
2019-05-13 7:56 ` [PATCH v7 06/10] Platform: OLPC: Add XO-1.75 EC driver Lubomir Rintel
2019-05-13 7:56 ` [PATCH v7 07/10] Platform: OLPC: Add a regulator for the DCON Lubomir Rintel
2019-05-13 7:56 ` [PATCH v7 08/10] power: supply: olpc_battery: Allow building the driver on non-x86 Lubomir Rintel
2019-05-13 7:56 ` [PATCH v7 09/10] ARM: export arm_pm_restart Lubomir Rintel
2019-05-13 7:56 ` [PATCH v7 10/10] Platform: OLPC: Add restart support to XO-1.75 EC driver Lubomir Rintel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190513075641.1277716-6-lkundrak@v3.sk \
--to=lkundrak@v3.sk \
--cc=andy.shevchenko@gmail.com \
--cc=andy@infradead.org \
--cc=dvhart@infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sebastian.reichel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).