From: Eduardo Valentin <edubezval@gmail.com>
To: Yuantian Tang <andy.tang@nxp.com>
Cc: rui.zhang@intel.com, robh+dt@kernel.org,
daniel.lezcano@linaro.org, mark.rutland@arm.com,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: thermal: Make cooling-maps property optional
Date: Thu, 23 May 2019 19:50:18 -0700 [thread overview]
Message-ID: <20190524025017.GA4146@localhost.localdomain> (raw)
In-Reply-To: <20190515093647.47656-1-andy.tang@nxp.com>
On Wed, May 15, 2019 at 05:36:47PM +0800, Yuantian Tang wrote:
> There may be no cooling device on system, or there are no enough
> cooling devices for each thermal zone in multiple thermal zone
> cases since cooling devices can't be shared.
> So make this property optional to remove such limitations.
Yeah, I am not sure that is enough reason to make this property
optional. Let me maybe ask you why do you care creating a thermal
zone if your control has no actions? Or rather, why bothering
setting up a control that has no actuators?
>
> Signed-off-by: Yuantian Tang <andy.tang@nxp.com>
> ---
> .../devicetree/bindings/thermal/thermal.txt | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/thermal/thermal.txt b/Documentation/devicetree/bindings/thermal/thermal.txt
> index ca14ba9..694e834 100644
> --- a/Documentation/devicetree/bindings/thermal/thermal.txt
> +++ b/Documentation/devicetree/bindings/thermal/thermal.txt
> @@ -142,11 +142,11 @@ Required properties:
> - trips: A sub-node which is a container of only trip point nodes
> Type: sub-node required to describe the thermal zone.
>
> +
> +Optional property:
> - cooling-maps: A sub-node which is a container of only cooling device
> Type: sub-node map nodes, used to describe the relation between trips
> and cooling devices.
> -
> -Optional property:
> - coefficients: An array of integers (one signed cell) containing
> Type: array coefficients to compose a linear relation between
> Elem size: one cell the sensors listed in the thermal-sensors property.
> --
> 1.7.1
>
next prev parent reply other threads:[~2019-05-24 2:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-15 9:36 [PATCH] dt-bindings: thermal: Make cooling-maps property optional Yuantian Tang
2019-05-15 9:36 ` Yuantian Tang
2019-05-24 2:50 ` Eduardo Valentin [this message]
2019-05-24 3:21 ` [EXT] " Andy Tang
2019-06-04 5:56 ` Andy Tang
2019-06-04 6:04 ` Daniel Lezcano
2019-06-24 7:32 ` [EXT] " Andy Tang
2020-03-09 4:54 [PATCH] dt-bindings: thermal: make " andy.tang
2020-03-16 14:52 ` Daniel Lezcano
2020-03-16 16:13 ` Amit Kucheria
2020-03-25 6:37 ` Amit Kucheria
2020-03-25 9:08 ` Daniel Lezcano
2020-03-23 19:56 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190524025017.GA4146@localhost.localdomain \
--to=edubezval@gmail.com \
--cc=andy.tang@nxp.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).