From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF23FC28CC0 for ; Thu, 30 May 2019 16:08:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B2EF225D59 for ; Thu, 30 May 2019 16:08:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="cVdkU0Us" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726520AbfE3QI1 (ORCPT ); Thu, 30 May 2019 12:08:27 -0400 Received: from mail-pl1-f195.google.com ([209.85.214.195]:44334 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726015AbfE3QI1 (ORCPT ); Thu, 30 May 2019 12:08:27 -0400 Received: by mail-pl1-f195.google.com with SMTP id c5so2744883pll.11 for ; Thu, 30 May 2019 09:08:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=CCzOFuBrRzsjGJT6QYZDplwoC8znNP+oEnCTc9pJCd8=; b=cVdkU0UsiubYEXpbBQbS7cvSuFjQe08Adw6e346iSTE5OsA/QADaLcgAVFLBakmg6z 2Q2O38L63Bn80R60xkrnN8k4evgFKp+1SBFNsoKvL2F2vTQOA/WqzUnFi3fuWiBpjCnh bf2mpR9Tm+9Kh9qyWRGBinlrH9NFfRCKnnjE4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=CCzOFuBrRzsjGJT6QYZDplwoC8znNP+oEnCTc9pJCd8=; b=KZuGRfZiuDuoUOtU31qytm6pIM8iXvTm0Y0tIHOctj06lNw77cvDABiJSu6CZ4A3CB XcuwO2lXBAjl8kSM0xra3VuXO0DkBGcBgzcCskZmf1gCQ8CXzQlt2h2HEeSvK4Ct8dSt YLWOWW469IVXnOlX/LmOAu7Rz7HlGFCni74IXZYSBvkB4uYogpeNJx8MQdT4oCq80Y66 vAec/dJayvvg1pKwIiO4jCF2GL6M7eFIuwZa86wsIjeYHuPrr0MHl+ML/UfXRha3Itwt qCDHlaaADmW7jH0jL+xGThGu1y6woE75jnP3Wk6ZO2eqDFHbqzQ6fUjJgcUhi1VA2vUO rRVw== X-Gm-Message-State: APjAAAVLac6Hou4KK1Ihe0AJKtfUaWQKxbEAgsKHoHbYqo+mZR4+N8zl qvo7HrxpmBo0oxaFPRlKQhI8vw== X-Google-Smtp-Source: APXvYqwTufU4ReY8GoGuWrjOS8pyLhEFpYHGf/dPgPB2mg1+d5otdc1js0QS6kCxqXlGXEcw9FpdAA== X-Received: by 2002:a17:902:690b:: with SMTP id j11mr4416976plk.149.1559232506416; Thu, 30 May 2019 09:08:26 -0700 (PDT) Received: from localhost ([2620:15c:202:1:75a:3f6e:21d:9374]) by smtp.gmail.com with ESMTPSA id a69sm4045967pfa.81.2019.05.30.09.08.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 30 May 2019 09:08:25 -0700 (PDT) Date: Thu, 30 May 2019 09:08:25 -0700 From: Matthias Kaehlcke To: Hsin-Yi Wang Cc: "michael.kao" , Zhang Rui , Eduardo Valentin , Daniel Lezcano , Rob Herring , Mark Rutland , Matthias Brugger , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, lkml , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-mediatek@lists.infradead.org Subject: Re: [PATCH v2 1/8] arm64: dts: mt8183: add thermal zone node Message-ID: <20190530160825.GM40515@google.com> References: <1557494826-6044-1-git-send-email-michael.kao@mediatek.com> <1557494826-6044-2-git-send-email-michael.kao@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Thu, May 30, 2019 at 02:27:28PM +0800, Hsin-Yi Wang wrote: > On Fri, May 10, 2019 at 9:27 PM michael.kao wrote: > > > + > > + tzts1: tzts1 { > > + polling-delay-passive = <0>; > > + polling-delay = <0>; > > + thermal-sensors = <&thermal 1>; > > + sustainable-power = <0>; > > + trips {}; > > + cooling-maps {}; > > + }; > > + > Is 0 a valid initial sustainable-power setting? Since we'll still get > warning[1] about this, though it might not be harmful. > > If 0 is a valid setting, maybe we should consider showing the warning > of not setting this property in [2]? > > [1] https://elixir.bootlin.com/linux/latest/source/drivers/thermal/power_allocator.c#L570 > [2] https://elixir.bootlin.com/linux/latest/source/drivers/thermal/of-thermal.c#L1049 IIUC a value of 0 is pointless, the thermal framework will still use an estimated value: https://elixir.bootlin.com/linux/v5.1.5/source/drivers/thermal/power_allocator.c#L203 As commented on v1 (https://patchwork.kernel.org/patch/10926519/#22620905) the value of the property may depend on the thermal characteristics of the device, there is not one correct value per SoC/core. If it is specified at SoC level device makers should be aware that they might have to override it for 'optimal' behavior on their device.