From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF58EC31E40 for ; Mon, 10 Jun 2019 17:16:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 911D8207E0 for ; Mon, 10 Jun 2019 17:16:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728478AbfFJRQ0 (ORCPT ); Mon, 10 Jun 2019 13:16:26 -0400 Received: from foss.arm.com ([217.140.110.172]:46590 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728431AbfFJRQ0 (ORCPT ); Mon, 10 Jun 2019 13:16:26 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5CF56337; Mon, 10 Jun 2019 10:16:25 -0700 (PDT) Received: from redmoon (unknown [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AB4803F246; Mon, 10 Jun 2019 10:16:22 -0700 (PDT) Date: Mon, 10 Jun 2019 18:16:08 +0100 From: Lorenzo Pieralisi To: Ulf Hansson Cc: Sudeep Holla , Bjorn Andersson , "Rafael J. Wysocki" , Mark Rutland , Linux ARM , "Rafael J . Wysocki" , Daniel Lezcano , "Raju P . L . S . S . S . N" , Amit Kucheria , Stephen Boyd , Niklas Cassel , Tony Lindgren , Kevin Hilman , Lina Iyer , Viresh Kumar , Vincent Guittot , Geert Uytterhoeven , Souvik Chakravarty , Linux PM , linux-arm-msm , Linux Kernel Mailing List Subject: Re: [PATCH 00/18] ARM/ARM64: Support hierarchical CPU arrangement for PSCI Message-ID: <20190610171557.GA4560@redmoon> References: <20190513192300.653-1-ulf.hansson@linaro.org> <20190607154210.GJ15577@e107155-lin> <20190607193407.GB24059@builder> <20190610103225.GA26602@e107155-lin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Mon, Jun 10, 2019 at 05:54:39PM +0200, Ulf Hansson wrote: [...] > My summary from the earlier ones, is that because the PSCI spec > includes support for OSI, we should also support it in the kernel (and > ATF). In a discussion offlist, Lorenzo agreed that it's okay to add, > without an apple to apple comparison. Maybe Lorenzo can fill in and > state this publicly, to save us all some time? The comparison should have been made before even requesting PSCI OSI mode changes to the specifications, so we have a chip on our shoulders anyway. We will enable PSCI OSI but that's not where the problem lies, enabling PSCI OSI from a firmware perspective should take 10 lines of code, not: drivers/firmware/psci/Makefile | 2 +- drivers/firmware/psci/psci.c | 219 ++++++++-- drivers/firmware/psci/psci.h | 29 ++ drivers/firmware/psci/psci_pm_domain.c | 403 ++++++++++++++++++ I have some concerns about these changes that I will state in the relevant patches. > My final point in regards to the OSI mode support, it's a minor part > of the series. I don't see how that should hurt from a maintenance > point of view, or perhaps I am wrong? In any case, I offer my help > with review/maintenance in any form as you may see need/fit. I will go through the series but most of this code should move to core PM code, it has nothing to do with PSCI. BTW, apologies for the delay, I was away. Thanks, Lorenzo